From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00937C433ED for ; Sun, 18 Apr 2021 19:04:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD009610E7 for ; Sun, 18 Apr 2021 19:04:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231337AbhDRTFI (ORCPT ); Sun, 18 Apr 2021 15:05:08 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:60960 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbhDRTFI (ORCPT ); Sun, 18 Apr 2021 15:05:08 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 706E24AB; Sun, 18 Apr 2021 21:04:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1618772678; bh=hn30ftsClelrLXllK6EPclONQRfCaNw6X3yB6s6RGvw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UT+/SyS9e6fUjkW6ytQAEJPrvUiRxB9YW5HnowMHJxBJFEsdWVmqr1oLQCY7Az76D F/k2wVGVE9ch6QGlURvRxJdbdmhVvPII96tHmXO7GQB0O1ijV/LjI5IsuDwss8XkQY GqUIq1VtIvxZTac/37GnH928YLksr3724zulCDoI= Date: Sun, 18 Apr 2021 22:04:35 +0300 From: Laurent Pinchart To: Tomi Valkeinen Cc: linux-media@vger.kernel.org, sakari.ailus@linux.intel.com, Jacopo Mondi , niklas.soderlund+renesas@ragnatech.se, Mauro Carvalho Chehab , Hans Verkuil Subject: Re: [PATCH v5 22/24] v4l: subdev: add v4l2_subdev_get_format_dir() Message-ID: References: <20210415130450.421168-1-tomi.valkeinen@ideasonboard.com> <20210415130450.421168-23-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210415130450.421168-23-tomi.valkeinen@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Tomi, Thank you for the patch. On Thu, Apr 15, 2021 at 04:04:48PM +0300, Tomi Valkeinen wrote: > Add v4l2_subdev_get_format_dir() which can be used to find subdev format > for a specific stream on a multiplexed pad. The function will follow the > routes and links until it finds a non-multiplexed pad. > > Signed-off-by: Tomi Valkeinen > --- > drivers/media/v4l2-core/v4l2-subdev.c | 96 +++++++++++++++++++++++++++ > include/media/v4l2-subdev.h | 26 ++++++++ > 2 files changed, 122 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c > index 7a4f71d8c6c3..430dbdaab080 100644 > --- a/drivers/media/v4l2-core/v4l2-subdev.c > +++ b/drivers/media/v4l2-core/v4l2-subdev.c > @@ -998,6 +998,102 @@ bool v4l2_subdev_has_route(struct v4l2_subdev_krouting *routing, > } > EXPORT_SYMBOL_GPL(v4l2_subdev_has_route); > > +int v4l2_subdev_get_format_dir(struct media_pad *pad, u16 stream, > + enum v4l2_direction dir, > + struct v4l2_subdev_format *fmt) > +{ > + struct device *dev = pad->entity->graph_obj.mdev->dev; > + int ret; > + int i; > + > + dev_dbg(dev, "%s '%s':%u:%u %s\n", __func__, > + pad->entity->name, pad->index, stream, > + dir == V4L2_DIR_SOURCEWARD ? "sourceward" : "sinkward"); > + > + while (true) { > + struct v4l2_subdev_krouting routing; > + struct v4l2_subdev_route *route; > + > + if (pad->entity->obj_type != MEDIA_ENTITY_TYPE_V4L2_SUBDEV) > + return -EINVAL; > + > + ret = v4l2_subdev_link_validate_get_format(pad, fmt); > + if (ret == 0) > + return 0; > + else if (ret != -ENOIOCTLCMD) > + return ret; > + > + if (pad->flags & > + (dir == V4L2_DIR_SINKWARD ? MEDIA_PAD_FL_SOURCE : > + MEDIA_PAD_FL_SINK)) { > + pad = media_entity_remote_pad(pad); > + > + if (!pad) > + return -EINVAL; > + > + if (pad->entity->obj_type != MEDIA_ENTITY_TYPE_V4L2_SUBDEV) > + return -EINVAL; > + > + ret = v4l2_subdev_link_validate_get_format(pad, fmt); > + if (ret == 0) > + return 0; > + else if (ret != -ENOIOCTLCMD) > + return ret; > + } > + > + ret = v4l2_subdev_get_krouting(media_entity_to_v4l2_subdev(pad->entity), &routing); > + if (ret) > + return ret; > + > + route = NULL; > + for (i = 0; i < routing.num_routes; ++i) { > + u16 near_pad = dir == V4L2_DIR_SINKWARD ? > + routing.routes[i].sink_pad : > + routing.routes[i].source_pad; > + u16 near_stream = dir == V4L2_DIR_SINKWARD ? > + routing.routes[i].sink_stream : > + routing.routes[i].source_stream; > + > + if (!(routing.routes[i].flags & V4L2_SUBDEV_ROUTE_FL_ACTIVE)) > + continue; > + > + if (near_pad != pad->index) > + continue; > + > + if (near_stream != stream) > + continue; > + > + if (route) { > + dev_err(dev, > + "%s: '%s' has multiple active routes for stream %u\n", > + __func__, pad->entity->name, stream); > + v4l2_subdev_free_routing(&routing); > + return -EINVAL; > + } > + > + route = &routing.routes[i]; > + } > + > + if (!route) { > + dev_err(dev, "%s: no route found in '%s' for stream %u\n", > + __func__, pad->entity->name, stream); > + v4l2_subdev_free_routing(&routing); > + return -EINVAL; > + } > + > + if (dir == V4L2_DIR_SINKWARD) { > + pad = &pad->entity->pads[route->source_pad]; > + stream = route->source_stream; > + } else { > + pad = &pad->entity->pads[route->sink_pad]; > + stream = route->sink_stream; > + } > + > + v4l2_subdev_free_routing(&routing); > + } > +} > +EXPORT_SYMBOL_GPL(v4l2_subdev_get_format_dir); > + > int v4l2_subdev_link_validate(struct media_link *link) > { > struct v4l2_subdev *sink; > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h > index 1843b77dd843..730631f9a091 100644 > --- a/include/media/v4l2-subdev.h > +++ b/include/media/v4l2-subdev.h > @@ -1239,4 +1239,30 @@ void v4l2_subdev_cpy_routing(struct v4l2_subdev_krouting *dst, > bool v4l2_subdev_has_route(struct v4l2_subdev_krouting *routing, > unsigned int pad0, unsigned int pad1); > > +/** > + * enum v4l2_direction - Direction either towards the source or the sink > + * > + * @V4L2_DIR_SOURCEWARD: Direction towards the source. > + * @V4L2_DIR_SINKWARD: Direction towards the sink. > + */ > +enum v4l2_direction { > + V4L2_DIR_SOURCEWARD, > + V4L2_DIR_SINKWARD, > +}; > + > +/** > + * v4l2_subdev_get_format_dir() - Find format by following streams The name is a bit cryptic, and the usage pattern error-prone. Can we do better ? In particular, if we could limit the usage of this function to be called on a non-multiplexed pad, we could drop the stream argument. Deducing the direction argument from the type of pad would also make the API simpler. > + * @pad: The pad from which to start the search > + * @stream: The stream for which we want to find the format > + * @dir: The direction of the search > + * @fmt: Pointer to &struct v4l2_subdev_format where the found format is stored > + * > + * This function attempts to find v4l2_subdev_format for a specific stream on a > + * multiplexed pad by following the stream using routes and links to the specified > + * direction, until a non-multiplexed pad is found. > + */ > +int v4l2_subdev_get_format_dir(struct media_pad *pad, u16 stream, > + enum v4l2_direction dir, > + struct v4l2_subdev_format *fmt); > + > #endif -- Regards, Laurent Pinchart