From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: pavel@ucw.cz, krzysztof.kozlowski@canonical.com,
mchehab@kernel.org, paul.kocialkowski@bootlin.com,
robh@kernel.org, shawnx.tu@intel.com, devicetree@vger.kernel.org,
kernel@puri.sm, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor
Date: Tue, 1 Jun 2021 02:13:43 +0300 [thread overview]
Message-ID: <YLVtp/CWouSuEdty@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210531120737.168496-3-martin.kepplinger@puri.sm>
Hi Martin,
Thank you for the patch.
On Mon, May 31, 2021 at 02:07:34PM +0200, Martin Kepplinger wrote:
> Document the bindings used for the SK Hynix Hi-846 CMOS camera driver.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
> .../bindings/media/i2c/hynix,hi846.yaml | 99 +++++++++++++++++++
> 1 file changed, 99 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> new file mode 100644
> index 000000000000..26462f6b5e69
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> @@ -0,0 +1,99 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/hynix,hi846.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SK Hynix Hi-846 1/4" 8M Pixel MIPI CSI-2 sensor
> +
> +maintainers:
> + - Martin Kepplinger <martin.kepplinger@puri.sm>
> +
> +description: |-
> + The Hi-846 is a raw image sensor with an MIPI CSI-2 image data
> + interface and CCI (I2C compatible) control bus. The output format
> + is 10bit Bayer.
> +
> +properties:
> + compatible:
> + const: hynix,hi846
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: Reference to the mclk clock.
> +
> + clock-names:
> + items:
> + - const: mclk
> +
> + reset-gpios:
> + description: Reference to the GPIO connected to the reset pin. Active low.
> + maxItems: 1
> +
> + vdd-supply:
> + description: Definition of the regulator used as 1.8V digital power supply.
> +
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> + additionalProperties: false
You can drop the additionalProperties, the graph schema has
unevaluatedProperties set to false already.
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + data-lanes:
> + oneOf:
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> + - items:
> + - const: 1
> + - const: 2
> +
> + required:
> + - data-lanes
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - reset-gpios
I'd keep the reset-gpios property optional, in case the signal is
hardwired.
I don't have access to the sensor datasheet, so I can't provide comments
on what may be missing. With the above two issues addressed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + - vdd-supply
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hi846: camera@20 {
> + compatible = "hynix,hi846";
> + reg = <0x20>;
> + clocks = <&clk>;
> + clock-names = "mclk";
> + vdd-supply = <®_camera_pwr_en>; /* 1.8v */
> + reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> +
> + port {
> + camera_out: endpoint {
> + remote-endpoint = <&csi1_ep1>;
> + data-lanes = <1 2>;
> + };
> + };
> + };
> + };
> +
> +...
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-05-31 23:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 12:07 [PATCH v3 0/5] Add support for the Hynix Hi-846 camera Martin Kepplinger
2021-05-31 12:07 ` [PATCH v3 1/5] dt-bindings: vendor-prefixes: Add SK Hynix Inc Martin Kepplinger
2021-06-02 19:23 ` Rob Herring
2021-05-31 12:07 ` [PATCH v3 2/5] dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor Martin Kepplinger
2021-05-31 23:13 ` Laurent Pinchart [this message]
2021-05-31 23:24 ` Laurent Pinchart
2021-05-31 12:07 ` [PATCH v3 3/5] media: i2c: add driver for the SK Hynix Hi-846 8M pixel camera Martin Kepplinger
2021-06-01 0:14 ` Laurent Pinchart
2021-06-02 12:00 ` Martin Kepplinger
2021-06-02 17:57 ` Laurent Pinchart
2021-05-31 12:07 ` [PATCH v3 4/5] arm64: defconfig: enable VIDEO_HI846 Martin Kepplinger
2021-05-31 12:07 ` [PATCH v3 5/5] Documentation: i2c-cardlist: add the Hynix hi846 sensor Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLVtp/CWouSuEdty@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@puri.sm \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=mchehab@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shawnx.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).