From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: shawnguo@kernel.org, devicetree@vger.kernel.org,
festevam@gmail.com, kernel@pengutronix.de, kernel@puri.sm,
krzk@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-imx@nxp.com, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
m.felsch@pengutronix.de, mchehab@kernel.org,
phone-devel@vger.kernel.org, robh@kernel.org,
slongerbeam@gmail.com
Subject: Re: [PATCH v9 0/3] media: imx: add support for imx8mq MIPI RX
Date: Tue, 27 Jul 2021 04:00:42 +0300 [thread overview]
Message-ID: <YP9aujiWH2Q/ghHK@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210726082117.2423597-1-martin.kepplinger@puri.sm>
Hi Martin,
On Mon, Jul 26, 2021 at 10:21:14AM +0200, Martin Kepplinger wrote:
> hi,
>
> This patch series adds a driver for the i.MX8MQ CSI MIPI receiver / controller.
>
> It includes the driver, the dt-bindings and the DT addition to the SoC dtsi.
> I test it using libcamera. Thanks to Laurent who helped a lot. I'm happy for
> any feedback,
No more feedback from me :-) I'll take patches 1/3 and 2/3 in my tree
and send a pull request.
Shawn, could you please review 3/3 ?
> revision history
> ----------------
> v9: (thank you Laurent)
> * improve getting the esc clock rate for hs_settle
>
> v8: (thank you Laurent)
> * calculate hs_settle for any clk rate and mode
> * add reviewed-by tag
> https://lore.kernel.org/linux-media/20210723101217.1954805-1-martin.kepplinger@puri.sm/T/
>
> v7: (thank you Laurent and Rob)
> * fix the binding example (include the reset driver)
> * use pm_runtime_resume_and_get()
> * fix some logic in init_cfg()
> * add some useful code comments and fix minor bits found by Laurent in v6
> https://lore.kernel.org/linux-media/20210716102244.581182-1-martin.kepplinger@puri.sm/T/#t
>
> v6: (thank you Laurent and Rob)
> * add reviewed-by tag to binding
> * statically allocate clk_bulk_data
> * fix how the hs_settle value is applied
> * remove s_power calls
> * remove the link_setup() callback implementation and make the link immutable
> * more cleanups according to Laurents' review from v5
> https://lore.kernel.org/linux-media/20210714111931.324485-1-martin.kepplinger@puri.sm/
>
> v5: (thank you Laurent)
> * fix reset usage by using the already supported reset controller driver
> * remove clko2 (totally unrelated clock / had been included by accident)
> * rename pxl clock to ui
> https://lore.kernel.org/linux-media/20210618095753.114557-1-martin.kepplinger@puri.sm/
>
> v4: (thank you Rob and Marco)
> * create fsl,mipi-phy-gpr custom dt property instead of confusing "phy"
> * add imx8mq-specific compatibile to imx8mq.dtsi for future use
> https://lore.kernel.org/linux-media/20210614121522.2944593-1-martin.kepplinger@puri.sm/
>
> v3: (thank you, Rob and Laurent)
> among minor other things according to v2 review, changes include:
> * better describe the clocks
> * rename DT property "phy-reset" to "reset" and "phy-gpr" to "phy"
> https://lore.kernel.org/linux-media/20210608104128.1616028-1-martin.kepplinger@puri.sm/T/#t
>
> v2: (thank you, Dan and Guido)
> among fixes according to v1 reviews, changes include:
> * remove status property from dt-bindings example
> * define a few bits in order to have less magic values
> * use "imx8mq_mipi_csi_" as local function prefix
> * read DT properties only during probe()
> * remove dead code (log_status)
> * add imx8mq_mipi_csi_release_icc()
> * fix imx8mq_mipi_csi_init_icc()
> https://lore.kernel.org/linux-media/20210531112326.90094-1-martin.kepplinger@puri.sm/
>
> v1:
> https://lore.kernel.org/linux-media/20210527075407.3180744-1-martin.kepplinger@puri.sm/T/#t
>
>
> Martin Kepplinger (3):
> dt-bindings: media: document the nxp,imx8mq-mipi-csi2 receiver phy and
> controller
> media: imx: add a driver for i.MX8MQ mipi csi rx phy and controller
> arm64: dts: imx8mq: add mipi csi phy and csi bridge descriptions
>
> .../bindings/media/nxp,imx8mq-mipi-csi2.yaml | 174 ++++
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 104 ++
> drivers/staging/media/imx/Makefile | 1 +
> drivers/staging/media/imx/imx8mq-mipi-csi2.c | 976 ++++++++++++++++++
> 4 files changed, 1255 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml
> create mode 100644 drivers/staging/media/imx/imx8mq-mipi-csi2.c
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-07-27 1:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 8:21 [PATCH v9 0/3] media: imx: add support for imx8mq MIPI RX Martin Kepplinger
2021-07-26 8:21 ` [PATCH v9 1/3] dt-bindings: media: document the nxp,imx8mq-mipi-csi2 receiver phy and controller Martin Kepplinger
2021-07-26 8:21 ` [PATCH v9 2/3] media: imx: add a driver for i.MX8MQ mipi csi rx " Martin Kepplinger
2021-07-28 5:02 ` Dafna Hirschfeld
2021-07-28 5:51 ` Laurent Pinchart
2021-07-26 8:21 ` [PATCH v9 3/3] arm64: dts: imx8mq: add mipi csi phy and csi bridge descriptions Martin Kepplinger
2021-08-04 9:08 ` Shawn Guo
2021-07-27 1:00 ` Laurent Pinchart [this message]
2021-08-04 9:09 ` [PATCH v9 0/3] media: imx: add support for imx8mq MIPI RX Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP9aujiWH2Q/ghHK@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=m.felsch@pengutronix.de \
--cc=martin.kepplinger@puri.sm \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).