From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Nadezda Lutovinova <lutovinova@ispras.ru>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH v2] media: rcar-csi2: Add checking to rcsi2_start_receiver()
Date: Thu, 12 Aug 2021 11:30:46 +0200 [thread overview]
Message-ID: <YRTqRhTTlgkEZAcg@oden.dyn.berto.se> (raw)
In-Reply-To: <20210811171816.12012-1-lutovinova@ispras.ru>
Hi Nadezda,
Thanks for your patch.
On 2021-08-11 20:18:16 +0300, Nadezda Lutovinova wrote:
> If rcsi2_code_to_fmt() return NULL, then null pointer dereference occurs
> in the next cycle. That should not be possible now but adding checking
> protects from future bugs.
> The patch adds checking if format is NULL.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> v2: fix subject and commit message, remove dev_err()
> ---
> drivers/media/platform/rcar-vin/rcar-csi2.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
> index e28eff039688..d28f83f7698b 100644
> --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> @@ -553,6 +553,8 @@ static int rcsi2_start_receiver(struct rcar_csi2 *priv)
>
> /* Code is validated in set_fmt. */
> format = rcsi2_code_to_fmt(priv->mf.code);
> + if (!format)
> + return -EINVAL;
>
> /*
> * Enable all supported CSI-2 channels with virtual channel and
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
prev parent reply other threads:[~2021-08-12 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 13:31 [PATCH] media: rcar-csi2: Add checking to rcsi2_start_receiver() Nadezda Lutovinova
2021-08-11 13:45 ` Niklas Söderlund
2021-08-11 17:18 ` [PATCH v2] " Nadezda Lutovinova
2021-08-12 9:16 ` Jacopo Mondi
2021-08-12 9:30 ` Niklas Söderlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRTqRhTTlgkEZAcg@oden.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lutovinova@ispras.ru \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).