From: LABBE Corentin <clabbe@baylibre.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: mchehab@kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
mjpeg-users@lists.sourceforge.net
Subject: Re: [PATCH 4/8] staging: media: zoran: add debugfs
Date: Mon, 6 Sep 2021 15:36:43 +0200 [thread overview]
Message-ID: <YTYZaxjiKzVurMEF@Red> (raw)
In-Reply-To: <YTMJvI1C1OmBgdeI@kroah.com>
Le Sat, Sep 04, 2021 at 07:53:00AM +0200, Greg KH a écrit :
> On Fri, Sep 03, 2021 at 07:15:36PM +0000, Corentin Labbe wrote:
> > Add debugfs for displaying zoran debug and stats information.
> >
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> > drivers/staging/media/zoran/Kconfig | 10 ++++++
> > drivers/staging/media/zoran/zoran.h | 5 +++
> > drivers/staging/media/zoran/zoran_card.c | 39 ++++++++++++++++++++++++
> > 3 files changed, 54 insertions(+)
> >
> > +#ifdef CONFIG_VIDEO_ZORAN_DEBUG
> > + struct dentry *dbgfs_dir;
> > + struct dentry *dbgfs_file;
>
> No need for these, the file is never referenced and the directory can be
> looked up when you want to remove it.
>
> > +#endif
[...]
> > +#ifdef CONFIG_VIDEO_ZORAN_DEBUG
> > + zr->dbgfs_dir = debugfs_create_dir(ZR_DEVNAME(zr), NULL);
> > + zr->dbgfs_file = debugfs_create_file("debug", 0444,
> > + zr->dbgfs_dir, zr,
> > + &zoran_debugfs_fops);
> > +#endif
>
> Wait, when are you removing the files when the device is removed?
>
> That needs to be fixed no matter what before this patch is accepted.
>
Hello
Sorry to have forgotten this.
I will fix this.
Thanks
Regards
next prev parent reply other threads:[~2021-09-06 13:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 19:15 [PATCH 0/8] staging: media: zoran: fusion in one module Corentin Labbe
2021-09-03 19:15 ` [PATCH 1/8] staging: media: zoran: move module parameter checks to zoran_probe Corentin Labbe
2021-09-03 19:15 ` [PATCH 2/8] staging: media: zoran: use module_pci_driver Corentin Labbe
2021-09-03 19:15 ` [PATCH 3/8] staging: media: zoran: rename debug module parameter Corentin Labbe
2021-09-03 19:15 ` [PATCH 4/8] staging: media: zoran: add debugfs Corentin Labbe
2021-09-03 23:28 ` kernel test robot
2021-09-04 5:53 ` Greg KH
2021-09-06 13:36 ` LABBE Corentin [this message]
2021-09-04 6:42 ` kernel test robot
2021-09-06 10:20 ` Hans Verkuil
2021-09-03 19:15 ` [PATCH 5/8] staging: media: zoran: videocode: remove procfs Corentin Labbe
2021-09-03 19:15 ` [PATCH 6/8] staging: media: zoran: fusion all modules Corentin Labbe
2021-09-06 10:41 ` Hans Verkuil
2021-09-06 13:40 ` LABBE Corentin
2021-09-03 19:15 ` [PATCH 7/8] staging: media: zoran: remove vidmem Corentin Labbe
2021-09-03 19:15 ` [PATCH 8/8] staging: media: zoran: move videodev alloc Corentin Labbe
2021-09-06 11:03 ` [PATCH 0/8] staging: media: zoran: fusion in one module Hans Verkuil
2021-09-06 13:49 ` LABBE Corentin
2021-09-06 14:11 ` Hans Verkuil
2021-09-06 14:56 ` LABBE Corentin
2021-09-06 15:06 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTYZaxjiKzVurMEF@Red \
--to=clabbe@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mjpeg-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).