From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9014C433F5 for ; Fri, 8 Oct 2021 05:45:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B86B461100 for ; Fri, 8 Oct 2021 05:45:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229721AbhJHFrY (ORCPT ); Fri, 8 Oct 2021 01:47:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:39990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229511AbhJHFrV (ORCPT ); Fri, 8 Oct 2021 01:47:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E6609610E5; Fri, 8 Oct 2021 05:45:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633671926; bh=hM+LEo6jq0sP4p14rwXKnhJUAnXreXijp/k9Sn8qwVQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lrh9ADDMfDgO+XapsVQdMVRnXrY8BIE5LKdZ6yUKCkAYaoI3jsMK8yGMPKTKmlUWK uIaGV774meo9+ScIbEyyEZlq9Y1h5SR0xThd/YS9MaUAigJOpmn4cSFyS0tuGwaar3 w0azjLgyNDYW4wJUiJmnTiLjYn93wgDLlpmDltP4= Date: Fri, 8 Oct 2021 07:45:22 +0200 From: Greg KH To: Joel Stanley Cc: Zev Weiss , Mauro Carvalho Chehab , Eddie James , "linux-aspeed@lists.ozlabs.org" , "openbmc@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" , Ryan Chen Subject: Re: [PATCH v3] media: aspeed-video: ignore interrupts that aren't enabled Message-ID: References: <20210617220229.7352-1-zev@bewilderbeest.net> <46edf81d60a38747f7d2511f840253a1c6867652.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Oct 08, 2021 at 04:43:24AM +0000, Joel Stanley wrote: > Hi Greg, > > On Tue, 28 Sept 2021 at 18:57, Zev Weiss wrote: > > > > On Mon, Sep 06, 2021 at 04:47:14AM PDT, Joel Stanley wrote: > > >Hi Mauro, > > > > > >On Mon, 6 Sept 2021 at 10:10, Ryan Chen wrote: > > >> > Subject: Re: [PATCH v3] media: aspeed-video: ignore interrupts that aren't > > >> > enabled > > >> > > > >> > On Thu, 2021-06-17 at 17:02 -0500, Zev Weiss wrote: > > >> > > As partially addressed in commit 65d270acb2d6 ("media: aspeed: clear > > >> > > garbage interrupts"), the ASpeed video engine sometimes asserts > > >> > > interrupts that the driver hasn't enabled. In addition to the > > >> > > CAPTURE_COMPLETE and FRAME_COMPLETE interrupts dealt with in that > > >> > > patch, COMP_READY has also been observed. Instead of playing > > >> > > whack-a-mole with each one individually, we can instead just blanket > > >> > > ignore everything we haven't explicitly enabled. > > >> > > > >> > Suspect this will fix an intermittent problem on AST2500 with screensaver. > > >> > Change looks good, thanks! > > >> > > > >> > Reviewed-by: Eddie James > > >> > > > >> Reviewed-by: Ryan Chen > > >> > > > > >> > > Signed-off-by: Zev Weiss > > > > > >I notice this wasn't merged in the pull request you sent for v5.15. > > >Would you be able to ensure it makes it in the next pull request you > > >send? > > > > > >It can have some fixes tags too: > > > > > >Fixes: 65d270acb2d6 ("media: aspeed: clear garbage interrupts") > > >Fixes: d2b4387f3bdf ("media: platform: Add Aspeed Video Engine driver") > > >Acked-by: Joel Stanley > > > > > >Cheers, > > > > > >Joel > > > > > > > Also not in the recent merge of the media/v5.15-2 tag it looks like -- ping? > > We're struggling to get a hold of the media maintainers to merge this > fix. Have you heard from them recently? I have seen them on the mailing list, yes. good luck! greg k-h