linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Pratyush Yadav <p.yadav@ti.com>
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Nikhil Devshatwar" <nikhil.nd@ti.com>,
	"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Benoit Parrot" <bparrot@ti.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v4 09/11] media: dt-bindings: Make sure items in data-lanes are unique
Date: Thu, 7 Oct 2021 02:47:41 +0300	[thread overview]
Message-ID: <YV41nSK2BBunqdn/@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210915120240.21572-10-p.yadav@ti.com>

Hi Pratyush,

Thank you for the patch.

On Wed, Sep 15, 2021 at 05:32:38PM +0530, Pratyush Yadav wrote:
> The data-lanes property maps the logical lane numbers to the physical
> lane numbers. The position of an entry is the logical lane number and
> its value is the physical lane number. Since one physical lane can only
> map to one logical lane, no number in the list should repeat. Add the
> uniqueItems constraint on the property to enforce this.
> 
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
> Changes in v4:
> - New in v4.
> 
>  Documentation/devicetree/bindings/media/video-interfaces.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.yaml b/Documentation/devicetree/bindings/media/video-interfaces.yaml
> index 4391dce2caee..4bce93efae5f 100644
> --- a/Documentation/devicetree/bindings/media/video-interfaces.yaml
> +++ b/Documentation/devicetree/bindings/media/video-interfaces.yaml
> @@ -158,6 +158,7 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/uint32-array
>      minItems: 1
>      maxItems: 8
> +    uniqueItems: true
>      items:
>        # Assume up to 9 physical lane indices
>        maximum: 8

-- 
Regards,

Laurent Pinchart

  parent reply	other threads:[~2021-10-06 23:47 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 12:02 [PATCH v4 00/11] CSI2RX support on J721E Pratyush Yadav
2021-09-15 12:02 ` [PATCH v4 01/11] media: cadence: csi2rx: Unregister v4l2 async notifier Pratyush Yadav
2021-10-06 23:31   ` Laurent Pinchart
2021-10-07 12:19     ` Pratyush Yadav
2021-09-15 12:02 ` [PATCH v4 02/11] media: cadence: csi2rx: Add external DPHY support Pratyush Yadav
2021-10-06 20:19   ` Sakari Ailus
2021-10-06 21:01     ` Pratyush Yadav
2021-10-06 23:40   ` Laurent Pinchart
2021-09-15 12:02 ` [PATCH v4 03/11] media: cadence: csi2rx: Soft reset the streams before starting capture Pratyush Yadav
2021-10-06 23:41   ` Laurent Pinchart
2021-09-15 12:02 ` [PATCH v4 04/11] media: cadence: csi2rx: Set the STOP bit when stopping a stream Pratyush Yadav
2021-10-06 23:42   ` Laurent Pinchart
2021-09-15 12:02 ` [PATCH v4 05/11] media: cadence: csi2rx: Fix stream data configuration Pratyush Yadav
2021-10-06 23:44   ` Laurent Pinchart
2021-09-15 12:02 ` [PATCH v4 06/11] media: cadence: csi2rx: Populate subdev devnode Pratyush Yadav
2021-10-06 23:45   ` Laurent Pinchart
2021-09-15 12:02 ` [PATCH v4 07/11] media: Re-structure TI platform drivers Pratyush Yadav
2021-10-06 23:46   ` Laurent Pinchart
2021-09-15 12:02 ` [PATCH v4 08/11] media: ti: Add CSI2RX support for J721E Pratyush Yadav
2021-10-06 20:28   ` Sakari Ailus
2021-10-06 21:01     ` Pratyush Yadav
2021-10-06 21:08       ` Sakari Ailus
2021-09-15 12:02 ` [PATCH v4 09/11] media: dt-bindings: Make sure items in data-lanes are unique Pratyush Yadav
2021-09-21 21:31   ` Rob Herring
2021-10-06 23:47   ` Laurent Pinchart [this message]
2021-09-15 12:02 ` [PATCH v4 10/11] media: dt-bindings: Add DT bindings for TI J721E CSI2RX driver Pratyush Yadav
2021-09-21 21:32   ` Rob Herring
2021-10-06 23:49   ` Laurent Pinchart
2021-09-15 12:02 ` [PATCH v4 11/11] media: dt-bindings: Convert Cadence CSI2RX binding to YAML Pratyush Yadav
2021-09-21 21:35   ` Rob Herring
2021-10-06 23:54   ` Laurent Pinchart
2021-10-07 12:16     ` Pratyush Yadav
2021-10-06  8:21 ` [PATCH v4 00/11] CSI2RX support on J721E Pratyush Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YV41nSK2BBunqdn/@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=bparrot@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mripard@kernel.org \
    --cc=nikhil.nd@ti.com \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=p.yadav@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).