From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: linuxarm@huawei.com, mauro.chehab@huawei.com,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH 09/10] media: omap3isp: mark isp_isr_dbg as __maybe_unused
Date: Mon, 22 Nov 2021 11:58:47 +0200 [thread overview]
Message-ID: <YZtp115b6T+ErG+8@pendragon.ideasonboard.com> (raw)
In-Reply-To: <4293d53b747388a65ea06382e2041ae6322ecd89.1637573097.git.mchehab+huawei@kernel.org>
Hi Mauro,
Thank you for the patch.
On Mon, Nov 22, 2021 at 09:26:11AM +0000, Mauro Carvalho Chehab wrote:
> This function is only used for debugging purposes. When DEBUG
> is disabled, it becomes unused, causing a clang warning with W=1.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 00/10] at: https://lore.kernel.org/all/cover.1637573097.git.mchehab+huawei@kernel.org/
>
> drivers/media/platform/omap3isp/isp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
> index 6de377ce281d..4c937f3f323e 100644
> --- a/drivers/media/platform/omap3isp/isp.c
> +++ b/drivers/media/platform/omap3isp/isp.c
> @@ -476,7 +476,8 @@ void omap3isp_hist_dma_done(struct isp_device *isp)
> }
> }
>
> -static inline void isp_isr_dbg(struct isp_device *isp, u32 irqstatus)
> +static inline void __maybe_unused isp_isr_dbg(struct isp_device *isp,
> + u32 irqstatus)
> {
> static const char *name[] = {
> "CSIA_IRQ",
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-11-22 9:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 9:26 [PATCH 00/10] Address some clang W=1 warnings Mauro Carvalho Chehab
2021-11-22 9:26 ` [PATCH 01/10] media: cx25821: drop duplicated i2c_slave_did_ack() Mauro Carvalho Chehab
2021-11-22 9:26 ` [PATCH 02/10] media: ivtv: drop an unused macro Mauro Carvalho Chehab
2021-11-22 9:26 ` [PATCH 03/10] media: cx18: " Mauro Carvalho Chehab
2021-11-22 9:26 ` [PATCH 04/10] media: stb6100: mark a currently unused function as such Mauro Carvalho Chehab
2021-11-22 9:26 ` [PATCH 05/10] media: mc: mark a debug function with __maybe_unused Mauro Carvalho Chehab
2021-11-22 9:57 ` Laurent Pinchart
2021-11-22 9:26 ` [PATCH 06/10] media: dvb-core: dvb_frontend: address some clang warnings Mauro Carvalho Chehab
2021-11-22 9:26 ` [PATCH 07/10] media: cx25840: drop some unused inline functions Mauro Carvalho Chehab
2021-11-22 9:26 ` [PATCH 08/10] media: marvell-ccic: drop to_cam() unused function Mauro Carvalho Chehab
2021-11-22 9:26 ` [PATCH 09/10] media: omap3isp: mark isp_isr_dbg as __maybe_unused Mauro Carvalho Chehab
2021-11-22 9:58 ` Laurent Pinchart [this message]
2021-11-29 7:58 ` [PATCH v2 09/10] media: mc: drop an unused debug function Mauro Carvalho Chehab
2021-11-22 9:26 ` [PATCH 10/10] media: omap3isp: avoid warnings at IS_OUT_OF_BOUNDS() Mauro Carvalho Chehab
2021-11-22 10:04 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZtp115b6T+ErG+8@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=llvm@lists.linux.dev \
--cc=mauro.chehab@huawei.com \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).