From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1] media: i2c: ov08d10: Unlock on error in ov08d10_enum_frame_size()
Date: Wed, 2 Feb 2022 16:35:56 +0200 [thread overview]
Message-ID: <YfqWzIyK+dX4+AVf@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220202141121.238930-1-sakari.ailus@linux.intel.com>
On Wed, Feb 02, 2022 at 04:11:21PM +0200, Sakari Ailus wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
>
> This error path needs to drop the mutex to avoid a deadlock.
>
> Fixes: 7be91e02ed57 ("media: i2c: Add ov08d10 camera sensor driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
I want RAII in C :-)
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/ov08d10.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/ov08d10.c
> index 1f42dd714ef6..e5ef6466a3ec 100644
> --- a/drivers/media/i2c/ov08d10.c
> +++ b/drivers/media/i2c/ov08d10.c
> @@ -1264,8 +1264,10 @@ static int ov08d10_enum_frame_size(struct v4l2_subdev *sd,
> return -EINVAL;
>
> mutex_lock(&ov08d10->mutex);
> - if (fse->code != ov08d10_get_format_code(ov08d10))
> + if (fse->code != ov08d10_get_format_code(ov08d10)) {
> + mutex_unlock(&ov08d10->mutex);
> return -EINVAL;
> + }
> mutex_unlock(&ov08d10->mutex);
>
> fse->min_width = ov08d10->priv_lane->sp_modes[fse->index].width;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-02-02 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 14:11 [PATCH 1/1] media: i2c: ov08d10: Unlock on error in ov08d10_enum_frame_size() Sakari Ailus
2022-02-02 14:35 ` Laurent Pinchart [this message]
2022-02-02 15:36 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfqWzIyK+dX4+AVf@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).