From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E2EBC433EF for ; Wed, 2 Feb 2022 21:49:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235569AbiBBVtS (ORCPT ); Wed, 2 Feb 2022 16:49:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbiBBVtR (ORCPT ); Wed, 2 Feb 2022 16:49:17 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 599D3C061714 for ; Wed, 2 Feb 2022 13:49:17 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 87243D88; Wed, 2 Feb 2022 22:49:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1643838555; bh=Tir5GDClBCcI2RsnPBtze3+Pm/KDE9b44Hfcb33QIWA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HCUV7j6EGQCgPuCAt84sT0xENa27pffAn0huwGwT/MseJNqFtF0JvyGs/3KEV/xpl eczowPet95mEeeWP5PtZTF0JMwEKFU6j6S22zAsDaMsxTzjFodpWgsTTkIaekBrh4C Qz23EhhLT/wgSaeHuwRKDpPMH9FYJsc6Mq5vgpgg= Date: Wed, 2 Feb 2022 23:48:52 +0200 From: Laurent Pinchart To: Jacopo Mondi Cc: slongerbeam@gmail.com, sakari.ailus@iki.fi, hverkuil-cisco@xs4all.nl, mirela.rabulea@nxp.com, xavier.roumegue@oss.nxp.com, tomi.valkeinen@ideasonboard.com, hugues.fruchet@st.com, prabhakar.mahadev-lad.rj@bp.renesas.com, aford173@gmail.com, festevam@gmail.com, eugen.hristev@microchip.com, jbrunet@baylibre.com, mchehab@kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH 12/21] media: ov5640: Fix durations to comply with FPS Message-ID: References: <20220131143245.128089-1-jacopo@jmondi.org> <20220131144444.129036-1-jacopo@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220131144444.129036-1-jacopo@jmondi.org> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Jacopo, Thank you for the patch. On Mon, Jan 31, 2022 at 03:44:40PM +0100, Jacopo Mondi wrote: > Now that the frame duration can be controlled by tuning the VBLANK > duration, fix all modes to comply with the reported FPS. > > All modes run at 30 FPS except for full-resolution mode 2592x1944 > which runs at 15FPS. > > Tested on a 2 data lanes setup in UYVY and RGB565 modes. > > Signed-off-by: Jacopo Mondi > --- > drivers/media/i2c/ov5640.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c > index 6eeb50724195..2176fa0b8eae 100644 > --- a/drivers/media/i2c/ov5640.c > +++ b/drivers/media/i2c/ov5640.c > @@ -611,8 +611,8 @@ ov5640_mode_data[OV5640_NUM_MODES] = { > .width = 160, > .height = 120, > }, > - .ppl = 1896, > - .vblank_def = 864, > + .ppl = 1600, > + .vblank_def = 878, The total number of pixels is changed from 1896 * (120+864) = 1865664 to 1600 * (120+878) = 1596800. The latter produces 30.06fps with a 48 Mp/s rate, which certainly seems better than the 25.73fps produced by the format. I wonder, though, if this has always been wrong, or if the incorrect frame rate got introduced earlier in this series. Also, how did you pick a htot value of 1600 ? > .reg_data = ov5640_setting_QQVGA_160_120, > .reg_data_size = ARRAY_SIZE(ov5640_setting_QQVGA_160_120), > .max_fps = OV5640_30_FPS > @@ -633,8 +633,8 @@ ov5640_mode_data[OV5640_NUM_MODES] = { > .width = 176, > .height = 144, > }, > - .ppl = 1896, > - .vblank_def = 840, > + .ppl = 1600, > + .vblank_def = 854, > .reg_data = ov5640_setting_QCIF_176_144, > .reg_data_size = ARRAY_SIZE(ov5640_setting_QCIF_176_144), > .max_fps = OV5640_30_FPS > @@ -655,8 +655,8 @@ ov5640_mode_data[OV5640_NUM_MODES] = { > .width = 320, > .height = 240, > }, > - .ppl = 1896, > - .vblank_def = 744, > + .ppl = 1600, > + .vblank_def = 760, > .reg_data = ov5640_setting_QVGA_320_240, > .reg_data_size = ARRAY_SIZE(ov5640_setting_QVGA_320_240), > .max_fps = OV5640_30_FPS > @@ -677,8 +677,8 @@ ov5640_mode_data[OV5640_NUM_MODES] = { > .width = 640, > .height = 480, > }, > - .ppl = 1896, > - .vblank_def = 600, > + .ppl = 1600, > + .vblank_def = 520, > .reg_data = ov5640_setting_VGA_640_480, > .reg_data_size = ARRAY_SIZE(ov5640_setting_VGA_640_480), > .max_fps = OV5640_60_FPS > @@ -700,7 +700,7 @@ ov5640_mode_data[OV5640_NUM_MODES] = { > .height = 480, > }, > .ppl = 1896, > - .vblank_def = 504, > + .vblank_def = 1206, > .reg_data = ov5640_setting_NTSC_720_480, > .reg_data_size = ARRAY_SIZE(ov5640_setting_NTSC_720_480), > .max_fps = OV5640_30_FPS > @@ -722,7 +722,7 @@ ov5640_mode_data[OV5640_NUM_MODES] = { > .height = 576, > }, > .ppl = 1896, > - .vblank_def = 408, > + .vblank_def = 1110, > .reg_data = ov5640_setting_PAL_720_576, > .reg_data_size = ARRAY_SIZE(ov5640_setting_PAL_720_576), > .max_fps = OV5640_30_FPS > @@ -744,7 +744,7 @@ ov5640_mode_data[OV5640_NUM_MODES] = { > .height = 768, > }, > .ppl = 1896, > - .vblank_def = 312, > + .vblank_def = 918, > .reg_data = ov5640_setting_XGA_1024_768, > .reg_data_size = ARRAY_SIZE(ov5640_setting_XGA_1024_768), > .max_fps = OV5640_30_FPS > @@ -765,8 +765,8 @@ ov5640_mode_data[OV5640_NUM_MODES] = { > .width = 1280, > .height = 720, > }, > - .ppl = 1896, > - .vblank_def = 20, > + .ppl = 1600, > + .vblank_def = 560, > .reg_data = ov5640_setting_720P_1280_720, > .reg_data_size = ARRAY_SIZE(ov5640_setting_720P_1280_720), > .max_fps = OV5640_30_FPS > @@ -787,8 +787,8 @@ ov5640_mode_data[OV5640_NUM_MODES] = { > .width = 1920, > .height = 1080, > }, > - .ppl = 2500, > - .vblank_def = 40, > + .ppl = 2234, > + .vblank_def = 24, > .reg_data = ov5640_setting_1080P_1920_1080, > .reg_data_size = ARRAY_SIZE(ov5640_setting_1080P_1920_1080), > .max_fps = OV5640_30_FPS -- Regards, Laurent Pinchart