linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Eugen.Hristev@microchip.com
Cc: laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1] microchip-csi2dc: Remove VC support for now
Date: Tue, 15 Feb 2022 21:21:44 +0200	[thread overview]
Message-ID: <Ygv9SP2OpIHDtXfA@paasikivi.fi.intel.com> (raw)
In-Reply-To: <5168daa7-2f8b-fdbe-7a15-12de3428322a@microchip.com>

Hi Eugen,

On Tue, Feb 08, 2022 at 11:36:16AM +0000, Eugen.Hristev@microchip.com wrote:
> I am sorry, I was referring to the get_mbus_config which was recently 
> added, which in my case uses V4L2_MBUS_CSI2_CHANNEL_* .
> Without the get_mbus_config, I wasn't supposed to use the 
> V4L2_MBUS_CSI2_CHANNEL_* at all .
> Hence my confusion in adding them into the same bucket.
> 
> My driver uses these flags because my initial implementation to get the 
> VC from the devicetree was rejected and this was suggested instead.

As noted by Laurent, this feature is not supported in mainline currently.
Beyond that, no transmitter driver uses virtual channel different from
zero, so the case for setting non-zero virtual channel in absence of
multiple streams does not exist.

Also the interfaces required to make use of multiple streams do not exist
in mainline at the moment. They will be added by the streams patchset
eventually, and adding support for them requires extra driver work.

Thus, we're not losing any functionality by dropping the defines and
potentially associated driver code. Therefore I see no reason to postpone
these patches.

-- 
Kind regards,

Sakari Ailus

  parent reply	other threads:[~2022-02-15 19:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-02 15:36 [PATCH 1/1] microchip-csi2dc: Remove VC support for now Sakari Ailus
2022-02-08  5:11 ` Mauro Carvalho Chehab
2022-02-08  8:00   ` Eugen.Hristev
2022-02-08  8:05     ` Eugen.Hristev
2022-02-08 11:06     ` Laurent Pinchart
2022-02-08 11:16       ` Sakari Ailus
2022-02-08 11:37         ` Eugen.Hristev
2022-02-08 11:36       ` Eugen.Hristev
2022-02-08 12:19         ` Laurent Pinchart
2022-02-15 19:21         ` Sakari Ailus [this message]
2022-02-15 20:10           ` Eugen.Hristev
2022-02-17 11:10             ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ygv9SP2OpIHDtXfA@paasikivi.fi.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=Eugen.Hristev@microchip.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).