From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7239C43334 for ; Thu, 7 Jul 2022 11:35:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235439AbiGGLfW (ORCPT ); Thu, 7 Jul 2022 07:35:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234443AbiGGLfT (ORCPT ); Thu, 7 Jul 2022 07:35:19 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38F0231DEF for ; Thu, 7 Jul 2022 04:35:18 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7DFF9D00; Thu, 7 Jul 2022 13:35:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1657193716; bh=NHlgyEobzjtn7h5ZJSBJqIyc8XzvkKEUztvt+Lf8KAM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CMzs4yzPcVQJRw/UNps9l2aoaLm+Q6zjeym3a3jrjbKed1a2gc+Bumj78+MG3F9ze ZX/+5ld9nJ5XyxzytM1PT93RU2I8SfTSKkghNQ2VBAS2UvQaMmCnYjb7OFqXjlkmdW f1qKk1CXVD/ukqotibZH6dpMCRyCl2mtjU/La3eA= Date: Thu, 7 Jul 2022 14:34:50 +0300 From: Laurent Pinchart To: Alexander Stein Cc: linux-media@vger.kernel.org, Rui Miguel Silva , Steve Longerbeam , Philipp Zabel , Jacopo Mondi , Martin Kepplinger , Dorota Czaplejewicz , kernel@pengutronix.de Subject: Re: Re: [PATCH 00/50] staging: media: imx: Prepare destaging of imx7-media-csi Message-ID: References: <20220510115859.19777-1-laurent.pinchart@ideasonboard.com> <8064452.T7Z3S40VBb@steina-w> <4780760.ElGaqSPkdT@steina-w> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4780760.ElGaqSPkdT@steina-w> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Alexander, On Thu, Jul 07, 2022 at 12:45:01PM +0200, Alexander Stein wrote: > Am Donnerstag, 7. Juli 2022, 02:23:55 CEST schrieb Laurent Pinchart: > > On Wed, May 11, 2022 at 03:36:14PM +0200, Alexander Stein wrote: > > > Hello Laurent, > > > > > > thanks for pushing out this huge set. > > > > > > Am Dienstag, 10. Mai 2022, 13:58:09 CEST schrieb Laurent Pinchart: > > > > Hello, > > > > > > > > This patch series prepares the imx7-media-csi for destaging by > > > > decoupling it from the helpers shared with the i.MX6 IPUv3. > > > > > > > > The strategy Paul and I have followed is to import copies of helper code > > > > and, refactor it within the imx7-media-csi driver, and repeat until no > > > > more shared helpers are used. There is still room for refactoring and > > > > simplification of the imx7-media-csi driver, but I believe it is now in > > > > a state clean enough to be moved out of staging. > > > > > > > > The series also includes a few fixes or improvements in supported > > > > formats that are now made possible thanks to this refactoring. See > > > > patches 45/50 and 46/50 for details. > > > > > > > > The code size has grown as a result. This is partly offset by code in > > > > the shared helpers that can be removed or simplified, but I haven't > > > > starting working on that. The helpers are now used for the i.MX6 IPUv3 > > > > only, so I will leave this exercise to anyone who would be interested in > > > > destaging that driver as well. > > > > > > > > Some of the items in the TODO file related to the imx7-media-csi driver > > > > have been addressed. The two remaining items are frame interval monitor > > > > support and restricting the list of supported formats to the SoC > > > > version. The former isn't a destaging blocker in my opinion, as the > > > > feature can be added later if desired (and frame interval monitoring > > > > should then be moved to the V4L2 core). I believe the latter could also > > > > be addressed after destaging the driver, but in any case, this is a > > > > discussion for a future destaging series (which may come as soon as this > > > > one is accepted). > > > > > > > > Alexander, this also could greatly simplify your "[PATCH v3 0/8] > > > > imx7/imx8mm media / csi patches" series. > > > > > > Thanks for putting me on CC. I'll try to get my system running your > > > patches > > > ASAP. > > > > As only minor changes were needed, I ended up posting v1.1 of the > > corresponding patches instead of spamming everybody with a full v2. For > > your convenience, I've pushed the result to > > > > git://linuxtv.org/pinchartl/media.git imx7/destage > > > > I know it's a bit of a short notice, but I'd like to send a pull request > > in time for v5.20, when do you think you would be able to test the > > series ? > > I happen to have my setup already available, so I could test your updated > series pretty fast. > Accessing imx327 still works for WIP config. So > Tested-by: Alexander Stein Thanks a lot for the quick testing. I've now sent the pull request. Do you plan to submit a new version of your patches on top of this ? -- Regards, Laurent Pinchart