From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B3BE3FBB9 for ; Tue, 19 Mar 2024 13:21:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710854477; cv=none; b=ZrlJPcIY2Zrxf+ZDvD/WLDmwr5UU8LbibodXv2BNk3c409IXmBBH3zP2D9iyOpIIV3nZV9sXfN63N5PxDOmcVICzJFMmkgeYtqgswLFRSoeJs2Hv5dwsl2aWMQrPUV6AB89mnswJ6JStmR6ItYYzcJwhFLdAoxDuuhRotOuAu/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710854477; c=relaxed/simple; bh=9flzhiWJqfczqGg2YEpjfj56v02V7WTnWc/QuI/JhAY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Le0a9x4NWG2fwFJCvwzrE4Ic1bYmIgdpy0jsKpNoH5atWh7MrMFw33CPs1sH4xJmd+VsPDW8BN/bSecUZhV7u4OAlWjHpkmRmcCTGEiDSCZfqRBhl0KTRaD0lWIPEWvJJhmX+oIH82gWr4K3+dlWeOd4iF+pZbJ9lpLWEB11BVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=haOB4ka0; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="haOB4ka0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710854476; x=1742390476; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=9flzhiWJqfczqGg2YEpjfj56v02V7WTnWc/QuI/JhAY=; b=haOB4ka0l16/Rt06jGjnpMorHlgVmqVRWPlH+1tsRHsg3u4CsjzByCX9 0AxQeqI9U7jLmUzj76rcV8SgUmksquFdk9xP9TIcZSInkjrKRLcXIJu0z z/Rds9GorZT9ZhbWrPCsOKU9Irw1+4PTBVioO+igqIlwsKwzZWQkdN7F+ 7njqBoq797Nh8iZneaARrqyqhXGlOHzd+Beo9BV/GKPoWKMtr0lxrE9Cy mHnCz8FkclR4gmuH/F09lzjviCnDYUWKpEdodz0iQgAVFBWgf/2eJplgd mgmeTofW4hy2t3sh8Suvaz1+GrYCD/WvHEvg6oTsVN36MH/Bb2L3OgqKs g==; X-IronPort-AV: E=McAfee;i="6600,9927,11017"; a="17125196" X-IronPort-AV: E=Sophos;i="6.07,137,1708416000"; d="scan'208";a="17125196" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2024 06:21:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,137,1708416000"; d="scan'208";a="14467723" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2024 06:21:12 -0700 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with SMTP id C596E11F853; Tue, 19 Mar 2024 15:21:09 +0200 (EET) Date: Tue, 19 Mar 2024 13:21:09 +0000 From: Sakari Ailus To: Tomi Valkeinen Cc: linux-media@vger.kernel.org, Laurent Pinchart , bingbu.cao@intel.com, hongju.wang@intel.com, hverkuil@xs4all.nl, Andrey Konovalov , Jacopo Mondi , Dmitry Perchanov , "Ng, Khai Wen" , Alain Volmat Subject: Re: [PATCH v8 01/38] media: mc: Add INTERNAL pad flag Message-ID: References: <20240313072516.241106-1-sakari.ailus@linux.intel.com> <20240313072516.241106-2-sakari.ailus@linux.intel.com> <86a51397-d0a9-4875-a3e8-fb4526b340f4@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86a51397-d0a9-4875-a3e8-fb4526b340f4@ideasonboard.com> On Thu, Mar 14, 2024 at 09:17:08AM +0200, Tomi Valkeinen wrote: > > @@ -381,6 +382,13 @@ Types and flags used to represent the media graph elements > > enabled links even when this flag isn't set; the absence of the flag > > doesn't imply there is none. > > + * - ``MEDIA_PAD_FL_INTERNAL`` > > + - The internal flag indicates an internal pad that has no external > > + connections. Such a pad shall not be connected with a link. > > + > > + The internal flag may currently be present only in a source pad where > > s/source/sink/ > > Reviewed-by: Tomi Valkeinen Thanks, I'll fix that for v9. -- Sakari Ailus