From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 887DCC4338F for ; Tue, 10 Aug 2021 21:46:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65C2360EE9 for ; Tue, 10 Aug 2021 21:46:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234902AbhHJVrG (ORCPT ); Tue, 10 Aug 2021 17:47:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234388AbhHJVrG (ORCPT ); Tue, 10 Aug 2021 17:47:06 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B458EC061765 for ; Tue, 10 Aug 2021 14:46:43 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id r7so53224wrs.0 for ; Tue, 10 Aug 2021 14:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=2aRmmG6vEQVcbmATy1hVegLI10o7JHfhcSSCaErf6bg=; b=EpqLpHjGzaGFxGEiGVqlSyNWRF749Hj2h4aqXIvgj/XCPVLAss1AxlX/wrHWGsdbZc JBdzQPi2G0A81+vOAFPAxrqYVLYZFQNsGS8F7PnWCgBGHOJ44+59hROUsBG8itr7/3vl /7dGUyhwMqjkiDQXMh4pKnRrDnANAiga5oXHVUzMXn8/cjDnOPnYqtHMp0KyTo9vBj7C n5pXqLXZWP1xTTDBvmBkZfokZx0bOl4VRnzYeE3VnioJcxweARk7o+IgZ6BkNH88WkgT dsNi9WFcwv/pXa8AfV9FIND8GLRa1cpu8xr9WKZDv3+o2TtWle81n6XksObNwGxk2fHW qL/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=2aRmmG6vEQVcbmATy1hVegLI10o7JHfhcSSCaErf6bg=; b=kxXDNNnqoFckVp902NsehqliKPFG7gTk1lFgybfeeFHuDDekFBU1LnCiDcM1JvJqOw UQ6S+IJXP5gFMcaq5rJSyu6kyUeXKUumpdB/J0lGaXt1j+EH9DRsM4OgIfR1gSrNvALC Y5e2Q3gjDYvF3TquRRdMnvrlJllU3qy8nDqocU7y05vC+rEaDlhoVUlC7/FBGrwkxs+L rE5VLhcvnSsde0BwYaxIzHOc0U8gsZcAxtikJfD9S4zpnBcmq7J7wYT9Xo04aqPyGMyC QHWhFvbcbTEbyq5DCDHGe9fezAAa/QD4yUFHtUhZi+zpGXqMaiU3JFpZJGiT3FdZDmFF 9mEQ== X-Gm-Message-State: AOAM532+NVIUPuRbgNMgdatlXqZQuB1y2LsV7OO6VCjZYMZWL0iejqpR 09h2zQkA7zHwueRYzow0aOA= X-Google-Smtp-Source: ABdhPJw3tR0ARpzJpvi8ivaTIXUPUF4mWW7u/Qea5nYyS/s74TPDU9jxPNHqJoNH9Lg9Bdr9lh3e8Q== X-Received: by 2002:a5d:6d82:: with SMTP id l2mr33263047wrs.225.1628632002338; Tue, 10 Aug 2021 14:46:42 -0700 (PDT) Received: from [192.168.0.14] (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161]) by smtp.gmail.com with ESMTPSA id l41sm2764753wms.2.2021.08.10.14.46.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Aug 2021 14:46:41 -0700 (PDT) Subject: Re: [PATCH v2 04/12] media: i2c: Support 19.2MHz input clock in ov8865 To: Andy Shevchenko Cc: Sakari Ailus , Paul Kocialkowski , Ezequiel Garcia , Hans Verkuil , Linux Media Mailing List , yong.zhi@intel.com, bingbu.cao@intel.com, tian.shu.qiu@intel.com, kevin.lhopital@bootlin.com, yang.lee@linux.alibaba.com, laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com References: <20210809225845.916430-1-djrscally@gmail.com> <20210809225845.916430-5-djrscally@gmail.com> From: Daniel Scally Message-ID: Date: Tue, 10 Aug 2021 22:46:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Andy On 10/08/2021 14:04, Andy Shevchenko wrote: >> + ret = fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency", >> + &rate); >> + if (!ret) { > I'm wondering if something like > > ... rate = 0; > > fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency", &rate); > if (rate > 0) { > > can be used. Should be fine, and I agree that it makes the point of the check more clear, thanks.