From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Jacopo Mondi <jacopo@jmondi.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
tfiga@google.com, pavel@ucw.cz
Cc: "open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)"
<linux-media@vger.kernel.org>
Subject: Re: [PATCH v3 02/11] media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_LOCATION
Date: Fri, 13 Sep 2019 15:48:18 +0200 [thread overview]
Message-ID: <a5399069-0ecb-6354-2a40-cd366ae181e2@xs4all.nl> (raw)
In-Reply-To: <20190912201055.13964-3-jacopo@jmondi.org>
On 9/12/19 10:10 PM, Jacopo Mondi wrote:
> Add documentation for the V4L2_CID_CAMERA_SENSOR_LOCATION camera
> control. The newly added read-only control reports the camera device
> mounting position.
>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
> .../media/uapi/v4l/ext-ctrls-camera.rst | 32 +++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst
> index 51c1d5c9eb00..f879dcc9409c 100644
> --- a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst
> +++ b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst
> @@ -510,6 +510,38 @@ enum v4l2_scene_mode -
> value down. A value of zero stops the motion if one is in progress
> and has no effect otherwise.
>
> +``V4L2_CID_CAMERA_SENSOR_LOCATION (integer)``
> + This read-only control describes the camera sensor location by reporting
> + its mounting position on the device where the camera is installed. The
> + control value is constant and not modifiable by software. This control is
> + particularly meaningful for devices which have a well defined orientation,
> + such as phones, laptops and portable devices as the camera location is
as -> since
> + expressed as a position relative to the device intended usage orientation.
device -> device's
> + For example, a camera sensor installed on the user-facing side of a phone,
> + a tablet or a laptop device is said to be installed in the
> + ``V4L2_LOCATION_FRONT`` location while camera sensors installed on the side
> + opposite the front one are said to be installed in the
> + ``V4L2_LOCATION_BACK`` location. Camera sensors not directly attached to
> + the device or attached in a way that allows it to move freely, such as
it -> them (plural)
> + webcams and digital cameras, are said to be have ``V4L2_LOCATION_EXTERNAL``
to be have -> to have the
> + location.
> +
> +
> +
> +.. flat-table::
> + :header-rows: 0
> + :stub-columns: 0
> +
> + * - ``V4L2_LOCATION_FRONT``
> + - The camera sensor is located on the front side of the device.
> + * - ``V4L2_LOCATION_BACK``
> + - The camera sensor is located on the back side of the device.
> + * - ``V4L2_LOCATION_EXTERNAL``
> + - The camera sensor is not directly attached to the device and is
> + freely movable.
> +
> +
> +
> .. [#f1]
> This control may be changed to a menu control in the future, if more
> options are required.
>
Regards,
Hans
next prev parent reply other threads:[~2019-09-13 13:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 20:10 [PATCH v3 00/11] media: Report camera sensor properties Jacopo Mondi
2019-09-12 20:10 ` [PATCH v3 01/11] dt-bindings: video-interfaces: Document 'location' property Jacopo Mondi
2019-09-13 13:45 ` Hans Verkuil
2019-09-27 15:27 ` Pavel Machek
2019-09-28 12:48 ` Jacopo Mondi
2019-09-12 20:10 ` [PATCH v3 02/11] media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_LOCATION Jacopo Mondi
2019-09-13 13:48 ` Hans Verkuil [this message]
2019-09-12 20:10 ` [PATCH v3 03/11] dt-bindings: video-interfaces: Expand rotation description Jacopo Mondi
2019-09-13 13:50 ` Hans Verkuil
2019-09-12 20:10 ` [PATCH v3 04/11] media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_ROTATION Jacopo Mondi
2019-09-13 14:02 ` Hans Verkuil
2019-09-13 18:49 ` Jacopo Mondi
2019-09-24 15:53 ` Jacopo Mondi
2019-09-27 11:20 ` Hans Verkuil
2019-09-12 20:10 ` [PATCH v3 05/11] media: v4l2-ctrls: Add camera location and rotation Jacopo Mondi
2019-09-12 20:10 ` [PATCH v3 06/11] media: v4l2-fwnode: Add helper to parse device properties Jacopo Mondi
2019-09-13 14:08 ` Hans Verkuil
2019-09-13 19:04 ` Jacopo Mondi
2019-09-27 10:57 ` Hans Verkuil
2019-09-12 20:10 ` [PATCH v3 07/11] include: v4l2-ctrl: Sort forward declarations Jacopo Mondi
2019-09-12 20:10 ` [PATCH v3 08/11] media: v4l2-ctrls: Sort includes alphabetically Jacopo Mondi
2019-09-12 20:10 ` [PATCH v3 09/11] media: v4l2-ctrls: Add helper to register properties Jacopo Mondi
2019-09-13 14:25 ` Hans Verkuil
2019-09-12 20:10 ` [PATCH v3 10/11] media: i2c: ov5670: Parse and " Jacopo Mondi
2019-09-12 20:10 ` [PATCH v3 11/11] media: i2c: ov13858: " Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5399069-0ecb-6354-2a40-cd366ae181e2@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pavel@ucw.cz \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).