From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE9CCC47082 for ; Mon, 7 Jun 2021 07:44:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F25E6120F for ; Mon, 7 Jun 2021 07:44:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230207AbhFGHqL (ORCPT ); Mon, 7 Jun 2021 03:46:11 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:50112 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbhFGHqK (ORCPT ); Mon, 7 Jun 2021 03:46:10 -0400 Received: from [192.168.1.111] (91-157-208-71.elisa-laajakaista.fi [91.157.208.71]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 393D48DB; Mon, 7 Jun 2021 09:44:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1623051858; bh=Higm1pJfwT6D0msL5RrCqW0ByHF5DUsrPDSKe8GywYw=; h=To:Cc:References:From:Subject:Date:In-Reply-To:From; b=E3mDCJ9EQZ3kZxbW+JlXtMgdJ7o/TXZ2xJg2W+Fboec0ryhe+DIkIPzbWzDv1UDKs Metv48bmwaG+sxw1c/Hr5vyT7HZuQVs3vdLUbeTnhGTayZ0S3oK3WNVxES+ifxzCj3 BZAKrIOjCNBUsxtDyPfPcTqwbc8TBnwMu1NyKiio= To: Laurent Pinchart Cc: Pratyush Yadav , Lokesh Vutla , linux-media@vger.kernel.org References: <20210524110909.672432-1-tomi.valkeinen@ideasonboard.com> <20210524110909.672432-22-tomi.valkeinen@ideasonboard.com> From: Tomi Valkeinen Subject: Re: [PATCH v3 21/38] media: ti-vpe: cal: handle cal_ctx_v4l2_register error Message-ID: Date: Mon, 7 Jun 2021 10:44:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 04/06/2021 16:47, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Mon, May 24, 2021 at 02:08:52PM +0300, Tomi Valkeinen wrote: >> cal_async_notifier_complete() doesn't handle errors returned from >> cal_ctx_v4l2_register(). Add the error handling. >> >> Signed-off-by: Tomi Valkeinen >> --- >> drivers/media/platform/ti-vpe/cal.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c >> index ba8821a3b262..9e051c2e84a9 100644 >> --- a/drivers/media/platform/ti-vpe/cal.c >> +++ b/drivers/media/platform/ti-vpe/cal.c >> @@ -743,8 +743,12 @@ static int cal_async_notifier_complete(struct v4l2_async_notifier *notifier) >> int ret = 0; >> >> for (i = 0; i < ARRAY_SIZE(cal->ctx); ++i) { >> - if (cal->ctx[i]) >> - cal_ctx_v4l2_register(cal->ctx[i]); >> + if (!cal->ctx[i]) >> + continue; >> + >> + ret = cal_ctx_v4l2_register(cal->ctx[i]); >> + if (ret) >> + return ret; > > This part looks good, so > > Reviewed-by: Laurent Pinchart > > Don't we need to call cal_ctx_v4l2_unregister() in the error path of > cal_async_notifier_register() though ? Hmm, can you elaborate? I don't understand where and why we need to call the unregister. Tomi