linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] media: exynos4-is: don't rely on the v4l2_async_subdev internals
       [not found] <CGME20220923094232eucas1p1deb3985c9637a0876609c75967175e9b@eucas1p1.samsung.com>
@ 2022-09-23  9:42 ` Marek Szyprowski
  2022-09-23 20:35   ` Daniel Scally
  2022-10-05 14:47   ` Sylwester Nawrocki
  0 siblings, 2 replies; 6+ messages in thread
From: Marek Szyprowski @ 2022-09-23  9:42 UTC (permalink / raw)
  To: linux-media, 'Linux Samsung SOC'
  Cc: Marek Szyprowski, Sylwester Nawrocki, Daniel Scally,
	Sakari Ailus, Laurent Pinchart

Commit 1f391df44607 ("media: v4l2-async: Use endpoints in
__v4l2_async_nf_add_fwnode_remote()") changed the data that is stored in
the v4l2_async_subdev internals from the fwnode pointer to the parent
device to the fwnode pointer to the matched endpoint. This broke the
sensor matching code, which relied on the particular fwnode data in the
v4l2_async_subdev internals. Fix this by simply matching the
v4l2_async_subdev pointer, which is already available there.

Reported-by: Daniel Scally <djrscally@gmail.com>
Fixes: fa91f1056f17 ("[media] exynos4-is: Add support for asynchronous subdevices registration")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 drivers/media/platform/samsung/exynos4-is/media-dev.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c
index 52b43ea04030..412213b0c384 100644
--- a/drivers/media/platform/samsung/exynos4-is/media-dev.c
+++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c
@@ -1380,9 +1380,7 @@ static int subdev_notifier_bound(struct v4l2_async_notifier *notifier,
 
 	/* Find platform data for this sensor subdev */
 	for (i = 0; i < ARRAY_SIZE(fmd->sensor); i++)
-		if (fmd->sensor[i].asd &&
-		    fmd->sensor[i].asd->match.fwnode ==
-		    of_fwnode_handle(subdev->dev->of_node))
+		if (fmd->sensor[i].asd == asd)
 			si = &fmd->sensor[i];
 
 	if (si == NULL)
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] media: exynos4-is: don't rely on the v4l2_async_subdev internals
  2022-09-23  9:42 ` [PATCH] media: exynos4-is: don't rely on the v4l2_async_subdev internals Marek Szyprowski
@ 2022-09-23 20:35   ` Daniel Scally
  2022-10-05 14:47   ` Sylwester Nawrocki
  1 sibling, 0 replies; 6+ messages in thread
From: Daniel Scally @ 2022-09-23 20:35 UTC (permalink / raw)
  To: Marek Szyprowski, linux-media, 'Linux Samsung SOC'
  Cc: Sylwester Nawrocki, Sakari Ailus, Laurent Pinchart

Hi Marek

On 23/09/2022 10:42, Marek Szyprowski wrote:
> Commit 1f391df44607 ("media: v4l2-async: Use endpoints in
> __v4l2_async_nf_add_fwnode_remote()") changed the data that is stored in
> the v4l2_async_subdev internals from the fwnode pointer to the parent
> device to the fwnode pointer to the matched endpoint. This broke the
> sensor matching code, which relied on the particular fwnode data in the
> v4l2_async_subdev internals. Fix this by simply matching the
> v4l2_async_subdev pointer, which is already available there.
>
> Reported-by: Daniel Scally <djrscally@gmail.com>
> Fixes: fa91f1056f17 ("[media] exynos4-is: Add support for asynchronous subdevices registration")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---


Yeah that makes more sense to me:


Reviewed-by: Daniel Scally <djrscally@gmail.com>

>   drivers/media/platform/samsung/exynos4-is/media-dev.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c
> index 52b43ea04030..412213b0c384 100644
> --- a/drivers/media/platform/samsung/exynos4-is/media-dev.c
> +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c
> @@ -1380,9 +1380,7 @@ static int subdev_notifier_bound(struct v4l2_async_notifier *notifier,
>   
>   	/* Find platform data for this sensor subdev */
>   	for (i = 0; i < ARRAY_SIZE(fmd->sensor); i++)
> -		if (fmd->sensor[i].asd &&
> -		    fmd->sensor[i].asd->match.fwnode ==
> -		    of_fwnode_handle(subdev->dev->of_node))
> +		if (fmd->sensor[i].asd == asd)
>   			si = &fmd->sensor[i];
>   
>   	if (si == NULL)

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] media: exynos4-is: don't rely on the v4l2_async_subdev internals
  2022-09-23  9:42 ` [PATCH] media: exynos4-is: don't rely on the v4l2_async_subdev internals Marek Szyprowski
  2022-09-23 20:35   ` Daniel Scally
@ 2022-10-05 14:47   ` Sylwester Nawrocki
  2022-11-08 14:14     ` Marek Szyprowski
  1 sibling, 1 reply; 6+ messages in thread
From: Sylwester Nawrocki @ 2022-10-05 14:47 UTC (permalink / raw)
  To: Marek Szyprowski, linux-media, 'Linux Samsung SOC'
  Cc: Daniel Scally, Sakari Ailus, Laurent Pinchart

On 23.09.2022 11:42, Marek Szyprowski wrote:
> Commit 1f391df44607 ("media: v4l2-async: Use endpoints in
> __v4l2_async_nf_add_fwnode_remote()") changed the data that is stored in
> the v4l2_async_subdev internals from the fwnode pointer to the parent
> device to the fwnode pointer to the matched endpoint. This broke the
> sensor matching code, which relied on the particular fwnode data in the
> v4l2_async_subdev internals. Fix this by simply matching the
> v4l2_async_subdev pointer, which is already available there.
> 
> Reported-by: Daniel Scally <djrscally@gmail.com>
> Fixes: fa91f1056f17 ("[media] exynos4-is: Add support for asynchronous subdevices registration")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] media: exynos4-is: don't rely on the v4l2_async_subdev internals
  2022-10-05 14:47   ` Sylwester Nawrocki
@ 2022-11-08 14:14     ` Marek Szyprowski
  2022-11-09  9:29       ` Sakari Ailus
  0 siblings, 1 reply; 6+ messages in thread
From: Marek Szyprowski @ 2022-11-08 14:14 UTC (permalink / raw)
  To: Sylwester Nawrocki, linux-media, 'Linux Samsung SOC'
  Cc: Daniel Scally, Sakari Ailus, Laurent Pinchart, Hans Verkuil

On 05.10.2022 16:47, Sylwester Nawrocki wrote:
> On 23.09.2022 11:42, Marek Szyprowski wrote:
>> Commit 1f391df44607 ("media: v4l2-async: Use endpoints in
>> __v4l2_async_nf_add_fwnode_remote()") changed the data that is stored in
>> the v4l2_async_subdev internals from the fwnode pointer to the parent
>> device to the fwnode pointer to the matched endpoint. This broke the
>> sensor matching code, which relied on the particular fwnode data in the
>> v4l2_async_subdev internals. Fix this by simply matching the
>> v4l2_async_subdev pointer, which is already available there.
>>
>> Reported-by: Daniel Scally <djrscally@gmail.com>
>> Fixes: fa91f1056f17 ("[media] exynos4-is: Add support for asynchronous subdevices registration")
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

Gentle ping for merging this fix.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] media: exynos4-is: don't rely on the v4l2_async_subdev internals
  2022-11-08 14:14     ` Marek Szyprowski
@ 2022-11-09  9:29       ` Sakari Ailus
  2022-11-09 10:30         ` Marek Szyprowski
  0 siblings, 1 reply; 6+ messages in thread
From: Sakari Ailus @ 2022-11-09  9:29 UTC (permalink / raw)
  To: Marek Szyprowski
  Cc: Sylwester Nawrocki, linux-media, 'Linux Samsung SOC',
	Daniel Scally, Laurent Pinchart, Hans Verkuil

Hi Marek,

On Tue, Nov 08, 2022 at 03:14:14PM +0100, Marek Szyprowski wrote:
> On 05.10.2022 16:47, Sylwester Nawrocki wrote:
> > On 23.09.2022 11:42, Marek Szyprowski wrote:
> >> Commit 1f391df44607 ("media: v4l2-async: Use endpoints in
> >> __v4l2_async_nf_add_fwnode_remote()") changed the data that is stored in
> >> the v4l2_async_subdev internals from the fwnode pointer to the parent
> >> device to the fwnode pointer to the matched endpoint. This broke the
> >> sensor matching code, which relied on the particular fwnode data in the
> >> v4l2_async_subdev internals. Fix this by simply matching the
> >> v4l2_async_subdev pointer, which is already available there.
> >>
> >> Reported-by: Daniel Scally <djrscally@gmail.com>
> >> Fixes: fa91f1056f17 ("[media] exynos4-is: Add support for asynchronous subdevices registration")
> >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> 
> Gentle ping for merging this fix.

It's in my PR to Mauro:

<URL:https://patchwork.linuxtv.org/project/linux-media/patch/Y1uVp8hHo7DYUK82@valkosipuli.retiisi.eu/>

-- 
Sakari Ailus

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] media: exynos4-is: don't rely on the v4l2_async_subdev internals
  2022-11-09  9:29       ` Sakari Ailus
@ 2022-11-09 10:30         ` Marek Szyprowski
  0 siblings, 0 replies; 6+ messages in thread
From: Marek Szyprowski @ 2022-11-09 10:30 UTC (permalink / raw)
  To: Sakari Ailus
  Cc: Sylwester Nawrocki, linux-media, 'Linux Samsung SOC',
	Daniel Scally, Laurent Pinchart, Hans Verkuil

On 09.11.2022 10:29, Sakari Ailus wrote:
> On Tue, Nov 08, 2022 at 03:14:14PM +0100, Marek Szyprowski wrote:
>> On 05.10.2022 16:47, Sylwester Nawrocki wrote:
>>> On 23.09.2022 11:42, Marek Szyprowski wrote:
>>>> Commit 1f391df44607 ("media: v4l2-async: Use endpoints in
>>>> __v4l2_async_nf_add_fwnode_remote()") changed the data that is stored in
>>>> the v4l2_async_subdev internals from the fwnode pointer to the parent
>>>> device to the fwnode pointer to the matched endpoint. This broke the
>>>> sensor matching code, which relied on the particular fwnode data in the
>>>> v4l2_async_subdev internals. Fix this by simply matching the
>>>> v4l2_async_subdev pointer, which is already available there.
>>>>
>>>> Reported-by: Daniel Scally <djrscally@gmail.com>
>>>> Fixes: fa91f1056f17 ("[media] exynos4-is: Add support for asynchronous subdevices registration")
>>>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>>> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> Gentle ping for merging this fix.
> It's in my PR to Mauro:

Thanks for pointing this. I missed that. Sorry for the noise.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-09 10:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20220923094232eucas1p1deb3985c9637a0876609c75967175e9b@eucas1p1.samsung.com>
2022-09-23  9:42 ` [PATCH] media: exynos4-is: don't rely on the v4l2_async_subdev internals Marek Szyprowski
2022-09-23 20:35   ` Daniel Scally
2022-10-05 14:47   ` Sylwester Nawrocki
2022-11-08 14:14     ` Marek Szyprowski
2022-11-09  9:29       ` Sakari Ailus
2022-11-09 10:30         ` Marek Szyprowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).