Linux-Media Archive on lore.kernel.org
 help / Atom feed
* [GIT FIXES FOR v5.0] v4l2-ioctl: Clear only per-plane reserved fields
@ 2019-01-10 11:53 Hans Verkuil
  0 siblings, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2019-01-10 11:53 UTC (permalink / raw)
  To: Linux Media Mailing List; +Cc: Thierry Reding

Fix for a nasty little bug.

Thanks Thierry for finding this!

Regards,

	Hans

The following changes since commit 1e0d0a5fd38192f23304ea2fc2b531fea7c74247:

  media: s5p-mfc: fix incorrect bus assignment in virtual child device (2019-01-07 14:39:36 -0500)

are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.0a

for you to fetch changes up to b8ee4a126c857638a4696b8b24b4c555ef7fedb7:

  media: v4l2-ioctl: Clear only per-plane reserved fields (2019-01-10 12:50:36 +0100)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Thierry Reding (1):
      media: v4l2-ioctl: Clear only per-plane reserved fields

 drivers/media/v4l2-core/v4l2-ioctl.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GIT FIXES FOR v5.0] v4l2-ioctl: Clear only per-plane reserved fields
  2019-01-11 21:10 ` Sakari Ailus
@ 2019-01-12  9:17   ` Hans Verkuil
  0 siblings, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2019-01-12  9:17 UTC (permalink / raw)
  To: Sakari Ailus; +Cc: Linux Media Mailing List, Thierry Reding

On 1/11/19 10:10 PM, Sakari Ailus wrote:
> Hi Hans,
> 
> On Fri, Jan 11, 2019 at 09:31:25AM +0100, Hans Verkuil wrote:
>> Three fixes for a bug introduced in 5.0.
>>
>> The last patch (Validate num_planes for debug messages) is also backported
>> to kernels >= 4.12 (the oldest kernel for which it applies cleanly).
> 
> The surrounding lines of code have changed slightly over the years. The
> older kernels still suffer from the same problem as far as I see, so the
> backport is relevant down to 3.16 at least (but older kernels aren't
> supported anyway so I didn't check further). The problem was likely
> introduced by the big IOCTL handling patches long, long time ago. Huh.
> 

I didn't plan on backporting this to older kernels. You have to be root
to enable this debugging, so it is not security bug.

Regards,

	Hans

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GIT FIXES FOR v5.0] v4l2-ioctl: Clear only per-plane reserved fields
  2019-01-11  8:31 Hans Verkuil
@ 2019-01-11 21:10 ` Sakari Ailus
  2019-01-12  9:17   ` Hans Verkuil
  0 siblings, 1 reply; 4+ messages in thread
From: Sakari Ailus @ 2019-01-11 21:10 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: Linux Media Mailing List, Thierry Reding

Hi Hans,

On Fri, Jan 11, 2019 at 09:31:25AM +0100, Hans Verkuil wrote:
> Three fixes for a bug introduced in 5.0.
> 
> The last patch (Validate num_planes for debug messages) is also backported
> to kernels >= 4.12 (the oldest kernel for which it applies cleanly).

The surrounding lines of code have changed slightly over the years. The
older kernels still suffer from the same problem as far as I see, so the
backport is relevant down to 3.16 at least (but older kernels aren't
supported anyway so I didn't check further). The problem was likely
introduced by the big IOCTL handling patches long, long time ago. Huh.

-- 
Regards,

Sakari Ailus
sakari.ailus@linux.intel.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [GIT FIXES FOR v5.0] v4l2-ioctl: Clear only per-plane reserved fields
@ 2019-01-11  8:31 Hans Verkuil
  2019-01-11 21:10 ` Sakari Ailus
  0 siblings, 1 reply; 4+ messages in thread
From: Hans Verkuil @ 2019-01-11  8:31 UTC (permalink / raw)
  To: Linux Media Mailing List; +Cc: Thierry Reding, Sakari Ailus

Three fixes for a bug introduced in 5.0.

The last patch (Validate num_planes for debug messages) is also backported
to kernels >= 4.12 (the oldest kernel for which it applies cleanly).

Regards,

	Hans


The following changes since commit 1e0d0a5fd38192f23304ea2fc2b531fea7c74247:

  media: s5p-mfc: fix incorrect bus assignment in virtual child device (2019-01-07 14:39:36 -0500)

are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.0a2

for you to fetch changes up to 8015f0ce4a3c533acfbb3a71f0d6659fa4120778:

  v4l: ioctl: Validate num_planes for debug messages (2019-01-11 09:17:40 +0100)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Sakari Ailus (2):
      v4l: ioctl: Validate num_planes before using it
      v4l: ioctl: Validate num_planes for debug messages

Thierry Reding (1):
      media: v4l2-ioctl: Clear only per-plane reserved fields

 drivers/media/v4l2-core/v4l2-ioctl.c | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10 11:53 [GIT FIXES FOR v5.0] v4l2-ioctl: Clear only per-plane reserved fields Hans Verkuil
2019-01-11  8:31 Hans Verkuil
2019-01-11 21:10 ` Sakari Ailus
2019-01-12  9:17   ` Hans Verkuil

Linux-Media Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-media/0 linux-media/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-media linux-media/ https://lore.kernel.org/linux-media \
		linux-media@vger.kernel.org linux-media@archiver.kernel.org
	public-inbox-index linux-media


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-media


AGPL code for this site: git clone https://public-inbox.org/ public-inbox