From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.gmx.net ([212.227.15.19]:55584 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbdK3Hdn (ORCPT ); Thu, 30 Nov 2017 02:33:43 -0500 Date: Thu, 30 Nov 2017 08:33:08 +0100 (CET) From: Guennadi Liakhovetski To: Mauro Carvalho Chehab cc: Linux Media Mailing List , Mauro Carvalho Chehab Subject: Re: [PATCH 15/22] media: soc_camera: fix a kernel-doc markup In-Reply-To: Message-ID: References: <73497577f67fbb917e40ab4328104ff310a7c356.1511982439.git.mchehab@s-opensource.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-media-owner@vger.kernel.org List-ID: On Wed, 29 Nov 2017, Mauro Carvalho Chehab wrote: > Remove this warning: > drivers/media/platform/soc_camera/soc_scale_crop.c:309: warning: Cannot understand * @icd - soc-camera device > on line 309 - I thought it was a doc line > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Guennadi Liakhovetski Thanks Guennadi > --- > drivers/media/platform/soc_camera/soc_scale_crop.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/drivers/media/platform/soc_camera/soc_scale_crop.c b/drivers/media/platform/soc_camera/soc_scale_crop.c > index 0116097c0c0f..270ec613c27c 100644 > --- a/drivers/media/platform/soc_camera/soc_scale_crop.c > +++ b/drivers/media/platform/soc_camera/soc_scale_crop.c > @@ -306,16 +306,17 @@ static int client_set_fmt(struct soc_camera_device *icd, > } > > /** > - * @icd - soc-camera device > - * @rect - camera cropping window > - * @subrect - part of rect, sent to the user > - * @mf - in- / output camera output window > - * @width - on input: max host input width > - * on output: user width, mapped back to input > - * @height - on input: max host input height > - * on output: user height, mapped back to input > - * @host_can_scale - host can scale this pixel format > - * @shift - shift, used for scaling > + * soc_camera_client_scale > + * @icd: soc-camera device > + * @rect: camera cropping window > + * @subrect: part of rect, sent to the user > + * @mf: in- / output camera output window > + * @width: on input: max host input width; > + * on output: user width, mapped back to input > + * @height: on input: max host input height; > + * on output: user height, mapped back to input > + * @host_can_scale: host can scale this pixel format > + * @shift: shift, used for scaling > */ > int soc_camera_client_scale(struct soc_camera_device *icd, > struct v4l2_rect *rect, struct v4l2_rect *subrect, > -- > 2.14.3 >