From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D202C06513 for ; Tue, 2 Jul 2019 12:15:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 635A62146F for ; Tue, 2 Jul 2019 12:15:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727024AbfGBMP2 (ORCPT ); Tue, 2 Jul 2019 08:15:28 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:40240 "EHLO andre.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726664AbfGBMP1 (ORCPT ); Tue, 2 Jul 2019 08:15:27 -0400 Received: from ramsan ([84.194.98.4]) by andre.telenet-ops.be with bizsmtp id XoFQ2000W05gfCL01oFRCZ; Tue, 02 Jul 2019 14:15:25 +0200 Received: from geert (helo=localhost) by ramsan with local-esmtp (Exim 4.90_1) (envelope-from ) id 1hiHgy-0000th-Sl; Tue, 02 Jul 2019 14:15:24 +0200 Date: Tue, 2 Jul 2019 14:15:24 +0200 (CEST) From: Geert Uytterhoeven To: Hans Verkuil cc: Linux Media Mailing List , =?ISO-8859-15?Q?Niklas_S=F6derlund?= , Janusz Krzysztofik , Sakari Ailus , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCHv2 for v5.3] v4l2-subdev: fix regression in check_pad() In-Reply-To: <9885852d-d77e-7bfe-80d4-c4ff20443529@xs4all.nl> Message-ID: References: <9885852d-d77e-7bfe-80d4-c4ff20443529@xs4all.nl> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1525833268-1562069724=:3147" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1525833268-1562069724=:3147 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT Hi Hans, On Sat, 29 Jun 2019, Hans Verkuil wrote: > sd->entity.graph_obj.mdev can be NULL when this function is called, and > that breaks existing drivers (rcar-vin, but probably others as well). > > Check if sd->entity.num_pads is non-zero instead since that doesn't depend > on mdev. > > Signed-off-by: Hans Verkuil > Reported-by: Niklas Söderlund > Fixes: a8fa55078a77 ("media: v4l2-subdev: Verify arguments in v4l2_subdev_call()") > Tested-by: Niklas Söderlund Thanks, this fixes the following boot regression on r8a7791/koelsch: -rcar-vin e6ef0000.video: Device registered as video27 +rcar-vin e6ef0000.video: Unsupported media bus format for adv7612 13-004c +rcar-vin e6ef0000.video: Notifier registration failed +rcar-vin: probe of e6ef0000.video failed with error -22 Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds --8323329-1525833268-1562069724=:3147--