From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79773C4360D for ; Sun, 8 Sep 2019 14:46:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59B66214DB for ; Sun, 8 Sep 2019 14:46:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728513AbfIHOqk (ORCPT ); Sun, 8 Sep 2019 10:46:40 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:50303 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725928AbfIHOqk (ORCPT ); Sun, 8 Sep 2019 10:46:40 -0400 Received: from 195-23-252-147.net.novis.pt ([195.23.252.147] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1i6ySS-0004DN-Lg; Sun, 08 Sep 2019 16:46:28 +0200 Date: Sun, 8 Sep 2019 15:46:16 +0100 (WEST) From: Thomas Gleixner To: Matthew Wilcox cc: Markus Heiser , Mauro Carvalho Chehab , Jonathan Corbet , Linux Media Mailing List , Mauro Carvalho Chehab , Greg Kroah-Hartman , Joe Perches , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Sven Eckelmann , Ingo Molnar , Doug Smythies , =?ISO-8859-15?Q?Aur=E9lien_Cedeyn?= , Vincenzo Frascino , linux-doc@vger.kernel.org, "Rafael J. Wysocki" , Andrew Morton , Thierry Reding , Armijn Hemel , Jiri Olsa , =?ISO-8859-15?Q?Uwe_Kleine-K=F6nig?= , Namhyung Kim , Peter Zijlstra , Federico Vaga , Allison Randal , Alexander Shishkin , Shuah Khan Subject: Re: [PATCH 0/6] Address issues with SPDX requirements and PEP-263 In-Reply-To: <20190908100328.GB29434@bombadil.infradead.org> Message-ID: References: <20190907073419.6a88e318@lwn.net> <20190907132259.3199c8a2@coco.lan> <20190907150442.583b44c2@coco.lan> <686101df-f40c-916e-2730-353a3852cc84@darmarit.de> <20190908100328.GB29434@bombadil.infradead.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Sun, 8 Sep 2019, Matthew Wilcox wrote: > On Sat, Sep 07, 2019 at 11:17:22PM +0200, Thomas Gleixner wrote: > > On Sat, 7 Sep 2019, Markus Heiser wrote: > > > Am 07.09.19 um 20:04 schrieb Mauro Carvalho Chehab: > > > > No idea. I would actually prefer to just remove the restriction, and let > > > > the SPDX header to be anywhere inside the first comment block inside a > > > > file [2]. > > > > [2] I *suspect* that the restriction was added in order to make > > > > ./scripts/spdxcheck.py to run faster and to avoid false positives. > > > > Right now, if the maximum limit is removed (or set to a very high > > > > value), there will be one false positive: > > > > Nope. The intention was to have a well define place and format instead of > > everyone and his dog deciding to put it somewhere. SPDX is not intended to > > replace the existing licensing mess with some other randomly placed and > > formatted licensing mess. > > I find the current style quite unaesthetic: > > // SPDX-License-Identifier: GPL-2.0-only > /* > * linux/mm/memory.c > * > * Copyright (C) 1991, 1992, 1993, 1994 Linus Torvalds > */ > > I'd much rather see > > /* > * SPDX-License-Identifier: GPL-2.0-only > * Copyright (C) 1991, 1992, 1993, 1994 Linus Torvalds > */ > > but I appreciate the desire to force it to be on the first line if at all > possible. That style is inflicted upon you by Penguin Emperor Decree. :)