From: Markus Elfring <Markus.Elfring@web.de>
To: Evgeny Novikov <novikov@ispras.ru>,
ldv-project@linuxtesting.org, linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Prabhakar Lad <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH] media: davinci: vpif_capture: fix potential double free
Date: Thu, 23 Jul 2020 22:15:16 +0200 [thread overview]
Message-ID: <b179ad63-b895-39f7-dc18-23636f77e1e4@web.de> (raw)
> In case of errors vpif_probe_complete() releases memory for vpif_obj.sd
> and unregisters the V4L2 device. But then this is done again by
> vpif_probe() itself. The patch removes the cleaning from
> vpif_probe_complete().
* An imperative wording can be preferred for the change description,
can't it?
* Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
next reply other threads:[~2020-07-23 20:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 20:15 Markus Elfring [this message]
2020-07-24 20:08 ` [PATCH] media: davinci: vpif_capture: fix potential double free Evgeny Novikov
-- strict thread matches above, loose matches on Subject: below --
2020-07-23 17:04 Evgeny Novikov
2020-07-24 14:16 ` Lad, Prabhakar
2020-07-24 20:00 ` Evgeny Novikov
2020-07-24 22:05 ` Lad, Prabhakar
2020-08-02 18:38 ` Evgeny Novikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b179ad63-b895-39f7-dc18-23636f77e1e4@web.de \
--to=markus.elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=novikov@ispras.ru \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).