From: Randy Dunlap <rdunlap@infradead.org>
To: Xiaofeng Cao <cxfcosmos@gmail.com>, mchehab@kernel.org
Cc: hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
Xiaofeng Cao <caoxiaofeng@yulong.com>
Subject: Re: [PATCH] drivers/media/pci/bt8xx/bttv-cards: fix typos
Date: Tue, 23 Mar 2021 10:39:57 -0700 [thread overview]
Message-ID: <b297b819-8837-cfa0-0a62-d40958697bb2@infradead.org> (raw)
In-Reply-To: <20210323122546.16262-1-caoxiaofeng@yulong.com>
Hi,
Please see a few comments below.
On 3/23/21 5:25 AM, Xiaofeng Cao wrote:
> change 'vodeo' to 'video'
> change 'nevery' to 'never'
> change 'is' to 'it'
> change 'connevted' to 'connected'
> change 'swichers' to 'switchers'
> change 'strucure' to 'structure'
> change 'unblanced' to 'unbalanced'
> change 'fonctionality' to 'functionality'
>
> Signed-off-by: Xiaofeng Cao <caoxiaofeng@yulong.com>
> ---
> drivers/media/pci/bt8xx/bttv-cards.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/media/pci/bt8xx/bttv-cards.c b/drivers/media/pci/bt8xx/bttv-cards.c
> index ca20b806e82d..9a07e1094978 100644
> --- a/drivers/media/pci/bt8xx/bttv-cards.c
> +++ b/drivers/media/pci/bt8xx/bttv-cards.c
> @@ -2506,7 +2506,7 @@ struct tvcard bttv_tvcards[] = {
> one external BNC composite input (mux 2)
> three internal composite inputs (unknown muxes)
> an 18-bit stereo A/D (CS5331A), which has:
> - one external stereo unblanced (RCA) audio connection
> + one external stereo unbalanced(RCA) audio connection
Please leave a space between unbalanced and (RCA).
> one (or 3?) internal stereo balanced (XLR) audio connection
> input is selected via gpio to a 14052B mux
> (mask=0x300, unbal=0x000, bal=0x100, ??=0x200,0x300)
> @@ -4580,7 +4580,7 @@ static void xguard_muxsel(struct bttv *btv, unsigned int input)
> }
> static void picolo_tetra_init(struct bttv *btv)
> {
> - /*This is the video input redirection fonctionality : I DID NOT USED IT. */
> + /*This is the video input redirection functionality : I DID NOT USED IT. */
I DID NOT USE IT. *
> btwrite (0x08<<16,BT848_GPIO_DATA);/*GPIO[19] [==> 4053 B+C] set to 1 */
> btwrite (0x04<<16,BT848_GPIO_DATA);/*GPIO[18] [==> 4053 A] set to 1*/
> }
thanks.
--
~Randy
prev parent reply other threads:[~2021-03-23 17:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 12:25 [PATCH] drivers/media/pci/bt8xx/bttv-cards: fix typos Xiaofeng Cao
2021-03-23 17:39 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b297b819-8837-cfa0-0a62-d40958697bb2@infradead.org \
--to=rdunlap@infradead.org \
--cc=caoxiaofeng@yulong.com \
--cc=cxfcosmos@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).