From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC135C433E0 for ; Wed, 10 Jun 2020 16:11:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BECBC2063A for ; Wed, 10 Jun 2020 16:11:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728077AbgFJQLM (ORCPT ); Wed, 10 Jun 2020 12:11:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726219AbgFJQLM (ORCPT ); Wed, 10 Jun 2020 12:11:12 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15112C03E96B for ; Wed, 10 Jun 2020 09:11:12 -0700 (PDT) Received: from [IPv6:2003:cb:871f:5b00:9cc4:c525:7ca2:283] (p200300cb871f5b009cc4c5257ca20283.dip0.t-ipconnect.de [IPv6:2003:cb:871f:5b00:9cc4:c525:7ca2:283]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dafna) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 1FE762A07BF; Wed, 10 Jun 2020 17:11:09 +0100 (BST) Subject: Re: [PATCH v2 1/4] media: staging: rkisp1: cap: change RGB24 format to XBGR32 To: Tomasz Figa Cc: Linux Media Mailing List , Helen Koike , Ezequiel Garcia , Hans Verkuil , kernel@collabora.com, Dafna Hirschfeld , Sakari Ailus , "open list:ARM/Rockchip SoC..." , Mauro Carvalho Chehab , Laurent Pinchart References: <20200515142952.20163-1-dafna.hirschfeld@collabora.com> <20200515142952.20163-2-dafna.hirschfeld@collabora.com> From: Dafna Hirschfeld Message-ID: Date: Wed, 10 Jun 2020 18:11:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 27.05.20 01:04, Tomasz Figa wrote: > Hi Dafna, > > On Fri, May 15, 2020 at 4:30 PM Dafna Hirschfeld > wrote: >> >> According to the TRM, the YUV->RGB conversion outputs >> "24 bit word". What it means is that 4 bytes are used with >> 24bit for the RGB and the last byte is ignored. > > I don't see this mentioned in the datasheets I have. On the other > hand, XBGR32 indeed makes much more sense, as the 3-byte RGB isn't a > very popular format. Have you validated that the hardware behavior > indeed matches that? Hi, yes I validated it, I also found it mentioned here: http://rockchip.fr/RK3288%20TRM/rk3288-chapter-31-image-signal-processing-(isp).pdf under section "31.3.9 YCbCr to RGB Conversion" Thanks, Dafna > > Best regards, > Tomasz > >> This matches format V4L2_PIX_FMT_XBGR32. >> >> Signed-off-by: Dafna Hirschfeld >> --- >> drivers/staging/media/rkisp1/rkisp1-capture.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/media/rkisp1/rkisp1-capture.c b/drivers/staging/media/rkisp1/rkisp1-capture.c >> index f69235f82c45..61b9ebe577b2 100644 >> --- a/drivers/staging/media/rkisp1/rkisp1-capture.c >> +++ b/drivers/staging/media/rkisp1/rkisp1-capture.c >> @@ -276,7 +276,7 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_sp_fmts[] = { >> }, >> /* rgb */ >> { >> - .fourcc = V4L2_PIX_FMT_RGB24, >> + .fourcc = V4L2_PIX_FMT_XBGR32, >> .write_format = RKISP1_MI_CTRL_SP_WRITE_PLA, >> .output_format = RKISP1_MI_CTRL_SP_OUTPUT_RGB888, >> }, { >> -- >> 2.17.1 >>