From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Nikhil Devshatwar <nikhil.nd@ti.com>,
<linux-media@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Benoit Parrot <bparrot@ti.com>, Sekhar Nori <nsekhar@ti.com>
Subject: Re: [PATCH] media: platform: ti-vpe: Update the path to firmware
Date: Fri, 30 Oct 2020 16:03:57 +0200
Message-ID: <b785b507-fad4-34db-c7d1-e5ce190f6c41@ti.com> (raw)
In-Reply-To: <14827fb7-4c2d-426d-cfde-221fd8c39c20@xs4all.nl>
On 30/10/2020 11:57, Hans Verkuil wrote:
> Hi Nikhil,
>
> On 12/10/2020 14:52, Nikhil Devshatwar wrote:
>> vpdma firmware is now available in the linux-firmware repo.
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin
>>
>> Update the firmware path requested by the VPDMA driver so that
>> it gets looked up correctly in the filesystem.
>>
>> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
>> ---
>> drivers/media/platform/ti-vpe/vpdma.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti-vpe/vpdma.c
>> index 2e5148ae7a0f..5a378449a4ff 100644
>> --- a/drivers/media/platform/ti-vpe/vpdma.c
>> +++ b/drivers/media/platform/ti-vpe/vpdma.c
>> @@ -23,7 +23,7 @@
>> #include "vpdma.h"
>> #include "vpdma_priv.h"
>>
>> -#define VPDMA_FIRMWARE "vpdma-1b8.bin"
>> +#define VPDMA_FIRMWARE "ti-connectivity/vpdma-1b8.bin"
>
> Based on the discussion, this will change to ti/vpdma-1b8.bin, right?
> At least once linux-firmware has been updated.
>
> I'll wait for a v2.
Yes, please wait for v2. I think it'll be ti/vpdma-1b8.bin, or alternatively keep it as it is now
(in the root).
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
prev parent reply index
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 12:52 Nikhil Devshatwar
2020-10-12 12:53 ` Laurent Pinchart
2020-10-19 11:38 ` Tomi Valkeinen
2020-10-20 7:38 ` Nikhil Devshatwar
2020-10-20 7:52 ` Tomi Valkeinen
2020-10-22 11:45 ` Nikhil Devshatwar
2020-10-30 9:57 ` Hans Verkuil
2020-10-30 14:03 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b785b507-fad4-34db-c7d1-e5ce190f6c41@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=bparrot@ti.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=nikhil.nd@ti.com \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-Media Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-media/0 linux-media/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-media linux-media/ https://lore.kernel.org/linux-media \
linux-media@vger.kernel.org
public-inbox-index linux-media
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-media
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git