From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Rob Clark <robdclark@gmail.com>,
dri-devel@lists.freedesktop.org,
Rob Clark <robdclark@chromium.org>,
freedreno@lists.freedesktop.org,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
open list <linux-kernel@vger.kernel.org>,
Jonathan Marek <jonathan@marek.ca>, Emma Anholt <emma@anholt.net>,
Bernard Zhao <bernard@vivo.com>,
Sharat Masetty <smasetty@codeaurora.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Akhil P Oommen <akhilpo@codeaurora.org>,
Douglas Anderson <dianders@chromium.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>,
Zhenzhong Duan <zhenzhong.duan@gmail.com>,
"Kristian H. Kristensen" <hoegsberg@google.com>,
"open list:DRM DRIVER FOR MSM ADRENO GPU"
<linux-arm-msm@vger.kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
Lee Jones <lee.jones@linaro.org>,
Dave Airlie <airlied@redhat.com>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<linux-media@vger.kernel.org>
Subject: Re: [Linaro-mm-sig] [PATCH 00/11] drm/msm: drm scheduler conversion and cleanups
Date: Tue, 20 Jul 2021 16:16:56 +0200 [thread overview]
Message-ID: <bbc4f7fc-9d51-695e-2bb7-62558d7523e2@gmail.com> (raw)
In-Reply-To: <YPbYnLBin9N4weiC@phenom.ffwll.local>
Am 20.07.21 um 16:07 schrieb Daniel Vetter:
> On Mon, Jul 19, 2021 at 10:40:57AM +0200, Christian König wrote:
>> Am 17.07.21 um 22:29 schrieb Rob Clark:
>>> From: Rob Clark <robdclark@chromium.org>
>>>
>>> Conversion to gpu_scheduler, and bonus removal of
>>> drm_gem_object_put_locked()
>> Oh yes please!
>>
>> If I'm not completely mistaken that was the last puzzle piece missing to
>> unify TTMs and GEMs refcount of objects.
> Why does drm/msm, a driver not using ttm at all, block ttm refactorings?
> We can just check whether the TTM using driver is potentially using locked
> final unref and have a special version of
> drm_gem_object_put_guaranteed_unlocked or whatever the bikeshed will look
> like, which doesn't have the migth_lock.
Because we now don't have any unrealistic lock inversion between
dev->struct_mutex and obj->resv lockdep can complain any more.
Cheers,
Christian.
>
> Anyway, deed is done now :-)
> -Daniel
>
>> Only problem is that I only see patch 7 and 9 in my inbox. Where is the
>> rest?
>>
>> Thanks,
>> Christian.
>>
>>> Rob Clark (11):
>>> drm/msm: Docs and misc cleanup
>>> drm/msm: Small submitqueue creation cleanup
>>> drm/msm: drop drm_gem_object_put_locked()
>>> drm: Drop drm_gem_object_put_locked()
>>> drm/msm/submit: Simplify out-fence-fd handling
>>> drm/msm: Consolidate submit bo state
>>> drm/msm: Track "seqno" fences by idr
>>> drm/msm: Return ERR_PTR() from submit_create()
>>> drm/msm: Conversion to drm scheduler
>>> drm/msm: Drop struct_mutex in submit path
>>> drm/msm: Utilize gpu scheduler priorities
>>>
>>> drivers/gpu/drm/drm_gem.c | 22 --
>>> drivers/gpu/drm/msm/Kconfig | 1 +
>>> drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 4 +-
>>> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 +-
>>> drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +-
>>> drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 7 +-
>>> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 12 +-
>>> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +-
>>> drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 4 +-
>>> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 6 +-
>>> drivers/gpu/drm/msm/msm_drv.c | 30 +-
>>> drivers/gpu/drm/msm/msm_fence.c | 39 ---
>>> drivers/gpu/drm/msm/msm_fence.h | 2 -
>>> drivers/gpu/drm/msm/msm_gem.c | 91 +-----
>>> drivers/gpu/drm/msm/msm_gem.h | 37 ++-
>>> drivers/gpu/drm/msm/msm_gem_submit.c | 300 ++++++++++++--------
>>> drivers/gpu/drm/msm/msm_gpu.c | 50 +---
>>> drivers/gpu/drm/msm/msm_gpu.h | 41 ++-
>>> drivers/gpu/drm/msm/msm_ringbuffer.c | 70 ++++-
>>> drivers/gpu/drm/msm/msm_ringbuffer.h | 12 +
>>> drivers/gpu/drm/msm/msm_submitqueue.c | 49 +++-
>>> include/drm/drm_gem.h | 2 -
>>> include/uapi/drm/msm_drm.h | 10 +-
>>> 23 files changed, 440 insertions(+), 359 deletions(-)
>>>
next prev parent reply other threads:[~2021-07-20 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 20:29 [PATCH 00/11] drm/msm: drm scheduler conversion and cleanups Rob Clark
2021-07-17 20:29 ` [PATCH 07/11] drm/msm: Track "seqno" fences by idr Rob Clark
2021-07-17 20:29 ` [PATCH 09/11] drm/msm: Conversion to drm scheduler Rob Clark
2021-07-19 8:40 ` [Linaro-mm-sig] [PATCH 00/11] drm/msm: drm scheduler conversion and cleanups Christian König
2021-07-19 14:21 ` Rob Clark
2021-07-19 14:45 ` Christian König
2021-07-20 14:07 ` Daniel Vetter
2021-07-20 14:16 ` Christian König [this message]
2021-07-20 14:24 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbc4f7fc-9d51-695e-2bb7-62558d7523e2@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=airlied@redhat.com \
--cc=akhilpo@codeaurora.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bernard@vivo.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=freedreno@lists.freedesktop.org \
--cc=hoegsberg@google.com \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@somainline.org \
--cc=lee.jones@linaro.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=smasetty@codeaurora.org \
--cc=zhenzhong.duan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).