From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 572EDC43140 for ; Sat, 7 Sep 2019 14:36:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C31221871 for ; Sat, 7 Sep 2019 14:36:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393214AbfIGOgp (ORCPT ); Sat, 7 Sep 2019 10:36:45 -0400 Received: from smtp1.goneo.de ([85.220.129.30]:42288 "EHLO smtp1.goneo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388202AbfIGOgp (ORCPT ); Sat, 7 Sep 2019 10:36:45 -0400 Received: from localhost (localhost [127.0.0.1]) by smtp1.goneo.de (Postfix) with ESMTP id 1845123F3DE; Sat, 7 Sep 2019 16:36:41 +0200 (CEST) X-Virus-Scanned: by goneo Received: from smtp1.goneo.de ([127.0.0.1]) by localhost (smtp1.goneo.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b-iajWqFRVuP; Sat, 7 Sep 2019 16:36:39 +0200 (CEST) Received: from [192.168.1.127] (dyndsl-178-142-129-167.ewe-ip-backbone.de [178.142.129.167]) by smtp1.goneo.de (Postfix) with ESMTPSA id 3B3ED23F6E3; Sat, 7 Sep 2019 16:36:37 +0200 (CEST) Subject: Re: [PATCH 0/6] Address issues with SPDX requirements and PEP-263 To: Jonathan Corbet , Mauro Carvalho Chehab Cc: Linux Media Mailing List , Mauro Carvalho Chehab , Greg Kroah-Hartman , Joe Perches , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Sven Eckelmann , Ingo Molnar , Thomas Gleixner , Doug Smythies , =?UTF-8?Q?Aur=c3=a9lien_Cedeyn?= , Vincenzo Frascino , linux-doc@vger.kernel.org, "Rafael J. Wysocki" , Andrew Morton , Thierry Reding , Armijn Hemel , Jiri Olsa , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Namhyung Kim , Peter Zijlstra , Federico Vaga , Allison Randal , Alexander Shishkin References: <20190907073419.6a88e318@lwn.net> From: Markus Heiser Message-ID: Date: Sat, 7 Sep 2019 16:36:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190907073419.6a88e318@lwn.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Am 07.09.19 um 15:34 schrieb Jonathan Corbet: > On Thu, 5 Sep 2019 16:57:47 -0300 > Mauro Carvalho Chehab wrote: > >> The description at Documentation/process/license-rules.rst is very strict >> with regards to the position where the SPDX tags should be. >> >> In the past several developers and maintainers interpreted it on a >> more permissive way, placing the SPDX header between lines 1 to 15, >> with are the ones which the scripts/spdxcheck.py script verifies. >> >> However, recently, devs are becoming more strict about such >> requirement and want it to strictly follow the rule, with states that >> the SPDX rule should be at the first line ever on most files, and >> at the second line for scripts. >> >> Well, for Python script, such requirement causes violation to PEP-263, >> making regressions on scripts that contain encoding lines, as PEP-263 >> also states about the same. >> >> This series addresses it. > > So I really don't want to be overly difficult here, but I would like to > approach this from yet another angle... > >> Patches 1 to 3 fix some Python scripts that violates PEP-263; > > I just checked all of those scripts, and they are all just plain ASCII. > So it really doesn't matter whether the environment defaults to UTF-8 or > ASCII here. So, in other words, we really shouldn't need to define the > encoding at all. > Thats what I mean [1] .. lets patch the description in the license-rules.rst:: - first line for the OS (shebang) - second line for environment (python-encoding, editor-mode, ...) - third and more lines for application (SPDX use) .. [1] https://www.mail-archive.com/linux-doc@vger.kernel.org/msg33240.html -- Markus -- > This suggests to me that we're adding a bunch of complications that we > don't necessarily need. What am I missing here? > > Educate me properly and I'll not try to stand in the way of all this... > > Thanks, > > jon >