From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FFEAC49ED8 for ; Tue, 10 Sep 2019 15:02:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FE9F20863 for ; Tue, 10 Sep 2019 15:02:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392109AbfIJPCu (ORCPT ); Tue, 10 Sep 2019 11:02:50 -0400 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:55027 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730222AbfIJPCt (ORCPT ); Tue, 10 Sep 2019 11:02:49 -0400 Received: from [148.69.85.38] (port=20650 helo=[192.168.5.132]) by hostingweb31.netsons.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1i7hfI-005t84-5V; Tue, 10 Sep 2019 17:02:44 +0200 Subject: Re: [RFC,v2 3/6] media: dt-bindings: add DS90UB954-Q1 video deserializer To: Sakari Ailus Cc: linux-media@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Wolfram Sang , Hans Verkuil , Laurent Pinchart , Kieran Bingham , Jacopo Mondi , Vladimir Zapolskiy , Peter Rosin References: <20190723203723.11730-1-luca@lucaceresoli.net> <20190723203723.11730-4-luca@lucaceresoli.net> <20190910094327.GG5781@paasikivi.fi.intel.com> From: Luca Ceresoli Message-ID: Date: Tue, 10 Sep 2019 16:02:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190910094327.GG5781@paasikivi.fi.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca@lucaceresoli.net X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Archived-At: List-Archive: List-Post: Hi Sakari, On 10/09/19 10:43, Sakari Ailus wrote: > Hi Luca, > > On Tue, Jul 23, 2019 at 10:37:20PM +0200, Luca Ceresoli wrote: > > ... > >> +Device node example >> +------------------- >> + >> +&i2c0 { >> + deser: deser@3d { >> + compatible = "ti,ds90ub954-q1"; >> + reg-names = "main", "rxport0", "rxport1", "ser0", "ser1"; >> + reg = <0x3d>, <0x40>, <0x41>, <0x44>, <0x45>; >> + clocks = <&clk_25M>; >> + interrupt-parent = <&gic>; >> + interrupts = <3 1 IRQ_TYPE_LEVEL_HIGH>; >> + reset-gpios = <&gpio_ctl 4 GPIO_ACTIVE_LOW>; >> + >> + i2c-alias-pool = /bits/ 16 <0x4a 0x4b 0x4c 0x4d 0x4e 0x4f>; >> + >> + gpio-controller; >> + #gpio-cells = <3>; /* rxport, remote gpio num, flags */ >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + ds90ub954_fpd3_in0: endpoint { >> + remote-endpoint = <&sensor_0_out>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + ds90ub954_fpd3_in1: endpoint { >> + remote-endpoint = <&sensor_1_out>; >> + }; >> + }; >> + >> + port@2 { >> + reg = <2>; >> + ds90ub954_mipi_out0: endpoint { >> + data-lanes = <1 2 3 4>; >> + /* Actually a REFCLK multiplier */ >> + data-rate = <1600000000>; > > What is data-rate used for? Is it documented somewhere? Could you use > link-frequencies property instead? It's defined in video-interfaces.txt. Right, it should be link-frequencies. Thanks for pointing out. -- Luca