From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F393C43140 for ; Thu, 5 Sep 2019 14:17:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0669206A5 for ; Thu, 5 Sep 2019 14:17:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732487AbfIEORy (ORCPT ); Thu, 5 Sep 2019 10:17:54 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:37506 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727009AbfIEORx (ORCPT ); Thu, 5 Sep 2019 10:17:53 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nicolas) with ESMTPSA id CA45328DC0F Message-ID: Subject: Re: [PATCH 1/2] media: uapi: h264: Add num_ref_idx_active_override_flag From: Nicolas Dufresne Reply-To: Nicolas Dufresne To: Philipp Zabel , Tomasz Figa Cc: Linux Media Mailing List , Hans Verkuil , Ezequiel Garcia , Jonas Karlman , Paul Kocialkowski , Boris Brezillon , Sasha Hauer Date: Thu, 05 Sep 2019 10:17:48 -0400 In-Reply-To: <1567679973.3958.1.camel@pengutronix.de> References: <20190905101533.525-1-p.zabel@pengutronix.de> <1567679973.3958.1.camel@pengutronix.de> Organization: Collabora Ltd. Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-7Xp+djquZaKrFdQPURBI" User-Agent: Evolution 3.32.4 (3.32.4-1.fc30) MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org --=-7Xp+djquZaKrFdQPURBI Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le jeudi 05 septembre 2019 =C3=A0 12:39 +0200, Philipp Zabel a =C3=A9crit : > On Thu, 2019-09-05 at 19:31 +0900, Tomasz Figa wrote: > > On Thu, Sep 5, 2019 at 7:15 PM Philipp Zabel w= rote: > > > This flag tells the kernel whether the slice header contained the > > > num_ref_idx_l[01]_active_minus1 syntax elements, or whether the > > > num_ref_idx_l[01]_default_active_minus1 from PPS should be used > > > instead. > > >=20 > > > Signed-off-by: Philipp Zabel > > > --- > > > Documentation/media/uapi/v4l/ext-ctrls-codec.rst | 3 +++ > > > include/media/h264-ctrls.h | 1 + > > > 2 files changed, 4 insertions(+) > > >=20 > > > diff --git a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst b/Docum= entation/media/uapi/v4l/ext-ctrls-codec.rst > > > index bc5dd8e76567..451a5b0f2a35 100644 > > > --- a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst > > > +++ b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst > > > @@ -1860,6 +1860,9 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_t= ype - > > > * - ``V4L2_H264_SLICE_FLAG_SP_FOR_SWITCH`` > > > - 0x00000008 > > > - > > > + * - ``V4L2_H264_SLICE_FLAG_NUM_REF_IDX_ACTIVE_OVERRIDE > > > + - 0x00000010 > > > + - Corresponds to the num_ref_idx_active_override_flag syntax e= lement. > > >=20 > >=20 > > As far as I remember, the idea was for the userspace to always put the > > right num_ref_idx in the slice_params and the drivers always use that. > > Was there any problem with that? >=20 > I don't think so, at least for currently known hardware. >=20 > In that case we should drop the unused > num_ref_idx_l[01]_default_active_minus1 fields from struct > v4l2_ctrl_h264_pps and document that userspace should fill > the defaults into v4l2_ctrl_h264_slice_params themselves if > num_ref_idx_active_override_flag wasn't set. It might have been added in a previous effort to allow reconstructing the bitstream from the structures. >=20 > regards > Philipp --=-7Xp+djquZaKrFdQPURBI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSScpfJiL+hb5vvd45xUwItrAaoHAUCXXEZDAAKCRBxUwItrAao HKvPAJ411GfhOiTwyBuYY8wkstYseV8pwACgkg7q+ktTacePhTuBlqa5mo8b+hc= =KD4i -----END PGP SIGNATURE----- --=-7Xp+djquZaKrFdQPURBI--