linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: "Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>,
	"Mauro Carvalho Chehab" <mchehab@infradead.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Joe Perches" <joe@perches.com>,
	linux-kernel@vger.kernel.org, "Jonathan Corbet" <corbet@lwn.net>,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Sven Eckelmann" <sven@narfation.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Doug Smythies" <doug.smythies@gmail.com>,
	"Aurélien Cedeyn" <aurelien.cedeyn@gmail.com>,
	"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
	linux-doc@vger.kernel.org,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Thierry Reding" <treding@nvidia.com>,
	"Armijn Hemel" <armijn@tjaldur.nl>,
	"Jiri Olsa" <jolsa@redhat.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Namhyung Kim" <namhyung@kernel.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Federico Vaga" <federico.vaga@vaga.pv.it>,
	"Allison Randal" <allison@lohutok.net>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>
Subject: [PATCH 0/6] Address issues with SPDX requirements and PEP-263
Date: Thu,  5 Sep 2019 16:57:47 -0300	[thread overview]
Message-ID: <cover.1567712829.git.mchehab+samsung@kernel.org> (raw)

The  description at Documentation/process/license-rules.rst is very strict
with regards to the position where the SPDX tags should be.

In the past several developers and maintainers interpreted it on a
more permissive way, placing the SPDX header between lines 1 to 15, 
with are the ones which the  scripts/spdxcheck.py script verifies.

However, recently, devs are becoming more strict about such
requirement and want it to strictly follow the rule, with states that
the SPDX rule should be at the first line ever on most files, and
at the second line for scripts.

Well, for Python script, such requirement causes violation to PEP-263, 
making regressions on scripts that contain encoding lines, as PEP-263
also states about the same.

This series addresses it.

Patches 1 to 3 fix some Python scripts that violates PEP-263;

Patch 4 mentions PEP-263 for Python scripts, allowing to go up to
line 3, when both "#!" and the encoding line is found;

Patch 5 changes the scripts/spdxcheck.py for it to identify on what
line each SPDX header is found, optinally allowing to print an histogram
about that;

Patch 6 adds a pedantic^Wstrict mode to scripts/spdxcheck.py,
making it to also check for violations at the line with contains the
SPDX header.

PS.: I sent already a RFC version for those patches along with this
thread:

    https://lore.kernel.org/lkml/b32c2e46b91e7bcda2a9bd140673f06d71b2487a.camel@perches.com/

Mauro Carvalho Chehab (6):
  docs: sphinx: add SPDX header for some sphinx extensions
  tools: perf: fix SPDX header in the light of PEP-263
  tools: intel_pstate_tracer.py: fix SPDX header in the light of PEP-263
  docs: license-rules.txt: cover SPDX headers on Python scripts
  scripts/spdxcheck.py: keep track on what line SPDX header was found
  scripts/spdxcheck.py: check if the line number follows the strict rule

 Documentation/process/license-rules.rst       |  7 ++-
 Documentation/sphinx/kernel_include.py        |  1 +
 Documentation/sphinx/rstFlatTable.py          |  1 +
 scripts/spdxcheck.py                          | 55 +++++++++++++++----
 tools/perf/python/tracepoint.py               |  3 +-
 tools/perf/python/twatch.py                   |  3 +-
 .../intel_pstate_tracer.py                    |  2 +-
 7 files changed, 55 insertions(+), 17 deletions(-)

-- 
2.21.0



             reply	other threads:[~2019-09-05 19:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-05 19:57 Mauro Carvalho Chehab [this message]
2019-09-05 19:57 ` [PATCH 1/6] docs: sphinx: add SPDX header for some sphinx extensions Mauro Carvalho Chehab
2019-09-05 19:57 ` [PATCH 2/6] tools: perf: fix SPDX header in the light of PEP-263 Mauro Carvalho Chehab
2019-09-05 19:57 ` [PATCH 3/6] tools: intel_pstate_tracer.py: " Mauro Carvalho Chehab
2019-09-05 19:57 ` [PATCH 4/6] docs: license-rules.txt: cover SPDX headers on Python scripts Mauro Carvalho Chehab
2019-09-05 19:57 ` [PATCH 5/6] scripts/spdxcheck.py: keep track on what line SPDX header was found Mauro Carvalho Chehab
2019-09-05 19:57 ` [PATCH 6/6] scripts/spdxcheck.py: check if the line number follows the strict rule Mauro Carvalho Chehab
2019-09-06 12:04   ` [PATCH v2 " Mauro Carvalho Chehab
2019-09-05 20:05 ` [PATCH 0/6] Address issues with SPDX requirements and PEP-263 Joe Perches
2019-09-06 12:02   ` Mauro Carvalho Chehab
2019-09-06 12:22     ` Joe Perches
2019-09-07 13:34 ` Jonathan Corbet
2019-09-07 14:36   ` Markus Heiser
2019-09-07 16:22     ` Mauro Carvalho Chehab
2019-09-07 17:33       ` Markus Heiser
2019-09-07 18:04         ` Mauro Carvalho Chehab
2019-09-07 18:37           ` Markus Heiser
2019-09-07 21:17             ` Thomas Gleixner
2019-09-08 10:03               ` Matthew Wilcox
2019-09-08 14:46                 ` Thomas Gleixner
2019-09-10  6:31                   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1567712829.git.mchehab+samsung@kernel.org \
    --to=mchehab+samsung@kernel.org \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=allison@lohutok.net \
    --cc=armijn@tjaldur.nl \
    --cc=aurelien.cedeyn@gmail.com \
    --cc=corbet@lwn.net \
    --cc=doug.smythies@gmail.com \
    --cc=federico.vaga@vaga.pv.it \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=jolsa@redhat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=sven@narfation.org \
    --cc=tglx@linutronix.de \
    --cc=treding@nvidia.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).