From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 475F0C433ED for ; Sun, 25 Apr 2021 08:40:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02FEE613B1 for ; Sun, 25 Apr 2021 08:40:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229637AbhDYIlG (ORCPT ); Sun, 25 Apr 2021 04:41:06 -0400 Received: from msg-1.mailo.com ([213.182.54.11]:40842 "EHLO msg-1.mailo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbhDYIlF (ORCPT ); Sun, 25 Apr 2021 04:41:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1619340015; bh=5liUc+da+ixTCoXc9F2Wovsz5zapQhdjMTOmkF7fQAU=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:MIME-Version: Content-Type; b=YnBJPcdf/Af42jGadmL9TIb9IzOIHsjVBLHgvIpFYwSaUyYWqdCzmmGFke9Uzmk/Y RO+sYQbH/PhBTSFJ+f3W+qMqwKMFJnGB3dmL/NtwbYWjpO78vVZYYw/nFINz5bX+V8 cSqfof7Va2q550wjFLdrURI1S4IP9ev2nuPy0RWE= Received: by 192.168.90.16 [192.168.90.16] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sun, 25 Apr 2021 10:40:15 +0200 (CEST) X-EA-Auth: HV6lrtq01prdfPlae/6UoMtV+bXHYWao8X0BG04YPCQb0xECfOR6ALwaUhRxevAF5dFXed6CDuVbiimgnnsitW1j7dOQD+J9 Date: Sun, 25 Apr 2021 14:10:09 +0530 From: Deepak R Varma To: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, drv@mailo.com Subject: [PATCH RESEND v3 0/6] staging: media: atomisp: code cleanup fixes Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This patch set addresses different kinds of checkpatch WARNING and CHECK complaints. Note: - Patch set being resent due a email messageID issue in the earlier patch set. - The patches should be applied in the ascending order. Changes since v2: Generic change: 1. Correct patch versioning in patch subject Patch Specific change: 1. patch 1/6 : none 2. patch 2/6 : none 3. patch 3/6 : none 4. patch 4/6 : a. Tag Fabio Auito for the patch suggestion 5. patch 5/6 : none 6. patch 6/6: a. Tag Fabio Auito for the patch suggestion Changes since v1: Generic change: 1. The patch set is being resent from an email account that matches with the patch signed-of-by tag. Issue highlighted by Hans Verkuil. Patch specific changes: 1. patch 1/6 : none 2. patch 2/6 : none 3. patch 3/6 : none 4. patch 4/6 : implement following changes suggested by Fabio Aiuto a. Corrected commenting style b. Similar style implemented for other comment blocks in the same files. 5. patch 5/6 : none 6. patch 6/6: implement following changes suggested by Fabio Aiuto a. use dev_info instead of pr_info b. update patch log message accordingly Deepak R Varma (6): staging: media: atomisp: improve function argument alignment staging: media: atomisp: balance braces around if...else block staging: media: atomisp: use __func__ over function names staging: media: atomisp: reformat code comment blocks staging: media: atomisp: fix CamelCase variable naming staging: media: atomisp: replace raw printk() by dev_info() .../media/atomisp/i2c/atomisp-gc0310.c | 14 +-- .../media/atomisp/i2c/atomisp-gc2235.c | 29 ++--- .../atomisp/i2c/atomisp-libmsrlisthelper.c | 6 +- .../media/atomisp/i2c/atomisp-lm3554.c | 2 +- .../media/atomisp/i2c/atomisp-mt9m114.c | 106 ++++++++++-------- .../media/atomisp/i2c/atomisp-ov2680.c | 43 ++++--- .../media/atomisp/i2c/atomisp-ov2722.c | 10 +- 7 files changed, 116 insertions(+), 94 deletions(-) -- 2.25.1