From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38FE5C46486 for ; Thu, 4 Jul 2019 14:13:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 126F6218BA for ; Thu, 4 Jul 2019 14:13:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="qjlH+KyK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727487AbfGDONI (ORCPT ); Thu, 4 Jul 2019 10:13:08 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:55302 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726875AbfGDONI (ORCPT ); Thu, 4 Jul 2019 10:13:08 -0400 Received: from [192.168.0.20] (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 842C824B; Thu, 4 Jul 2019 16:13:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1562249586; bh=dglkbnfZ3C4DFXrB/Pn4L+daSveV7B4rpHo9mBsyZIo=; h=Subject:To:Cc:References:Reply-To:From:Date:In-Reply-To:From; b=qjlH+KyKYk9D/vHbZsp1H57YIHiAaaF5hpjWJklyuCt1HCjGyEbEiWwQhCS113LMG 4iTjDxv8mp9xyLqzVvBjaei80H2AjsrszwvZo60kfhRZzHBNbiVNm670oNtjNE+U+x cah+yeFUvfru5GQ0F1jUyYEbKiLkBRu/o8XIetWk= Subject: Re: [PATCH v3 1/4] rcar-vin: Rename VNDMR_DTMD_ARGB1555 to VNDMR_DTMD_ARGB To: =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Laurent Pinchart , linux-media@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Ulrich Hecht References: <20190704015817.17083-1-niklas.soderlund+renesas@ragnatech.se> <20190704015817.17083-2-niklas.soderlund+renesas@ragnatech.se> Reply-To: kieran.bingham+renesas@ideasonboard.com From: Kieran Bingham Organization: Ideas on Board Message-ID: Date: Thu, 4 Jul 2019 15:13:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190704015817.17083-2-niklas.soderlund+renesas@ragnatech.se> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Niklas, On 04/07/2019 02:58, Niklas Söderlund wrote: > The value have nothing to do with ARGB1555, it controls if the alpha > component should be filled in for ARGB1555 or ARGB888. Rename it to > reflect this. > > Signed-off-by: Niklas Söderlund > Reviewed-by: Ulrich Hecht > Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- > drivers/media/platform/rcar-vin/rcar-dma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c b/drivers/media/platform/rcar-vin/rcar-dma.c > index 91ab064404a185af..2d146ecf93d66ad5 100644 > --- a/drivers/media/platform/rcar-vin/rcar-dma.c > +++ b/drivers/media/platform/rcar-vin/rcar-dma.c > @@ -114,7 +114,7 @@ > #define VNDMR_EXRGB (1 << 8) > #define VNDMR_BPSM (1 << 4) > #define VNDMR_DTMD_YCSEP (1 << 1) > -#define VNDMR_DTMD_ARGB1555 (1 << 0) > +#define VNDMR_DTMD_ARGB (1 << 0) > > /* Video n Data Mode Register 2 bits */ > #define VNDMR2_VPS (1 << 30) > @@ -721,7 +721,7 @@ static int rvin_setup(struct rvin_dev *vin) > output_is_yuv = true; > break; > case V4L2_PIX_FMT_XRGB555: > - dmr = VNDMR_DTMD_ARGB1555; > + dmr = VNDMR_DTMD_ARGB; > break; > case V4L2_PIX_FMT_RGB565: > dmr = 0; >