From: Robin Murphy <robin.murphy@arm.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Shunqian Zheng <zhengsq@rock-chips.com>,
linux-rockchip@lists.infradead.org, linux-media@vger.kernel.org
Cc: Jose.Abreu@synopsys.com, devicetree@vger.kernel.org,
eddie.cai.linux@gmail.com, Joao.Pinto@synopsys.com,
heiko@sntech.de, jacob2.chen@rock-chips.com,
jeffy.chen@rock-chips.com, zyc@rock-chips.com,
linux-kernel@vger.kernel.org, tfiga@chromium.org,
Luis.Oliveira@synopsys.com, robh+dt@kernel.org,
hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com,
sakari.ailus@linux.intel.com, allon.huang@rock-chips.com,
mchehab@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 03/16] media: rkisp1: Add user space ABI definitions
Date: Wed, 7 Feb 2018 12:38:50 +0000 [thread overview]
Message-ID: <d29bc615-2359-86c6-db5a-27cc111bc275@arm.com> (raw)
In-Reply-To: <5b29d890-8c6b-18ff-ade1-1923c25143a0@xs4all.nl>
On 06/02/18 13:14, Hans Verkuil wrote:
[...]
> The one thing that I worry about is if these structs are the same for
> 32 and 64 bit arm.
I see some enums and bools in there - in general the storage size of
those isn't even guaranteed to be consistent between different compiler
implementations on the same platform, let alone across multiple
platforms (especially WRT things like GCC's -fshort-enums).
In practice, under the standard ABIs for 32-bit and 64-bit Arm[1], I'd
expect basic types other than longs and pointers to be pretty much the
same; it's the imp-def C stuff I'd be a lot less confident about.
Robin.
[1]:http://infocenter.arm.com/help/topic/com.arm.doc.subset.swdev.abi/index.html
next prev parent reply other threads:[~2018-02-07 12:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 7:52 [PATCH v5 00/16] Rockchip ISP1 Driver Shunqian Zheng
2017-12-29 7:52 ` [PATCH v5 01/16] media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format Shunqian Zheng
2018-02-06 12:54 ` Hans Verkuil
2017-12-29 7:52 ` [PATCH v5 02/16] media: doc: add document for " Shunqian Zheng
2018-02-06 12:55 ` Hans Verkuil
2018-02-06 14:27 ` Hans Verkuil
[not found] ` <CAFLEztR1XyFMS_Gf-qT7vs9OHipeBfuXQ7mXJoCBDyBSvTWUag@mail.gmail.com>
2018-03-08 9:59 ` Jacob Chen
2017-12-29 7:52 ` [PATCH v5 03/16] media: rkisp1: Add user space ABI definitions Shunqian Zheng
2018-02-06 13:14 ` Hans Verkuil
2018-02-07 12:38 ` Robin Murphy [this message]
2018-02-07 12:00 ` Hans Verkuil
2018-02-07 16:31 ` Hans Verkuil
2018-03-08 10:00 ` Jacob Chen
2018-03-09 13:14 ` Hans Verkuil
2017-12-29 7:52 ` [PATCH v5 04/16] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver Shunqian Zheng
2018-02-06 13:19 ` Hans Verkuil
2018-02-06 13:21 ` Hans Verkuil
2018-02-08 9:54 ` Jacob Chen
2017-12-29 7:52 ` [PATCH v5 05/16] media: rkisp1: add Rockchip ISP1 subdev driver Shunqian Zheng
2017-12-29 12:45 ` Philippe Ombredanne
2018-02-06 13:27 ` Hans Verkuil
2017-12-29 7:52 ` [PATCH v5 06/16] media: rkisp1: add ISP1 statistics driver Shunqian Zheng
2018-02-06 13:31 ` Hans Verkuil
2017-12-29 7:52 ` [PATCH v5 07/16] media: rkisp1: add ISP1 params driver Shunqian Zheng
2018-02-06 13:39 ` Hans Verkuil
2017-12-29 7:52 ` [PATCH v5 08/16] media: rkisp1: add capture device driver Shunqian Zheng
2018-02-06 13:53 ` Hans Verkuil
2017-12-29 7:52 ` [PATCH v5 09/16] media: rkisp1: add rockchip isp1 core driver Shunqian Zheng
2018-02-06 13:56 ` Hans Verkuil
2017-12-29 7:52 ` [PATCH v5 10/16] dt-bindings: Document the Rockchip ISP1 bindings Shunqian Zheng
2017-12-29 7:52 ` [PATCH v5 11/16] dt-bindings: Document the Rockchip MIPI RX D-PHY bindings Shunqian Zheng
2017-12-29 7:52 ` [PATCH v5 12/16] ARM: dts: rockchip: add isp node for rk3288 Shunqian Zheng
2017-12-29 7:52 ` [PATCH v5 13/16] ARM: dts: rockchip: add rx0 mipi-phy " Shunqian Zheng
2017-12-29 7:52 ` [PATCH v5 14/16] arm64: dts: rockchip: add isp0 node for rk3399 Shunqian Zheng
2017-12-29 7:52 ` [PATCH v5 15/16] arm64: dts: rockchip: add rx0 mipi-phy " Shunqian Zheng
2017-12-29 7:52 ` [PATCH v5 16/16] MAINTAINERS: add entry for Rockchip ISP1 driver Shunqian Zheng
2018-02-06 14:10 ` [PATCH v5 00/16] Rockchip ISP1 Driver Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d29bc615-2359-86c6-db5a-27cc111bc275@arm.com \
--to=robin.murphy@arm.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=Luis.Oliveira@synopsys.com \
--cc=allon.huang@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.cai.linux@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=heiko@sntech.de \
--cc=hverkuil@xs4all.nl \
--cc=jacob2.chen@rock-chips.com \
--cc=jeffy.chen@rock-chips.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
--cc=zhengsq@rock-chips.com \
--cc=zyc@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).