From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 973BEC433E9 for ; Thu, 24 Dec 2020 14:22:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AA9E224DF for ; Thu, 24 Dec 2020 14:22:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727081AbgLXOV7 (ORCPT ); Thu, 24 Dec 2020 09:21:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726609AbgLXOV7 (ORCPT ); Thu, 24 Dec 2020 09:21:59 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7ABDC061794; Thu, 24 Dec 2020 06:21:18 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id t30so2336244wrb.0; Thu, 24 Dec 2020 06:21:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=290qlAj9/wIw73WZ0l4W99gBHafzKX3LexaIq9Kbj8U=; b=H9IK62WB6jMmUFDg7RSJNvniwFUqmjdFIKzyYfj+RwCDdYSPuSroL6eBRLv8eVZ1Cy laPMMShRTovyn+4hKMvHimz2EOcmiiM8wUEtoquUtc5qN9wwK7vhuFCtmolrJ84xCRnj Y56bXcM9MIdixqjr3UM8SM9DUt/Oibf+OmHSNY7bziTGwpEzqLTcisda3iqDWOMhlmqo nbQv7zyg+939bA6LNeL/WFyM3cFz8dIUaFsG/0x2v0tJXYR7kzkgaARUvEt5ga2+j6kn l+sjTN0wNnlsweBiL976XpqYLrRLfbxxLfwgXOUL+6yFVqplC36ydG4mBpxafmOwou6n vqog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=290qlAj9/wIw73WZ0l4W99gBHafzKX3LexaIq9Kbj8U=; b=JCK67CWqLksLE/S5Q000u8pogUxR2nWT1UTRvUksdYLUi6SBhOr/tUE7HzLNs6QRN/ a4PSCJ9D+LpqdQ0Vh90Xo+crEA/Uivqtmo8zkA8bPBfpICittyXJJNN+5duWs7H2/wOl aAfrV5FbKvHrQ28OZjjQ27rKScmDNbV2Dkxg0gZ2jOoGOWjghN4eLBSNmTiRZq3F8wTR 4I4Rlg+HdcDMyCkSFY8ld5/v6QfIFVgrOHutJMpbkyJJ0I3w+F2PWALlMC4kcsnIW+J7 Z2rXDXAs69glEiY4jpml+fv2N30pa52nXDKF+Wcw8GRbOHly/PsCjYvKi04na05UATds +j5A== X-Gm-Message-State: AOAM530py1N1e2kSgxl0xCCeo+JR3H/sndm6sxa4c+gkOcZpU7Qdszmj 0XN3bK1x7/+1zrqyMw5fGNY= X-Google-Smtp-Source: ABdhPJxwdOtDBlVfQIHVLEKHHof6seG/XVVw9+uHRHUBsSzYk42WKjnntQucO6c8Fh6rR3yG8w7FCQ== X-Received: by 2002:adf:fd05:: with SMTP id e5mr34705157wrr.225.1608819677538; Thu, 24 Dec 2020 06:21:17 -0800 (PST) Received: from [192.168.1.211] ([2.31.224.116]) by smtp.gmail.com with ESMTPSA id l20sm44277150wrh.82.2020.12.24.06.21.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Dec 2020 06:21:17 -0800 (PST) Subject: Re: [PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions To: Andy Shevchenko , Laurent Pinchart Cc: Linux Kernel Mailing List , ACPI Devel Maling List , Linux Media Mailing List , devel@acpica.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Yong Zhi , Sakari Ailus , Bingbu Cao , Tian Shu Qiu , Mauro Carvalho Chehab , Robert Moore , Erik Kaneda , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, Hans Verkuil , Marco Felsch , niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam , "Krogerus, Heikki" , Linus Walleij References: <20201224010907.263125-1-djrscally@gmail.com> <20201224010907.263125-8-djrscally@gmail.com> From: Daniel Scally Message-ID: Date: Thu, 24 Dec 2020 14:21:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Andy, Laurent > On Thu, Dec 24, 2020 at 2:55 PM Laurent Pinchart > wrote: >> On Thu, Dec 24, 2020 at 02:24:12PM +0200, Andy Shevchenko wrote: >>> On Thu, Dec 24, 2020 at 3:14 AM Daniel Scally wrote: > > ... > >>>> + if (!strncmp(to_swnode(port)->node->name, "port@", >>> >>> You may use here corresponding _FMT macro. >>> >>>> + FWNODE_GRAPH_PORT_NAME_PREFIX_LEN)) >>>> + return port; > > ... > >>>> + /* Ports have naming style "port@n", we need to select the n */ >>> >>>> + ret = kstrtou32(swnode->parent->node->name + FWNODE_GRAPH_PORT_NAME_PREFIX_LEN, >>> >>> Maybe a temporary variable? >>> >>> unsigned int prefix_len = FWNODE_GRAPH_PORT_NAME_PREFIX_LEN; >>> ... >>> ret = kstrtou32(swnode->parent->node->name + prefix_len, >> >> Honestly I'm wondering if those macros don't hinder readability. I'd >> rather write >> >> + strlen("port@") > > Works for me, since the compiler optimizes this away to be a plain constant. Well, how about instead of the LEN macro, we have: #define FWNODE_GRAPH_PORT_NAME_PREFIX "port@" #define FWNODE_GRAPH_PORT_NAME_FMT FWNODE_GRAPH_PORT_NAME_PREFIX "%u" And then it's still maintainable in one place but (I think) slightly less clunky, since we can do strlen(FWNODE_GRAPH_PORT_NAME_PREFIX) Or we can do strlen("port@"), I'm good either way :)