From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C406C4360C for ; Fri, 27 Sep 2019 09:09:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F9992146E for ; Fri, 27 Sep 2019 09:09:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726179AbfI0JJV (ORCPT ); Fri, 27 Sep 2019 05:09:21 -0400 Received: from lb3-smtp-cloud7.xs4all.net ([194.109.24.31]:51155 "EHLO lb3-smtp-cloud7.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbfI0JJU (ORCPT ); Fri, 27 Sep 2019 05:09:20 -0400 Received: from [IPv6:2001:420:44c1:2577:2521:77be:ff76:8085] ([IPv6:2001:420:44c1:2577:2521:77be:ff76:8085]) by smtp-cloud7.xs4all.net with ESMTPA id DmFWiKcBR9D4hDmFZiBCrX; Fri, 27 Sep 2019 11:09:17 +0200 Subject: Re: [PATCH v10 01/14] dt-bindings: connector: analog: add sdtv standards property To: Marco Felsch , mchehab@kernel.org, sakari.ailus@linux.intel.com, hans.verkuil@cisco.com, jacopo+renesas@jmondi.org, robh+dt@kernel.org, laurent.pinchart@ideasonboard.com Cc: devicetree@vger.kernel.org, kernel@pengutronix.de, linux-media@vger.kernel.org, Rob Herring References: <20190830101646.6530-1-m.felsch@pengutronix.de> <20190830101646.6530-2-m.felsch@pengutronix.de> From: Hans Verkuil Message-ID: Date: Fri, 27 Sep 2019 11:09:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190830101646.6530-2-m.felsch@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfFZlSVHEuT2hNeFvy1zNPjhpkyI1ZZWVWeoieQ2NmpXNM+uHCRm4ml3JAk0A0atfwfovQ0EtT4+lk3DhYStb2Z46VofbNATnqIymfQp2VmSVzTm2iicW 4EZYX/Emk6UqvOauSX2kxPGAVR/nSESoLWR9uYAUtaejvsZmtIISDRmW/DvOdgpN7pm2AvtoQfbpgrSMDXuAmYNdfNFBmMIlJ7kLeIi6i4lVjktx9WMv0/Lm 3DxkdEk6tNb9Vu9Ix0Wvyus5UHcFhkqx+LneHKrmleSl3OB8urNXxe8PGsLKYr4TE9tZJ6hIf27Ho6DHrfcwlyZIYyVhJkQbsQ3BgqNoVQkHwb6LD/Ytx9DD 2gVtnCe0ANiPjtzHgf6++K35rrUcgy5JaZugSkTR4zM0n6U8rbTma6Bn2j7xPvF9gnLXMqFn7Njh6NGpeN5gZ8irER8Z0puF4nzte3nYKMdubAKJ0cs29YFg BA5nZzgefDJGROU5Y0a4ZlVw58QKPESya5VzLmnTL42EaYqRlVCxlJt+xgSu+pS7btROGYju3JMxyp5RDhUhV1rfT9r3ZEWkTz4iRiapVyOnMlrSJbry4yAS t/OhehR+QAMu+XxjrU6PEuRoUYtZZOYvTgVQVQsP/lsunq+XNQfLeGjfXlNOI9qH3Z0= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Marco, On 8/30/19 12:16 PM, Marco Felsch wrote: > Some connectors no matter if in- or output supports only a limited > range of sdtv standards. It doesn't matter if the hardware behind that > connector supports more than the listed formats since the users are > restriced by a label e.g. to plug only a camera into this connector > which uses the PAL format. > > This patch adds the capability to describe such limitation within the > firmware. There are no format restrictions if the property isn't > present, so it's completely backward compatible. I got this warnings: WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.txt I do think it makes sense to split this up into three patches: first adding the sdtv-standards.h, then the update to analog-tv-connector.txt and finally the videodev.h patch. Regards, Hans > > Signed-off-by: Marco Felsch > Reviewed-by: Rob Herring > --- > [1] https://patchwork.kernel.org/cover/10794703/ > > v10: > - fix typo within comment s/TV_STD_*/SDTV_STD_*/ > > v8: > Hi Rob, > > I dropped your r b tag becuase of the changes I made in this version. > Please can you have look on it again? Luckily this would be the last > time ;-) > > - move definition to include/dt-bindings/display > - rename tvnorms.h to sdtv-standards.h > - TVORMS_* -> SDTV_STD_* > - add sync comments > - adapt commit message > - fix bindings documentation > > v7: > I kept Robs r b tag because I only changed the example and extended > TVNORM_* macros. > > - fix some style issues > - add TVNORM_NTSC, TVNORM_525_60 and TVNORM_625_50 > > v6: > - tvnorms.h: use tabs instead of spaces > - tvnorms.h: add TVNORM_PAL and TVNORM_SECAM > - tvnorms.h: drop rarely used TVNORM_ATSC_* norms > > v2-v4: > - nothing since the patch was squashed from series [1] into this > series. > > .../display/connector/analog-tv-connector.txt | 6 ++ > include/dt-bindings/display/sdtv-standards.h | 76 +++++++++++++++++++ > include/uapi/linux/videodev2.h | 4 + > 3 files changed, 86 insertions(+) > create mode 100644 include/dt-bindings/display/sdtv-standards.h > > diff --git a/Documentation/devicetree/bindings/display/connector/analog-tv-connector.txt b/Documentation/devicetree/bindings/display/connector/analog-tv-connector.txt > index 0c0970c210ab..883bcb2604c7 100644 > --- a/Documentation/devicetree/bindings/display/connector/analog-tv-connector.txt > +++ b/Documentation/devicetree/bindings/display/connector/analog-tv-connector.txt > @@ -6,16 +6,22 @@ Required properties: > > Optional properties: > - label: a symbolic name for the connector > +- sdtv-standards: limit the supported TV standards on a connector to the given > + ones. If not specified all TV standards are allowed. > + Possible TV standards are defined in > + include/dt-bindings/display/sdtv-standards.h. > > Required nodes: > - Video port for TV input > > Example > ------- > +#include > > tv: connector { > compatible = "composite-video-connector"; > label = "tv"; > + sdtv-standards = <(SDTV_STD_PAL | SDTV_STD_NTSC)>; > > port { > tv_connector_in: endpoint { > diff --git a/include/dt-bindings/display/sdtv-standards.h b/include/dt-bindings/display/sdtv-standards.h > new file mode 100644 > index 000000000000..fbc1a3db2ea7 > --- /dev/null > +++ b/include/dt-bindings/display/sdtv-standards.h > @@ -0,0 +1,76 @@ > +/* SPDX-License-Identifier: GPL-2.0-only or X11 */ > +/* > + * Copyright 2019 Pengutronix, Marco Felsch > + */ > + > +#ifndef _DT_BINDINGS_DISPLAY_SDTV_STDS_H > +#define _DT_BINDINGS_DISPLAY_SDTV_STDS_H > + > +/* > + * Attention: Keep the SDTV_STD_* bit definitions in sync with > + * include/uapi/linux/videodev2.h V4L2_STD_* bit definitions. > + */ > +/* One bit for each standard */ > +#define SDTV_STD_PAL_B 0x00000001 > +#define SDTV_STD_PAL_B1 0x00000002 > +#define SDTV_STD_PAL_G 0x00000004 > +#define SDTV_STD_PAL_H 0x00000008 > +#define SDTV_STD_PAL_I 0x00000010 > +#define SDTV_STD_PAL_D 0x00000020 > +#define SDTV_STD_PAL_D1 0x00000040 > +#define SDTV_STD_PAL_K 0x00000080 > + > +#define SDTV_STD_PAL (SDTV_STD_PAL_B | \ > + SDTV_STD_PAL_B1 | \ > + SDTV_STD_PAL_G | \ > + SDTV_STD_PAL_H | \ > + SDTV_STD_PAL_I | \ > + SDTV_STD_PAL_D | \ > + SDTV_STD_PAL_D1 | \ > + SDTV_STD_PAL_K) > + > +#define SDTV_STD_PAL_M 0x00000100 > +#define SDTV_STD_PAL_N 0x00000200 > +#define SDTV_STD_PAL_Nc 0x00000400 > +#define SDTV_STD_PAL_60 0x00000800 > + > +#define SDTV_STD_NTSC_M 0x00001000 /* BTSC */ > +#define SDTV_STD_NTSC_M_JP 0x00002000 /* EIA-J */ > +#define SDTV_STD_NTSC_443 0x00004000 > +#define SDTV_STD_NTSC_M_KR 0x00008000 /* FM A2 */ > + > +#define SDTV_STD_NTSC (SDTV_STD_NTSC_M | \ > + SDTV_STD_NTSC_M_JP | \ > + SDTV_STD_NTSC_M_KR) > + > +#define SDTV_STD_SECAM_B 0x00010000 > +#define SDTV_STD_SECAM_D 0x00020000 > +#define SDTV_STD_SECAM_G 0x00040000 > +#define SDTV_STD_SECAM_H 0x00080000 > +#define SDTV_STD_SECAM_K 0x00100000 > +#define SDTV_STD_SECAM_K1 0x00200000 > +#define SDTV_STD_SECAM_L 0x00400000 > +#define SDTV_STD_SECAM_LC 0x00800000 > + > +#define SDTV_STD_SECAM (SDTV_STD_SECAM_B | \ > + SDTV_STD_SECAM_D | \ > + SDTV_STD_SECAM_G | \ > + SDTV_STD_SECAM_H | \ > + SDTV_STD_SECAM_K | \ > + SDTV_STD_SECAM_K1 | \ > + SDTV_STD_SECAM_L | \ > + SDTV_STD_SECAM_LC) > + > +/* Standards for Countries with 60Hz Line frequency */ > +#define SDTV_STD_525_60 (SDTV_STD_PAL_M | \ > + SDTV_STD_PAL_60 | \ > + SDTV_STD_NTSC | \ > + SDTV_STD_NTSC_443) > + > +/* Standards for Countries with 50Hz Line frequency */ > +#define SDTV_STD_625_50 (SDTV_STD_PAL | \ > + SDTV_STD_PAL_N | \ > + SDTV_STD_PAL_Nc | \ > + SDTV_STD_SECAM) > + > +#endif /* _DT_BINDINGS_DISPLAY_SDTV_STDS_H */ > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 530638dffd93..bc7acade02a0 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -1208,6 +1208,10 @@ struct v4l2_selection { > > typedef __u64 v4l2_std_id; > > +/* > + * Attention: Keep the V4L2_STD_* bit definitions in sync with > + * include/dt-bindings/display/sdtv-standards.h SDTV_STD_* bit definitions. > + */ > /* one bit for each */ > #define V4L2_STD_PAL_B ((v4l2_std_id)0x00000001) > #define V4L2_STD_PAL_B1 ((v4l2_std_id)0x00000002) >