From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-f44.google.com ([74.125.82.44]:42272 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756387AbeATPtq (ORCPT ); Sat, 20 Jan 2018 10:49:46 -0500 Received: by mail-wm0-f44.google.com with SMTP id b141so8711492wme.1 for ; Sat, 20 Jan 2018 07:49:45 -0800 (PST) Subject: Re: SAA716x DVB driver To: Jemma Denson , Soeren Moch , Mauro Carvalho Chehab , Luis Alves , Linux Media Mailing List References: <50e5ba3c-4e32-f2e4-7844-150eefdf71b5@web.de> <20170827073040.6e96d79a@vento.lan> <20170909181123.392cfbb0@vento.lan> <20170916125042.78c4abad@recife.lan> <7c17c0a1-1c98-1272-8430-4a194b658872@gmail.com> <20171127092408.20de0fe0@vento.lan> <20171202174922.34a6f9b9@vento.lan> <335e279e-d498-135f-8077-770c77cf353b@gmail.com> <5070ebf3-79a9-571e-d56c-cee41b51f191@gmail.com> From: =?UTF-8?Q?Tycho_L=c3=bcrsen?= Message-ID: Date: Sat, 20 Jan 2018 16:49:42 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-media-owner@vger.kernel.org List-ID: Hi Jemma, Op 19-01-18 om 16:11 schreef Jemma Denson: > Hi Tycho, > > On 19/01/18 13:59, Tycho Lürsen wrote: >> Hi Jemma, >> >> I'm with you: let's get merged at least something! >> >> Did you find a maintainer for this driver? >> I can do simple stuff like in my fork of Soeren Moch's repo, but thats >> where it ends. I dont have the knowledge needed to maintain a driver. > Not yet, but I can't really say I've been looking - unfortunately real > life got in the way of anything over christmas. I'm not sure I do > either, but it really depends on what's required. From what I can see > from maintaining another driver then as long as the driver is working > there's not a whole lot to do. Right, but we still need a maintainer. Are you capable/willing to volunteer for the job? > >> I think that your proposal to use a stripped version of Luis Alves >> repo is a no go, since it contains a couple of demod/tuner drivers >> that are not upstreamed yet. That complicates the upstreaming process >> too much, I think. > Oh, I would have stripped it *right* down and removed every card except > my TBS6280. The end result would probably be pretty close to Soeren's at > that point anyway, so I was starting to think like what you've done and > base it on that instead. If you want, I can strip the driver down a lot more and ad back the drivers you need. Just tell me what it is you need. > >> I used a stripped version of Soeren Moch's repo to prove its stability >> instead, adding the drivers I need so I can test it. You can see what >> I did at : >> https://github.com/bas-t/linux-saa716x/commits/for-media-stripped >> >> This has been tested with linux 4.9.77, 4.14.14 and 4.15-rc8. >> Works like a charm for me. >> > Looks like a good start, I'd be tempted to remove all the other cards > though unless you have them available to test with. Keeps the submission > simpler and less to worry about, they can be added back in later if > someone has an itch to scratch (and hardware to test with!). Isn't that a bit drastic? I mean: those few drivers have been there for ages, and I can't recall anyone complaining about them in a serious way. > > I do have a few other tbs 716x cards available here at work so might be > able to test some others out, but we're a bit busy at the moment so > would have to be on my own time and there's not much of that available > at the moment either :( As I said: give me the numbers of your tbs cards and I will add support for them (if they are supported by Luis Alves repo). That way you are able to test the stability of the saa716x driver in it's present state. > > > Jemma. Tycho.