From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 08/15] media: qcom: camss: Untangle if/else spaghetti in camss
Date: Mon, 4 Sep 2023 13:24:14 +0100 [thread overview]
Message-ID: <d7745ece-bea1-f8f9-a1d2-0f01aa221ade@linaro.org> (raw)
In-Reply-To: <20230828185110.GN14596@pendragon.ideasonboard.com>
On 28/08/2023 19:51, Laurent Pinchart wrote:
>> +++ b/drivers/media/platform/qcom/camss/camss-csid.c
>> @@ -592,15 +592,19 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid,
>> csid->camss = camss;
>> csid->id = id;
>>
>> - if (camss->res->version == CAMSS_8x16) {
>> + switch (camss->res->version) {
>> + case CAMSS_8x16:
>> csid->ops = &csid_ops_4_1;
>> - } else if (camss->res->version == CAMSS_8x96 ||
>> - camss->res->version == CAMSS_660) {
>> + break;
>> + case CAMSS_8x96:
>> + case CAMSS_660:
>> csid->ops = &csid_ops_4_7;
>> - } else if (camss->res->version == CAMSS_845 ||
>> - camss->res->version == CAMSS_8250) {
>> + break;
>> + case CAMSS_845:
>> + case CAMSS_8250:
>> csid->ops = &csid_ops_gen2;
>> - } else {
>> + break;
>> + default:
>> return -EINVAL;
> This should never happen, as adding support for a new SoC should come
> with an update for all the applicable switch/case statements. It's
> useful to let the compiler complain if someone forgets to do so, but
> with a default case, you will only see the issue at runtime. Could it be
> caught at compile time ?
>
This can be done in fact.
https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wswitch_002denum-303
#include <stdio.h>
#include <stdlib.h>
#include <time.h>
typedef enum {
MO = 0,
LARRY,
CURLY,
BINGO,
}my_type;
int main (int argc, char *argv[])
{
my_type x;
time_t t;
srand((unsigned) time(&t));
x = rand() % BINGO;
switch(x) {
case MO:
printf("mo\n");
break;
case LARRY:
printf("larry\n");
break;
default:
printf("blargh\n");
break;
}
return 0;
}
gcc -o test test.c -Wswitch-enum
test.c: In function ‘main’:
test.c:38:9: warning: enumeration value ‘CURLY’ not handled in switch
[-Wswitch-enum]
38 | switch(x) {
| ^~~~~~
It looks like we only enable that switch for tools though
grep -r "Wswitch-enum" *
tools/scripts/Makefile.include:EXTRA_WARNINGS += -Wswitch-enum
tools/bpf/bpftool/Makefile:CFLAGS += $(filter-out -Wswitch-enum
-Wnested-externs,$(EXTRA_WARNINGS))
I'll still implement the code though, since if we do introduce the
switch for the kernel it would be caught.
---
bod
next prev parent reply other threads:[~2023-09-04 12:24 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 10:44 [PATCH v3 00/15] media: qcom: camss: Add parameter passing to remove several outstanding bugs Bryan O'Donoghue
2023-08-23 10:44 ` [PATCH v3 01/15] media: qcom: camss: Amalgamate struct resource with struct resource_ispif Bryan O'Donoghue
2023-08-26 9:55 ` Konrad Dybcio
2023-08-28 17:30 ` Laurent Pinchart
2023-08-23 10:44 ` [PATCH v3 02/15] media: qcom: camss: Start to move to module compat matched resources Bryan O'Donoghue
2023-08-28 17:33 ` Laurent Pinchart
2023-08-23 10:44 ` [PATCH v3 03/15] media: qcom: camss: Pass icc bandwidth table as a platform parameter Bryan O'Donoghue
2023-08-28 17:35 ` Laurent Pinchart
2023-08-23 10:44 ` [PATCH v3 04/15] media: qcom: camss: Pass remainder of variables as resources Bryan O'Donoghue
2023-08-26 9:57 ` Konrad Dybcio
2023-08-28 17:51 ` Laurent Pinchart
2023-08-23 10:44 ` [PATCH v3 05/15] media: qcom: camss: Pass line_num from compat resources Bryan O'Donoghue
2023-08-28 18:36 ` Laurent Pinchart
2023-08-28 19:31 ` Bryan O'Donoghue
2023-08-23 10:44 ` [PATCH v3 06/15] media: qcom: camss: Assign the correct number of RDIs per VFE Bryan O'Donoghue
2023-08-28 18:43 ` Laurent Pinchart
2023-08-23 10:44 ` [PATCH v3 07/15] media: qcom: camss: Capture VFE CSID dependency in a helper function Bryan O'Donoghue
2023-08-26 10:02 ` Konrad Dybcio
2023-08-26 12:01 ` Bryan O'Donoghue
2023-08-26 12:04 ` Konrad Dybcio
2023-08-26 12:12 ` Bryan O'Donoghue
2023-08-26 12:13 ` Konrad Dybcio
2023-08-26 12:16 ` Bryan O'Donoghue
2023-08-28 18:47 ` Laurent Pinchart
2023-08-28 19:37 ` Bryan O'Donoghue
2023-08-28 19:40 ` Laurent Pinchart
2023-08-28 19:41 ` Bryan O'Donoghue
2023-09-04 10:15 ` Bryan O'Donoghue
2023-08-23 10:44 ` [PATCH v3 08/15] media: qcom: camss: Untangle if/else spaghetti in camss Bryan O'Donoghue
2023-08-26 10:03 ` Konrad Dybcio
2023-08-28 18:51 ` Laurent Pinchart
2023-08-28 19:43 ` Bryan O'Donoghue
2023-09-04 12:24 ` Bryan O'Donoghue [this message]
2023-08-23 10:44 ` [PATCH v3 09/15] media: qcom: camss: Improve error printout on icc_get fail Bryan O'Donoghue
2023-08-26 10:05 ` Konrad Dybcio
2023-08-26 12:01 ` Bryan O'Donoghue
2023-08-23 10:44 ` [PATCH v3 10/15] media: qcom: camss: Allow clocks vfeN vfe_liteN or vfe_lite Bryan O'Donoghue
2023-08-26 10:08 ` Konrad Dybcio
2023-08-26 12:05 ` Bryan O'Donoghue
2023-08-28 18:55 ` Laurent Pinchart
2023-08-23 10:44 ` [PATCH v3 11/15] media: qcom: camss: Functionally decompose CSIPHY clock lookups Bryan O'Donoghue
2023-08-26 10:12 ` Konrad Dybcio
2023-08-26 12:07 ` Bryan O'Donoghue
2023-08-26 12:11 ` Konrad Dybcio
2023-08-26 12:14 ` Bryan O'Donoghue
2023-08-26 12:48 ` Konrad Dybcio
2023-08-28 18:59 ` Laurent Pinchart
2023-08-23 10:44 ` [PATCH v3 12/15] media: qcom: camss: Fix support for setting CSIPHY clock name csiphyX Bryan O'Donoghue
2023-08-26 10:13 ` Konrad Dybcio
2023-08-26 12:08 ` Bryan O'Donoghue
2023-08-26 12:12 ` Konrad Dybcio
2023-09-04 19:11 ` Bryan O'Donoghue
2023-09-04 19:32 ` Konrad Dybcio
2023-09-04 19:33 ` Bryan O'Donoghue
2023-08-23 10:44 ` [PATCH v3 13/15] media: qcom: camss: Support RDI3 for VFE 17x Bryan O'Donoghue
2023-08-28 19:03 ` Laurent Pinchart
2023-08-23 10:44 ` [PATCH v3 14/15] media: qcom: camss: Convert vfe_disable() from int to void Bryan O'Donoghue
2023-08-26 10:16 ` Konrad Dybcio
2023-08-23 10:44 ` [PATCH v3 15/15] media: qcom: camss: Comment CSID dt_id field Bryan O'Donoghue
2023-08-26 10:18 ` Konrad Dybcio
2023-08-28 15:34 ` Bryan O'Donoghue
2023-08-28 15:38 ` Konrad Dybcio
2023-08-28 15:43 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7745ece-bea1-f8f9-a1d2-0f01aa221ade@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andrey.konovalov@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=konrad.dybcio@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).