From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C73B3C433DB for ; Tue, 12 Jan 2021 12:02:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89CA5222B3 for ; Tue, 12 Jan 2021 12:02:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731095AbhALMBv (ORCPT ); Tue, 12 Jan 2021 07:01:51 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:44082 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbhALMBu (ORCPT ); Tue, 12 Jan 2021 07:01:50 -0500 Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CC2EE3E; Tue, 12 Jan 2021 13:01:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1610452869; bh=uyM/JyobNkPdQBWX58vhj1WBbJr0HtxDUluUYWK3K1Y=; h=Subject:To:Cc:References:Reply-To:From:Date:In-Reply-To:From; b=QHSbh5Hz4m0REscHWNxyZXlcfu//uPNU0Kj6RNmae/z6Nv1/kPFlR91TM6d9akXu/ ABxcvBWY9U7Zdof5/JOIdreqVL5NnJroR90OqhoovHrvBGaWtMuJ2RmIUJUTzsZ04N CfKpG9xBX6K6EbdfuybSjkPoYmo6raAD/0xHqL0Y= Subject: Re: [PATCH 2/9] media: mtk-mdp: Do not zero reserved fields To: Ricardo Ribalda , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Matthias Brugger References: <20210111145445.28854-1-ribalda@chromium.org> <20210111145445.28854-3-ribalda@chromium.org> Reply-To: kieran.bingham+renesas@ideasonboard.com From: Kieran Bingham Organization: Ideas on Board Message-ID: Date: Tue, 12 Jan 2021 12:01:05 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210111145445.28854-3-ribalda@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Ricardo, On 11/01/2021 14:54, Ricardo Ribalda wrote: > Core code already clears reserved fields of struct > v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero > v4l2_plane_pix_format reserved fields"). > > Cc: Matthias Brugger > Signed-off-by: Ricardo Ribalda Reviewed-by: Kieran Bingham > --- > drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c b/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c > index 724c7333b6e5..ace4528cdc5e 100644 > --- a/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c > +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c > @@ -199,7 +199,6 @@ static const struct mtk_mdp_fmt *mtk_mdp_try_fmt_mplane(struct mtk_mdp_ctx *ctx, > pix_mp->ycbcr_enc = ctx->ycbcr_enc; > pix_mp->quantization = ctx->quant; > } > - memset(pix_mp->reserved, 0, sizeof(pix_mp->reserved)); > > max_w = variant->pix_max->target_rot_dis_w; > max_h = variant->pix_max->target_rot_dis_h; > @@ -247,8 +246,6 @@ static const struct mtk_mdp_fmt *mtk_mdp_try_fmt_mplane(struct mtk_mdp_ctx *ctx, > pix_mp->plane_fmt[i].bytesperline = bpl; > if (pix_mp->plane_fmt[i].sizeimage < sizeimage) > pix_mp->plane_fmt[i].sizeimage = sizeimage; > - memset(pix_mp->plane_fmt[i].reserved, 0, > - sizeof(pix_mp->plane_fmt[i].reserved)); > mtk_mdp_dbg(2, "[%d] p%d, bpl:%d, sizeimage:%u (%u)", ctx->id, > i, bpl, pix_mp->plane_fmt[i].sizeimage, sizeimage); > } >