From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Ricardo Ribalda <ribalda@chromium.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH 3/9] media: mtk-vcodec: Do not zero reserved fields
Date: Tue, 12 Jan 2021 12:09:48 +0000 [thread overview]
Message-ID: <d9a74387-fc20-5364-1903-bdcd97331bc7@ideasonboard.com> (raw)
In-Reply-To: <20210111145445.28854-4-ribalda@chromium.org>
Hi Ricardo,
On 11/01/2021 14:54, Ricardo Ribalda wrote:
> Core code already clears reserved fields of struct
> v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero
> v4l2_plane_pix_format reserved fields").
>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
There's also another memset.*reserved occurring in
platform/mtk-vcodec/mtk_vcodec_enc.c: vidioc_enum_fmt()
While v4l2-core/v4l2-ioctl.c has:
> static int v4l_enum_fmt(const struct v4l2_ioctl_ops *ops,
> struct file *file, void *fh, void *arg)
> {
> struct video_device *vdev = video_devdata(file);
> struct v4l2_fmtdesc *p = arg;
> int ret = check_fmt(file, p->type);
> u32 mbus_code;
> u32 cap_mask;
>
> if (ret)
> return ret;
> ret = -EINVAL;
>
> if (!(vdev->device_caps & V4L2_CAP_IO_MC))
> p->mbus_code = 0;
>
> mbus_code = p->mbus_code;
> CLEAR_AFTER_FIELD(p, type);
So would that mean ^^^ should also be sufficient to remove the need for
that memset?
With that fixed or resolved:
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 5 -----
> drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 8 --------
> 2 files changed, 13 deletions(-)
>
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
> index c768a587a944..d746c41ea805 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
> @@ -715,12 +715,7 @@ static int vidioc_try_fmt(struct v4l2_format *f,
> }
> }
>
> - for (i = 0; i < pix_fmt_mp->num_planes; i++)
> - memset(&(pix_fmt_mp->plane_fmt[i].reserved[0]), 0x0,
> - sizeof(pix_fmt_mp->plane_fmt[0].reserved));
> -
> pix_fmt_mp->flags = 0;
> - memset(&pix_fmt_mp->reserved, 0x0, sizeof(pix_fmt_mp->reserved));
> return 0;
> }
>
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c
> index 21de1431cfcb..db1f62cc38b3 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c
> @@ -320,13 +320,7 @@ static int vidioc_try_fmt(struct v4l2_format *f,
> }
> }
>
> - for (i = 0; i < pix_fmt_mp->num_planes; i++)
> - memset(&(pix_fmt_mp->plane_fmt[i].reserved[0]), 0x0,
> - sizeof(pix_fmt_mp->plane_fmt[0].reserved));
> -
> pix_fmt_mp->flags = 0;
> - memset(&pix_fmt_mp->reserved, 0x0,
> - sizeof(pix_fmt_mp->reserved));
>
> return 0;
> }
> @@ -532,8 +526,6 @@ static int vidioc_venc_g_fmt(struct file *file, void *priv,
> for (i = 0; i < pix->num_planes; i++) {
> pix->plane_fmt[i].bytesperline = q_data->bytesperline[i];
> pix->plane_fmt[i].sizeimage = q_data->sizeimage[i];
> - memset(&(pix->plane_fmt[i].reserved[0]), 0x0,
> - sizeof(pix->plane_fmt[i].reserved));
> }
>
> pix->flags = 0;
>
next prev parent reply other threads:[~2021-01-12 12:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 14:54 [PATCH 1/9] media: ipu3-cio2: Do not zero reserved fields Ricardo Ribalda
2021-01-11 14:54 ` [PATCH] media: staging/intel-ipu3 : " Ricardo Ribalda
2021-01-12 11:59 ` Kieran Bingham
2021-01-12 12:14 ` Ricardo Ribalda
2021-01-11 14:54 ` [PATCH 2/9] media: mtk-mdp: " Ricardo Ribalda
2021-01-12 12:01 ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 3/9] media: mtk-vcodec: " Ricardo Ribalda
2021-01-12 12:09 ` Kieran Bingham [this message]
2021-01-11 14:54 ` [PATCH 4/9] media: fdp1: " Ricardo Ribalda
2021-01-12 10:58 ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 5/9] media: jpu: " Ricardo Ribalda
2021-01-12 11:07 ` Kieran Bingham
2021-01-21 9:53 ` Hans Verkuil
2021-01-11 14:54 ` [PATCH 6/9] media: sum4i-csi: " Ricardo Ribalda
2021-01-11 18:11 ` Ezequiel Garcia
2021-01-12 11:10 ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 7/9] media: ti-vpe: " Ricardo Ribalda
2021-01-12 11:12 ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 8/9] media: vicodec: " Ricardo Ribalda
2021-01-12 11:44 ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 9/9] media: staging/intel-ipu3 : " Ricardo Ribalda
2021-01-12 11:55 ` Kieran Bingham
2021-01-12 11:58 ` [PATCH 1/9] media: ipu3-cio2: " Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9a74387-fc20-5364-1903-bdcd97331bc7@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=ribalda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).