From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92834C4338F for ; Tue, 27 Jul 2021 12:53:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E30B61A7F for ; Tue, 27 Jul 2021 12:53:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232110AbhG0MxT (ORCPT ); Tue, 27 Jul 2021 08:53:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231840AbhG0MxT (ORCPT ); Tue, 27 Jul 2021 08:53:19 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B85EC061757 for ; Tue, 27 Jul 2021 05:53:19 -0700 (PDT) Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6DF53EE; Tue, 27 Jul 2021 14:53:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1627390397; bh=B9kJIqXI9ElhvHQoNmIBvrpGLT27g5TGGKvy5gQNTSQ=; h=To:Cc:References:From:Subject:Date:In-Reply-To:From; b=DACAQyhSdHzaZ7tMhhiGQvkfiAmTFjcgN72Pbzo+sdE3lA8CpgNpB43A7QkYocemd Y3N/dWrMQFZFj5n1ZxaAzf8G1Ydb3a2nKTpBbQrIgcOkly1PLLQcD/rRZcsgQG/8LT JNKMhoMd+A6EPeuXPcr75pg8Kl1z1xz+RS8eKzIA= To: Sakari Ailus , linux-media@vger.kernel.org Cc: =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Kieran Bingham , Andrey Konovalov , Jacopo Mondi References: <20210624084046.13136-1-sakari.ailus@linux.intel.com> <20210624084046.13136-6-sakari.ailus@linux.intel.com> From: Kieran Bingham Subject: Re: [PATCH v3 5/6] media: rcar-vin: Remove explicit device availability check Message-ID: Date: Tue, 27 Jul 2021 13:53:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210624084046.13136-6-sakari.ailus@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 24/06/2021 09:40, Sakari Ailus wrote: > From: Niklas Söderlund > > The fwnode is retrieved using fwnode_graph_get_endpoint_by_id() without > the FWNODE_GRAPH_DEVICE_DISABLED flag set. So there is no need to > explicitly check if the fwnode is available as it always will be when > the check is performed, remove it. Interestingly I don't see any users of FWNODE_GRAPH_DEVICE_DISABLED ... I guess it's just there in case someone does one day need it. Reviewed-by: Kieran Bingham > Signed-off-by: Niklas Söderlund > Signed-off-by: Sakari Ailus > Reviewed-by: Jacopo Mondi > --- > drivers/media/platform/rcar-vin/rcar-core.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c > index 3b7052ff7117..a24aeda37e74 100644 > --- a/drivers/media/platform/rcar-vin/rcar-core.c > +++ b/drivers/media/platform/rcar-vin/rcar-core.c > @@ -834,13 +834,6 @@ static int rvin_mc_parse_of(struct rvin_dev *vin, unsigned int id) > goto out; > } > > - if (!of_device_is_available(to_of_node(fwnode))) { > - vin_dbg(vin, "OF device %pOF disabled, ignoring\n", > - to_of_node(fwnode)); > - ret = -ENOTCONN; > - goto out; > - } > - > asd = v4l2_async_nf_add_fwnode(&vin->group->notifier, fwnode, > struct v4l2_async_subdev); > if (IS_ERR(asd)) { >