From: Steve Longerbeam <slongerbeam@gmail.com>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"open list:MEDIA DRIVERS FOR RENESAS - VIN"
<linux-renesas-soc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2] media: rcar-vin: Allow independent VIN link enablement
Date: Wed, 9 Jan 2019 17:19:37 -0800 [thread overview]
Message-ID: <da87789d-73e8-663c-a25f-d75e4361ade3@gmail.com> (raw)
In-Reply-To: <20190109224039.GD24252@bigcity.dyn.berto.se>
On 1/9/19 2:40 PM, Niklas Söderlund wrote:
> Hi Steve,
>
> Thanks for your patch, I think it looks good.
Thanks for the Ack! I'm not real familiar with the RFC patch process.
Should this be submitted again with RFC stripped from the subject line?
Steve
> On 2019-01-06 13:20:18 -0800, Steve Longerbeam wrote:
>> There is a block of code in rvin_group_link_notify() that loops through
>> all entities in the media graph, and prevents enabling a link to a VIN
>> node if any entity is in use. This prevents enabling a VIN link even if
>> there is an in-use entity somewhere in the graph that is independent of
>> the link's pipeline.
>>
>> For example, the code will prevent enabling a link from the first
>> rcar-csi2 receiver to a VIN node even if there is an enabled link
>> somewhere far upstream on the second independent rcar-csi2 receiver
>> pipeline.
>>
>> If this code is meant to prevent modifying a link if any entity in the
>> graph is actively involved in streaming (because modifying the CHSEL
>> register fields can disrupt any/all running streams), then the entities
>> stream counts should be checked rather than the use counts.
>>
>> (There is already such a check in __media_entity_setup_link() that verifies
>> the stream_count of the link's source and sink entities are both zero,
>> but that is insufficient, since there should be no running streams in
>> the entire graph).
>>
>> Modify the media_device_for_each_entity() loop to check the entity
>> stream_count instead of the use_count, and elaborate on the comment.
>> VIN node links can now be enabled even if there are other independent
>> in-use entities that are not streaming.
>>
>> Fixes: c0cc5aef31 ("media: rcar-vin: add link notify for Gen3")
>>
>> Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
>> ---
>> Changes in v2:
>> - bring back the media_device_for_each_entity() loop but check the
>> stream_count not the use_count.
>> ---
>> drivers/media/platform/rcar-vin/rcar-core.c | 8 ++++++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c
>> index f0719ce24b97..6dd6b11c1b2b 100644
>> --- a/drivers/media/platform/rcar-vin/rcar-core.c
>> +++ b/drivers/media/platform/rcar-vin/rcar-core.c
>> @@ -131,9 +131,13 @@ static int rvin_group_link_notify(struct media_link *link, u32 flags,
>> !is_media_entity_v4l2_video_device(link->sink->entity))
>> return 0;
>>
>> - /* If any entity is in use don't allow link changes. */
>> + /*
>> + * Don't allow link changes if any entity in the graph is
>> + * streaming, because modifying the CHSEL register fields
>> + * can disrupt running streams.
>> + */
>> media_device_for_each_entity(entity, &group->mdev)
>> - if (entity->use_count)
>> + if (entity->stream_count)
>> return -EBUSY;
>>
>> mutex_lock(&group->lock);
>> --
>> 2.17.1
>>
next prev parent reply other threads:[~2019-01-10 1:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-06 21:20 [RFC PATCH v2] media: rcar-vin: Allow independent VIN link enablement Steve Longerbeam
2019-01-09 22:40 ` Niklas Söderlund
2019-01-10 1:19 ` Steve Longerbeam [this message]
2019-01-15 1:03 ` Steve Longerbeam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da87789d-73e8-663c-a25f-d75e4361ade3@gmail.com \
--to=slongerbeam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).