From: Dmitry Osipenko <digetx@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>,
mchehab@kernel.org, gregkh@linuxfoundation.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
robin.murphy@arm.com, sakari.ailus@linux.intel.com
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
linux-media@vger.kernel.org, linux-tegra@vger.kernel.org,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH] media: staging: tegra-vde: Fix build error
Date: Thu, 25 Jul 2019 10:19:13 +0300 [thread overview]
Message-ID: <dd547b44-7abb-371f-aeee-a82b96f824e2@gmail.com> (raw)
In-Reply-To: <20190725024129.22664-1-yuehaibing@huawei.com>
25.07.2019 5:41, YueHaibing пишет:
> If IOMMU_SUPPORT is not set, and COMPILE_TEST is y,
> IOMMU_IOVA may be set to m. So building will fails:
>
> drivers/staging/media/tegra-vde/iommu.o: In function `tegra_vde_iommu_map':
> iommu.c:(.text+0x41): undefined reference to `alloc_iova'
> iommu.c:(.text+0x56): undefined reference to `__free_iova'
>
> Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Suggested-by: Dmitry Osipenko <digetx@gmail.com>
> Fixes: b301f8de1925 ("media: staging: media: tegra-vde: Add IOMMU support")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/staging/media/tegra-vde/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/tegra-vde/Kconfig b/drivers/staging/media/tegra-vde/Kconfig
> index 2e7f644..ba49ea5 100644
> --- a/drivers/staging/media/tegra-vde/Kconfig
> +++ b/drivers/staging/media/tegra-vde/Kconfig
> @@ -3,7 +3,7 @@ config TEGRA_VDE
> tristate "NVIDIA Tegra Video Decoder Engine driver"
> depends on ARCH_TEGRA || COMPILE_TEST
> select DMA_SHARED_BUFFER
> - select IOMMU_IOVA if IOMMU_SUPPORT
> + select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST)
> select SRAM
> help
> Say Y here to enable support for the NVIDIA Tegra video decoder
>
This results in missing the case of compile-testing !IOMMU_IOVA for the
driver, but probably that's not a big deal.
Acked-by: Dmitry Osipenko <digetx@gmail.com>
next prev parent reply other threads:[~2019-07-25 7:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 13:47 [PATCH] media: staging: ipu3: Enable IOVA API only when IOMMU support is enabled YueHaibing
2019-07-24 10:30 ` Sakari Ailus
2019-07-24 13:49 ` Robin Murphy
2019-07-24 14:03 ` Yuehaibing
2019-07-24 14:09 ` Dmitry Osipenko
2019-07-24 14:23 ` Robin Murphy
2019-07-24 14:28 ` Dmitry Osipenko
2019-07-25 2:41 ` [PATCH] media: staging: tegra-vde: Fix build error YueHaibing
2019-07-25 7:19 ` Dmitry Osipenko [this message]
2019-09-20 19:32 ` Arnd Bergmann
2019-09-20 22:26 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd547b44-7abb-371f-aeee-a82b96f824e2@gmail.com \
--to=digetx@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sakari.ailus@linux.intel.com \
--cc=thierry.reding@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).