From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 104AAC433E9 for ; Thu, 24 Dec 2020 14:01:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D565222287 for ; Thu, 24 Dec 2020 14:01:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728376AbgLXOB1 (ORCPT ); Thu, 24 Dec 2020 09:01:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726609AbgLXOB1 (ORCPT ); Thu, 24 Dec 2020 09:01:27 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4BD4C061794; Thu, 24 Dec 2020 06:00:46 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id 91so2249378wrj.7; Thu, 24 Dec 2020 06:00:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hTZYu0KyYNj6GV2bBjh3qdlRgAwRDrZxZXOKPRcg84c=; b=jiGvw60pmyZpHGhIJzNBYgP2ZTYSe+VnyxjnYIr+4u8iTKTN21QV+44OhsfqCw7VW8 lZ5OeT4hf6sDduKPRa1gWUbK4PAEAh0D6dhG03iEYbtisuv6/t1Lw8r1a8BGjVSnI5mF rAsvVuThEHRhgM90vJtP11SEB5GDJ25CAr1EyT5BziG9phgkcgoBlwOgiPMUenv1Nvf4 E/Wyd6iIhE/xdYVXIl5sX1wwNLm9Ad46AEZTasiZMQaBjyzP9EETbZnYCGWaYX8qp2gt lcsYTH9XP0gdcjEECO87XqqYjk8GM6Y9yxvDBW99BllbIDxhCljRDblhe+b/sZShu69V jGwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hTZYu0KyYNj6GV2bBjh3qdlRgAwRDrZxZXOKPRcg84c=; b=pVfGHuAc6JGqNlz8a8SYLQPLk/DXI8P32u1ApZDoQkw9Aln9IQ5s7bcQl4C3ojUTcL omnsQKWLu9any/8daZ0NgofAsgOlsvt1cHLiB6e+ST17cDbTw97Fmp0HQ/s9B8DQE6zD aSvtutiLdIh/9zyhzERVrT1RhEBlMWM/IbkccDVkJx6vBKMpdzJfexooa93ywDJQvAo7 U+aV5RJDDus8NTrILKEEbL7lmQNjB5/rLK6qmtS50+nl4kaYIQS3Sk2y2pBA2FzbnUt2 P+BBJnDNXMPvnadrLvwfsTbdeujIelbYBDgzENzZ+Yoo5S/wz+bbskyLpT2Irs6Mol40 CGeg== X-Gm-Message-State: AOAM530MEYSUj5VxtwFG4aKFyoo8+s+z54OtLsItfuUIgsOeiZZAJzpH XI4tMzG1dbxQYD9kKo76wWE= X-Google-Smtp-Source: ABdhPJx+Z0EJqXx/2AjrwRP+xuKb0XQTgwvxvJSravZrEZ5dPl56k33iW2pd5DGEMbQAm/r9ZBJ2ng== X-Received: by 2002:a5d:56c3:: with SMTP id m3mr34636969wrw.419.1608818445462; Thu, 24 Dec 2020 06:00:45 -0800 (PST) Received: from [192.168.1.211] ([2.31.224.116]) by smtp.gmail.com with ESMTPSA id h13sm38544866wrm.28.2020.12.24.06.00.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Dec 2020 06:00:44 -0800 (PST) Subject: Re: [PATCH v3 05/14] software_node: unregister software_nodes in reverse order To: Andy Shevchenko Cc: Linux Kernel Mailing List , ACPI Devel Maling List , Linux Media Mailing List , devel@acpica.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Yong Zhi , Sakari Ailus , Bingbu Cao , Tian Shu Qiu , Mauro Carvalho Chehab , Robert Moore , Erik Kaneda , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, Hans Verkuil , Marco Felsch , niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam , "Krogerus, Heikki" , Linus Walleij , kernel test robot , Dan Carpenter , Laurent Pinchart References: <20201224010907.263125-1-djrscally@gmail.com> <20201224010907.263125-6-djrscally@gmail.com> From: Daniel Scally Message-ID: Date: Thu, 24 Dec 2020 14:00:42 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 24/12/2020 12:13, Andy Shevchenko wrote: > On Thu, Dec 24, 2020 at 3:12 AM Daniel Scally wrote: >> >> To maintain consistency with software_node_unregister_nodes(), reverse >> the order in which the software_node_unregister_node_group() function >> unregisters nodes. > > ... > >> - * Unregister multiple software nodes at once. >> + * Unregister multiple software nodes at once. The array will be unwound in >> + * reverse order (i.e. last entry first) and thus if any member of the array >> + * has its .parent member set then they should appear later in the array such >> + * that they are unregistered first. > > I'm, as being not a native speaker, a bit confused by this comment. > The idea is that children are unregistered first. Can you try to make > it more clear maybe? Sure, how about: The array will be unwound in reverse order (i.e. last entry first). If any member of the array is a child of another member then the child must appear later in the array than their parent, so that they are unregistered first. ?