linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-media@vger.kernel.org,
	Guennadi Liakhovetski <guennadi.liakhovetski@intel.com>,
	Songjun Wu <songjun.wu@microchip.com>
Subject: Re: [PATCH 00/15] atmel-isi/ov7670/ov2640: convert to standalone drivers
Date: Mon, 2 Jan 2017 14:41:47 +0100	[thread overview]
Message-ID: <e4683b1b-7b4f-debe-41c9-9e8a18115824@xs4all.nl> (raw)
In-Reply-To: <0983edff-25ef-fc9b-3c13-7fad442dac70@xs4all.nl>

On 01/02/17 14:37, Hans Verkuil wrote:
> On 12/18/16 23:10, Sakari Ailus wrote:
>> On Mon, Dec 12, 2016 at 04:55:05PM +0100, Hans Verkuil wrote:
>>> From: Hans Verkuil <hans.verkuil@cisco.com>
>>>
>>> This patch series converts the soc-camera atmel-isi to a standalone V4L2
>>> driver.
>>>
>>> The same is done for the ov7670 and ov2640 sensor drivers: the ov7670 was
>>> used to test the atmel-isi driver. The ov2640 is needed because the em28xx
>>> driver has a soc_camera include dependency. Both ov7670 and ov2640 sensors
>>> have been tested with the atmel-isi driver.
>>>
>>> The first 6 patches improve the ov7670 sensor driver, mostly adding modern
>>> features such as MC and DT support.
>>>
>>> The next three convert the atmel-isi and move it out of soc_camera.
>>
>> You're adding Media controller support but without device nodes. Does that
>> make sense? You'll have an entity but the user won't be able to do anything
>> with it.
>>
>
> Well, without the MC support the sensor driver wouldn't load since the atmel
> driver expects that the subdev is MC-enabled. However, the atmel-isi doesn't
> need the user to configure the pipeline, it's just a simple standard v4l driver.
>
> So just filling in the entity information is sufficient in this case.
>
> That said, I see that the atmel-isi driver calls v4l2_device_register_subdev_nodes().
> Since this is a simple V4L driver, that call should probably be dropped, since
> we really don't want or need subdev nodes.
>
> I will also need to take another look at the atmel-isi code to see if this MC
> dependency is really needed: I think I copied some of that code from the rcar
> driver, and it may not be relevant for the atmel driver.

In fact, I don't think it is needed at all.

But does it hurt to add MC support to these ov drivers?

Regards,

	Hans

  reply	other threads:[~2017-01-02 13:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-12 15:55 [PATCH 00/15] atmel-isi/ov7670/ov2640: convert to standalone drivers Hans Verkuil
2016-12-12 15:55 ` [PATCH 01/15] ov7670: add media controller support Hans Verkuil
2016-12-18 22:07   ` Sakari Ailus
2016-12-12 15:55 ` [PATCH 02/15] ov7670: call v4l2_async_register_subdev Hans Verkuil
2016-12-18 22:08   ` Sakari Ailus
2017-01-02 13:09     ` Hans Verkuil
2016-12-12 15:55 ` [PATCH 03/15] ov7670: fix g/s_parm Hans Verkuil
2016-12-12 15:55 ` [PATCH 04/15] ov7670: get xclk Hans Verkuil
2016-12-18 22:15   ` Sakari Ailus
2017-01-02 13:18     ` Hans Verkuil
2016-12-12 15:55 ` [PATCH 05/15] ov7670: add devicetree support Hans Verkuil
2016-12-12 15:55 ` [PATCH 06/15] ov7670: document device tree bindings Hans Verkuil
2016-12-12 15:55 ` [PATCH 07/15] atmel-isi: remove dependency of the soc-camera framework Hans Verkuil
2016-12-12 15:55 ` [PATCH 08/15] atmel-isi: move out of soc_camera to atmel Hans Verkuil
2016-12-12 15:55 ` [PATCH 09/15] atmel-isi: document device tree bindings Hans Verkuil
2016-12-12 15:55 ` [PATCH 10/15] ov2640: convert from soc-camera to a standard subdev sensor driver Hans Verkuil
2016-12-12 15:55 ` [PATCH 11/15] ov2640: enable clock, fix power/reset and add MC support Hans Verkuil
2016-12-12 15:55 ` [PATCH 12/15] ov2640 bindings update Hans Verkuil
2016-12-12 15:55 ` [PATCH 13/15] em28xx: drop last soc_camera link Hans Verkuil
2016-12-12 15:55 ` [PATCH 14/15] sama5d3 dts: enable atmel-isi Hans Verkuil
2016-12-12 15:55 ` [PATCH 15/15] at91-sama5d3_xplained.dts: select ov2640 Hans Verkuil
2016-12-18 22:10 ` [PATCH 00/15] atmel-isi/ov7670/ov2640: convert to standalone drivers Sakari Ailus
2017-01-02 13:37   ` Hans Verkuil
2017-01-02 13:41     ` Hans Verkuil [this message]
2017-01-02 21:09       ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4683b1b-7b4f-debe-41c9-9e8a18115824@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=guennadi.liakhovetski@intel.com \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@iki.fi \
    --cc=songjun.wu@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).