From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] vivid: do not implement VIDIOC_S_PARM for output streams
Date: Fri, 11 Jan 2019 15:13:46 -0500 [thread overview]
Message-ID: <e51b9648691804cc97868a79d56e713df8e938c5.camel@ndufresne.ca> (raw)
In-Reply-To: <fc0e18f4-b499-60b4-d750-12beb06f98ce@xs4all.nl>
Le vendredi 11 janvier 2019 à 12:37 +0100, Hans Verkuil a écrit :
> v4l2_compliance gave a warning for the S_PARM test for output streams:
>
> warn: v4l2-test-formats.cpp(1235): S_PARM is supported for buftype 2, but not for ENUM_FRAMEINTERVALS
>
> The reason is that vivid mapped s_parm for output streams to g_parm. But if
> S_PARM doesn't actually change anything, then it shouldn't be enabled at all.
Though now, a vivid output reflect even less an output HW, for which I
would expect S_PARM to be used to configure the HW transmission clock.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> ---
> diff --git a/drivers/media/platform/vivid/vivid-core.c b/drivers/media/platform/vivid/vivid-core.c
> index c931f007e5b0..7da5720b47a2 100644
> --- a/drivers/media/platform/vivid/vivid-core.c
> +++ b/drivers/media/platform/vivid/vivid-core.c
> @@ -371,7 +371,7 @@ static int vidioc_s_parm(struct file *file, void *fh,
>
> if (vdev->vfl_dir == VFL_DIR_RX)
> return vivid_vid_cap_s_parm(file, fh, parm);
> - return vivid_vid_out_g_parm(file, fh, parm);
> + return -ENOTTY;
> }
>
> static int vidioc_log_status(struct file *file, void *fh)
next prev parent reply other threads:[~2019-01-11 20:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 11:37 [PATCH] vivid: do not implement VIDIOC_S_PARM for output streams Hans Verkuil
2019-01-11 20:13 ` Nicolas Dufresne [this message]
2019-01-11 20:16 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e51b9648691804cc97868a79d56e713df8e938c5.camel@ndufresne.ca \
--to=nicolas@ndufresne.ca \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).