From: Daniel Scally <djrscally@gmail.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, paul.kocialkowski@bootlin.com,
kevin.lhopital@bootlin.com
Subject: Re: [PATCH] media: i2c: Fix regulator disable balance in ov8865
Date: Wed, 2 Feb 2022 12:37:43 +0000 [thread overview]
Message-ID: <eaf74f02-f559-dffe-3002-0768db6fcfc2@gmail.com> (raw)
In-Reply-To: <Yfp3YpPto0o+uP3l@paasikivi.fi.intel.com>
Hi Sakari
On 02/02/2022 12:21, Sakari Ailus wrote:
> Hi Daniel,
>
> On Sun, Jan 30, 2022 at 09:36:21PM +0000, Daniel Scally wrote:
>> ov8865_sensor_power() disables all three of the sensor's regulators
>> on the error path, however not all of the regulators may have been
>> enabled at the time of the error, which will result in unbalanced
>> disable calls.
>>
>> Fix the issue by adding specific error paths for each regulator.
>>
>> Fixes: 11c0d8fdccc5 ("media: i2c: Add support for the OV8865 image sensor")
>>
>> Signed-off-by: Daniel Scally <djrscally@gmail.com>
> Thanks for the patch.
>
> This has been already fixed by commit
> cbe0b3af73bf72fad197756f026084404e2bcdc7 (in media tree).
>
Ah cool ok - my bad :)
prev parent reply other threads:[~2022-02-02 12:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 21:36 [PATCH] media: i2c: Fix regulator disable balance in ov8865 Daniel Scally
2022-02-02 12:21 ` Sakari Ailus
2022-02-02 12:37 ` Daniel Scally [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaf74f02-f559-dffe-3002-0768db6fcfc2@gmail.com \
--to=djrscally@gmail.com \
--cc=kevin.lhopital@bootlin.com \
--cc=linux-media@vger.kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).