From: "Christian König" <christian.koenig@amd.com>
To: "Yadav, Arvind" <arvyadav@amd.com>,
Arvind Yadav <Arvind.Yadav@amd.com>,
andrey.grodzovsky@amd.com, shashank.sharma@amd.com,
amaranath.somalapuram@amd.com, Arunpravin.PaneerSelvam@amd.com,
sumit.semwal@linaro.org, gustavo@padovan.org, airlied@linux.ie,
daniel@ffwll.ch, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] dma-buf: Check status of enable-signaling bit on debug
Date: Thu, 29 Sep 2022 20:32:08 +0200 [thread overview]
Message-ID: <efce6f23-135d-d946-6677-0668d83a7831@amd.com> (raw)
In-Reply-To: <52ed8ec2-bd90-ad40-fe85-83d60eda7e05@amd.com>
Am 29.09.22 um 20:30 schrieb Yadav, Arvind:
>
> On 9/29/2022 11:48 PM, Christian König wrote:
>> Am 27.09.22 um 19:24 schrieb Arvind Yadav:
>>> Fence signaling must be enabled to make sure that
>>> the dma_fence_is_signaled_locked() function ever returns true.
>>> Since drivers and implementations sometimes mess this up,
>>> this ensures correct behaviour when DMABUF_DEBUG_ENABLE_SIGNALING
>>> is used during debugging.
>>> This should make any implementation bugs resulting in not
>>> signaled fences much more obvious.
>>
>> Are all IGT tests now passing with this? That would be a bit
>> unfortunate because it means we still have missed the bug in
>> drm_syncobj.
>>
> IGT has these test cases related to syncobj (syncobj_basic,
> syncobj_timeline and syncobj_wait)and all are passing.
>
> I will check syncobj and let you know.
Maybe CC the Intel list and let their CI systems take a look. That's
usually rather valuable.
Thanks,
Christian.
>
> ~Arvind
>
>> Christian.
>>
>>>
>>> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
>>> ---
>>> include/linux/dma-fence.h | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
>>> index 775cdc0b4f24..5156dc6be0a6 100644
>>> --- a/include/linux/dma-fence.h
>>> +++ b/include/linux/dma-fence.h
>>> @@ -398,6 +398,11 @@ void dma_fence_enable_sw_signaling(struct
>>> dma_fence *fence);
>>> static inline bool
>>> dma_fence_is_signaled_locked(struct dma_fence *fence)
>>> {
>>> +#ifdef CONFIG_DMABUF_DEBUG_ENABLE_SIGNALING
>>> + if (!test_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT, &fence->flags))
>>> + return false;
>>> +#endif
>>> +
>>> if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
>>> return true;
>>
next prev parent reply other threads:[~2022-09-29 18:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 17:24 [PATCH 0/3] dma-buf: Check status of enable-signaling bit on debug Arvind Yadav
2022-09-27 17:24 ` [PATCH 1/3] dma-buf: Remove the signaled bit status check Arvind Yadav
2022-09-29 18:14 ` Christian König
2022-09-27 17:24 ` [PATCH 2/3] dma-buf: Enable signaling on fence for sw_sync Arvind Yadav
2022-09-29 18:17 ` Christian König
2022-09-27 17:24 ` [PATCH 3/3] dma-buf: Check status of enable-signaling bit on debug Arvind Yadav
2022-09-29 18:18 ` Christian König
2022-09-29 18:30 ` Yadav, Arvind
2022-09-29 18:32 ` Christian König [this message]
2022-09-30 7:32 ` Yadav, Arvind
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efce6f23-135d-d946-6677-0668d83a7831@amd.com \
--to=christian.koenig@amd.com \
--cc=Arunpravin.PaneerSelvam@amd.com \
--cc=Arvind.Yadav@amd.com \
--cc=airlied@linux.ie \
--cc=amaranath.somalapuram@amd.com \
--cc=andrey.grodzovsky@amd.com \
--cc=arvyadav@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=shashank.sharma@amd.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).