From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72FBCC433E6 for ; Sat, 2 Jan 2021 17:13:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3970021E92 for ; Sat, 2 Jan 2021 17:13:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726671AbhABRNc (ORCPT ); Sat, 2 Jan 2021 12:13:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726567AbhABRNb (ORCPT ); Sat, 2 Jan 2021 12:13:31 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D237C061573; Sat, 2 Jan 2021 09:12:51 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id 91so26745453wrj.7; Sat, 02 Jan 2021 09:12:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=y5jH9d3mdO81XtDuxyfUPY1UFIU5znarbecHqlhGczQ=; b=mjZVp6hZbYMv9W1gx7ozhlf+SugBbLntN7v80midD1IWeVRxOjuFqO4M+nuO6n8hTp 6XDG8vmtC7a5rfJ2aUOZAM5u96eB3ic3pSj4N+w6gOkmg23exWKgK4kTyOD6GEQ3fHzu Gn7OonVsZP72LNGnwEm81H117ulbYc7lhRqFeQFb5F//VgDmhipbIsWaROMFqN7RleiF 4W1J5bigkMI/NQi0eKvb6YqhpoptEE+8+HY+TK1RIamIOR3dqYOtAnGm1WWqCEyD+K47 TAcBlXuY52EE1tsYi6HNo9sdomtyid9idr4gP5bwuczYBpXGPGaXWDFt71mz7zfoi+yk QYSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=y5jH9d3mdO81XtDuxyfUPY1UFIU5znarbecHqlhGczQ=; b=ev+NObkvMWBuUV70uIJMFZh32k4CdjgDlUG8Q06jcGV405LE4PlzbhUDUwmhkBCB00 +H7jSKhRiy/PoPLxaCzzXJz5p5IzZN1MRs7nnIa3+uWIoeMi0SYA/3nMsbY3i9Nu6OTk vOnYEQigLuv+/iPF4jsGcflna9EGx/ghLjH3SDtojSj9Obs0cLbUMdy6T4oBpxRBOkRJ QM6miP5keONBI6G2YbxOtguxkH3bjA3dQMnfDJORJVrCfgF7jHyoolBrkkBu9Mo1fsHo JJbST9tI0bkTN9Tdl2xoKMpTg7sBE6WXkr5DnMg321+pUluyCLZJBvWbPhndczhss5vG zh0g== X-Gm-Message-State: AOAM531TqxV1Lat7eEEsKf2t5ihCCGTpbfZohNK/vac0utcntlIuABl4 CEqZ1uiUy2CI3mPH1dGIpYA= X-Google-Smtp-Source: ABdhPJy9rROhgUUjUnk6hAJOgUyxMKwRrQCjmHodD3/8bZVpmDxS6GvBtIu64TWtc81hVo/ggfC1+Q== X-Received: by 2002:adf:e98b:: with SMTP id h11mr72049927wrm.21.1609607569935; Sat, 02 Jan 2021 09:12:49 -0800 (PST) Received: from [192.168.1.211] ([2.29.208.120]) by smtp.gmail.com with ESMTPSA id z22sm23163411wml.1.2021.01.02.09.12.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Jan 2021 09:12:49 -0800 (PST) Subject: Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver To: Sakari Ailus Cc: Andy Shevchenko , Linux Kernel Mailing List , ACPI Devel Maling List , Linux Media Mailing List , devel@acpica.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Yong Zhi , Bingbu Cao , Tian Shu Qiu , Mauro Carvalho Chehab , Robert Moore , Erik Kaneda , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, Hans Verkuil , Marco Felsch , niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam , "Krogerus, Heikki" , Linus Walleij , Jordan Hand , Laurent Pinchart References: <20201224010907.263125-1-djrscally@gmail.com> <20201224010907.263125-15-djrscally@gmail.com> <20201228170521.GZ26370@paasikivi.fi.intel.com> <2d37df3d-f04c-6679-6e27-6c7f82e9b158@gmail.com> <20210102170731.GD11878@paasikivi.fi.intel.com> From: Daniel Scally Message-ID: Date: Sat, 2 Jan 2021 17:12:47 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210102170731.GD11878@paasikivi.fi.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Sakari On 02/01/2021 17:07, Sakari Ailus wrote: > Hi Daniel, > > On Mon, Dec 28, 2020 at 10:37:38PM +0000, Daniel Scally wrote: >>>>> +#define CIO2_NUM_PORTS 4 >>> This is already defined in ipu3-cio2.h. Could you include that instead? >> Yes; but I'd need to also include media/v4l2-device.h and >> media/videobuf2-dma-sg.h (they're included in ipu3-cio2-main.c at the >> moment). It didn't seem worth it; but I can move those two includes from >> the .c to the .h and then include ipu3-cio2.h in cio2-bridge.h >> >> Which do you prefer? > Seems you got answers already... :-) splitting the header in two seems good > to me. But IMO it doesn't have to be a part of this set. > Yeah I've been hesitating over this; if we chose not to do it in this set though, how would you want me to deal with the double definition of CIO2_NUM_PORTS