From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>, "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>, linux-media@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Jacopo Mondi <jacopo+renesas@jmondi.org>, Geert Uytterhoeven <geert+renesas@glider.be> Subject: Re: [PATCH v2] rcar-vin: Clean up correct notifier in error path Date: Wed, 17 Jul 2019 14:34:24 +0100 [thread overview] Message-ID: <fa6f9b8a-42a8-88be-de7b-878dac131627@ideasonboard.com> (raw) In-Reply-To: <20190702174258.11128-1-niklas.soderlund+renesas@ragnatech.se> Hi Niklas, On 02/07/2019 18:42, Niklas Söderlund wrote: > The parallel input initialization error path cleans up the wrong > async notifier, fix this by cleaning up the correct notifier. > > Fixes: 9863bc8695bc36e3 ("media: rcar-vin: Cleanup notifier in error path") > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/media/platform/rcar-vin/rcar-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c > index 64f9cf790445d14e..a6efe1a8099a6ae6 100644 > --- a/drivers/media/platform/rcar-vin/rcar-core.c > +++ b/drivers/media/platform/rcar-vin/rcar-core.c > @@ -633,7 +633,7 @@ static int rvin_parallel_init(struct rvin_dev *vin) > ret = v4l2_async_notifier_register(&vin->v4l2_dev, &vin->notifier); > if (ret < 0) { > vin_err(vin, "Notifier registration failed\n"); > - v4l2_async_notifier_cleanup(&vin->group->notifier); > + v4l2_async_notifier_cleanup(&vin->notifier); > return ret; > } > >
prev parent reply other threads:[~2019-07-17 13:34 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-02 17:42 Niklas Söderlund 2019-07-17 13:34 ` Kieran Bingham [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fa6f9b8a-42a8-88be-de7b-878dac131627@ideasonboard.com \ --to=kieran.bingham+renesas@ideasonboard.com \ --cc=geert+renesas@glider.be \ --cc=jacopo+renesas@jmondi.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=niklas.soderlund+renesas@ragnatech.se \ --subject='Re: [PATCH v2] rcar-vin: Clean up correct notifier in error path' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).