From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
koji.matsuoka.xm@renesas.com, takeshi.kihara.df@renesas.com,
harunobu.kurokawa.dn@renesas.com, khiem.nguyen.xt@renesas.com,
hien.dang.eb@renesas.com
Subject: Re: [PATCH] media: vsp1: tidyup VI6_HGT_LBn_H() macro
Date: Wed, 11 Dec 2019 12:59:57 +0000 [thread overview]
Message-ID: <fb1648d4-3949-01c1-7d13-679b9b8540dd@ideasonboard.com> (raw)
In-Reply-To: <87k173bp76.wl-kuninori.morimoto.gx@renesas.com>
Hi Morimoto-san,
Thank you for the patch,
On 11/12/2019 01:55, Kuninori Morimoto wrote:
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> The address of VSP2_VI6_HGT_LBx_H are
> VSP2_VI6_HGT_LB0_H : 0x3428
> VSP2_VI6_HGT_LB1_H : 0x3430
> VSP2_VI6_HGT_LB2_H : 0x3438
> VSP2_VI6_HGT_LB3_H : 0x3440
>
> Thus, VI6_HGT_LBn_H() macro should start from 0x3420 instead of 0x3430.
> This patch fixup it.
I think this deserves a fixes tag:
Fixes: 26e0ca22c3b8 ("[media] v4l: Renesas R-Car VSP1 driver")
> Reported-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Otherwise,
Yes I can clearly see that this offset is marked as H'3428 at page 32-39
within the Gen3 datasheet.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/media/platform/vsp1/vsp1_regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_regs.h b/drivers/media/platform/vsp1/vsp1_regs.h
> index 5c67ff9..fe3130d 100644
> --- a/drivers/media/platform/vsp1/vsp1_regs.h
> +++ b/drivers/media/platform/vsp1/vsp1_regs.h
> @@ -706,7 +706,7 @@
> #define VI6_HGT_HUE_AREA_LOWER_SHIFT 16
> #define VI6_HGT_HUE_AREA_UPPER_SHIFT 0
> #define VI6_HGT_LB_TH 0x3424
> -#define VI6_HGT_LBn_H(n) (0x3438 + (n) * 8)
> +#define VI6_HGT_LBn_H(n) (0x3428 + (n) * 8)
> #define VI6_HGT_LBn_V(n) (0x342c + (n) * 8)
> #define VI6_HGT_HISTO(m, n) (0x3450 + (m) * 128 + (n) * 4)
> #define VI6_HGT_MAXMIN 0x3750
>
next prev parent reply other threads:[~2019-12-11 13:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-245033.20191211005426@dm.renesas.com>
[not found] ` <redmine.issue-245033.20191211005426.161918957b73008d@dm.renesas.com>
2019-12-11 1:55 ` [PATCH] media: vsp1: tidyup VI6_HGT_LBn_H() macro Kuninori Morimoto
2019-12-11 12:59 ` Kieran Bingham [this message]
2019-12-11 17:58 ` Laurent Pinchart
2019-12-11 21:58 ` Kieran Bingham
2019-12-11 23:45 ` Laurent Pinchart
2019-12-12 7:33 ` Greg Kroah-Hartman
2019-12-13 11:55 ` Kieran Bingham
2019-12-13 13:22 ` Geert Uytterhoeven
2019-12-13 22:43 ` Laurent Pinchart
2019-12-15 15:45 ` Sasha Levin
2020-02-12 0:43 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb1648d4-3949-01c1-7d13-679b9b8540dd@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=harunobu.kurokawa.dn@renesas.com \
--cc=hien.dang.eb@renesas.com \
--cc=khiem.nguyen.xt@renesas.com \
--cc=koji.matsuoka.xm@renesas.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=takeshi.kihara.df@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).